From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B9DAC77B7A for ; Wed, 31 May 2023 17:10:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230169AbjEaRKZ (ORCPT ); Wed, 31 May 2023 13:10:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230246AbjEaRKT (ORCPT ); Wed, 31 May 2023 13:10:19 -0400 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E426619F for ; Wed, 31 May 2023 10:10:16 -0700 (PDT) Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-96f5d651170so258469466b.1 for ; Wed, 31 May 2023 10:10:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685553015; x=1688145015; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zpBJqIwBo/Nu/C67n+mvjWj82gMrvBIQFujOHL40XB8=; b=PaJB+Ng5ASA7xTgcSbUVpUXunxTc7VxQ2TefYHq5FUs6+2/Jl0hscxC9gtxPnYEh2P ieebqg+vkJGB/GYKvuOHiaKUn1dZfUC6uwW/7V+R1MwdWPTwfNA2WHA/mtPTeO70hWiO uoZO+E/i8aaWBLpoUe0UyhzzUuantqeVuoydLrPc5Z7un7aX/v/VPsjpU0pP+5BoXw9T R8fcLH1Kh+uWC2RuO+vT3CdQnPNrwSiNKvUlMRmLFsNFQknRr4kgA28CZjvFv+lK8oLy jDIjKreApep2oXmvDEA+kxYmf8g3WiMks3pQC4jnww8Kc+AJOkpK/qCnqAT/Xord0uEo FU3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685553015; x=1688145015; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zpBJqIwBo/Nu/C67n+mvjWj82gMrvBIQFujOHL40XB8=; b=k/k1x6+Y5BMkgcpBGQHoynW0RoytpLqMwLf6tFQi3BSPkhEqXqYV/2UqHDhZe6F+3J ISCiRkZqxU6flpGKvQUpYkZYbTo9s5+MVvSCNgzX11WNPbos9JRgY+dVOsQXxWy1jf5M J6A/0kB74LjqRPwaf4qJPh3xoULiqKQLXsFyMoJnM9wA7gkzNtj/bEKErnXSNH97j4BY i3hkC3q6drZyHRJK0teSwRth7ZBr4/Ek2u0scWGH7Xd4rlFPpfwU0jLeLJrPHLHSjb6i WeFrHSJIWn/6uZtTvDHZflFvzKCEwXK4LYnE8suz49hXStdPHL7h+2PvrK5J9ozEmRQP hGKA== X-Gm-Message-State: AC+VfDzO4Y/EsCClFWBWZs9252uNlYFY7t7gO32nL1R9xHAby5LDiIYY VdeGQBTTZgKMFoKmREGH6epRJg== X-Google-Smtp-Source: ACHHUZ7TZwZNXK5uqe69QR9cTTnHMALGXf0usZ9T15HkEXXRZQbXWbmqk6khd6Ya+IxxETVZ9fpqhA== X-Received: by 2002:a17:907:9721:b0:94f:2916:7d7 with SMTP id jg33-20020a170907972100b0094f291607d7mr6059751ejc.19.1685553015225; Wed, 31 May 2023 10:10:15 -0700 (PDT) Received: from [192.168.1.20] ([178.197.199.204]) by smtp.gmail.com with ESMTPSA id b8-20020a1709064d4800b00965f31ff894sm9200289ejv.137.2023.05.31.10.10.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 May 2023 10:10:14 -0700 (PDT) Message-ID: Date: Wed, 31 May 2023 19:10:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] soc: qcom: icc-bwmon: Fix MSM8998 count unit To: Konrad Dybcio , Andy Gross , Bjorn Andersson Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230531-topic-msm8998-bwmon-v1-1-454f9d550ee5@linaro.org> <693a36cf-e9d5-a6f1-3953-3a7c7567a754@linaro.org> <89faee17-7858-194e-8af7-953a2631eb8d@linaro.org> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: <89faee17-7858-194e-8af7-953a2631eb8d@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31/05/2023 19:05, Konrad Dybcio wrote: > > > On 31.05.2023 19:03, Krzysztof Kozlowski wrote: >> On 31/05/2023 18:33, Konrad Dybcio wrote: >>> MSM8998's BWMON counts in megabytes. Fix it. >>> >>> Signed-off-by: Konrad Dybcio >>> --- >>> drivers/soc/qcom/icc-bwmon.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> If this is >> https://lore.kernel.org/all/33c61f23-6442-6d9b-492f-dd6e9c64a8c1@quicinc.com/ >> (and QLT 1872) then add reported-by tag. > It's not, I fired up 8998, added debug prints and ran mybw. > >> >> Change seems logical, although not really documented (a bit >> contradictory information for sdm845), so assuming this was really tested: > It's not for sdm845, after the last cleanup both BWMONs on that > one got its own driver data struct. Ah, ok, Acks stays :) Best regards, Krzysztof