From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5946FC433F5 for ; Tue, 15 Feb 2022 06:26:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234388AbiBOG0n (ORCPT ); Tue, 15 Feb 2022 01:26:43 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:40734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234031AbiBOG0i (ORCPT ); Tue, 15 Feb 2022 01:26:38 -0500 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7CC82DE91; Mon, 14 Feb 2022 22:26:27 -0800 (PST) X-UUID: d29e7747ab784e26815e4689f12baa0c-20220215 X-UUID: d29e7747ab784e26815e4689f12baa0c-20220215 Received: from mtkmbs10n2.mediatek.inc [(172.21.101.183)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 903098370; Tue, 15 Feb 2022 14:26:24 +0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.3; Tue, 15 Feb 2022 14:26:23 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 15 Feb 2022 14:26:23 +0800 Message-ID: Subject: Re: [PATCH v3 08/31] clk: mediatek: cpumux: Clean up included headers From: Chun-Jie Chen To: Chen-Yu Tsai , Stephen Boyd , Michael Turquette , Matthias Brugger CC: AngeloGioacchino Del Regno , Miles Chen , , , , Date: Tue, 15 Feb 2022 14:26:23 +0800 In-Reply-To: <20220208124034.414635-9-wenst@chromium.org> References: <20220208124034.414635-1-wenst@chromium.org> <20220208124034.414635-9-wenst@chromium.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2022-02-08 at 20:40 +0800, Chen-Yu Tsai wrote: > Some headers with the declaration of functions and structures aren't > directly included. Explicitly include them so that future changes to > other headers would not result in an unexpected build break. > > On the header side, add forward declarations for any data structures > whose pointers are used in function signatures. No headers are > required. > > Signed-off-by: Chen-Yu Tsai > Reviewed-by: Miles Chen > Reviewed-by: AngeloGioacchino Del Regno < > angelogioacchino.delregno@collabora.com> Reviewed-by: Chun-Jie Chen > --- > drivers/clk/mediatek/clk-cpumux.c | 3 +++ > drivers/clk/mediatek/clk-cpumux.h | 4 ++++ > 2 files changed, 7 insertions(+) > > diff --git a/drivers/clk/mediatek/clk-cpumux.c > b/drivers/clk/mediatek/clk-cpumux.c > index 344c6399b22f..658aee789f44 100644 > --- a/drivers/clk/mediatek/clk-cpumux.c > +++ b/drivers/clk/mediatek/clk-cpumux.c > @@ -5,8 +5,11 @@ > */ > > #include > +#include > +#include > #include > #include > +#include > #include > > #include "clk-mtk.h" > diff --git a/drivers/clk/mediatek/clk-cpumux.h > b/drivers/clk/mediatek/clk-cpumux.h > index a538f2bbef0d..b07e89f7c283 100644 > --- a/drivers/clk/mediatek/clk-cpumux.h > +++ b/drivers/clk/mediatek/clk-cpumux.h > @@ -7,6 +7,10 @@ > #ifndef __DRV_CLK_CPUMUX_H > #define __DRV_CLK_CPUMUX_H > > +struct clk_onecell_data; > +struct device_node; > +struct mtk_composite; > + > int mtk_clk_register_cpumuxes(struct device_node *node, > const struct mtk_composite *clks, int > num, > struct clk_onecell_data *clk_data);