From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52AEA35E558 for ; Tue, 6 Jan 2026 17:48:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767721682; cv=none; b=YobbvS7rc6bbp2DaVQSfyEl2bZv/XqzJQGfAS8czrmBlFYw5Xxss9x+pyfiaHj61LAYrRFX0d6IIrqyLHJGgS68b/xtgrGCvimYZMFReFaOsu33X+xRMWtn95LXWLdvk8ue0Zt0DZAvXiOADjkz/qidiseZ+iVMQs90SdwHswEI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767721682; c=relaxed/simple; bh=ViV00lj7QgZuijk1QbwmF3QeewIeKfNhLoJfNv7HKwk=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=B6a3N68bBnzuo5/+2uf7McEV4LV6e0ubHfUMYCA84CuOJZGONzVDOlK5PmAQdWmXeg/j5f8p5sfmefihHQQRepu/FH9hTDUzzby7L7wM3vw+yilBUF1vefS/EkoLeNgxq+fFLUT+UmDSB6Cy4S9zBrTypu/AzeneaxVZjRcViF4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=H2L+cvjc; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=oUgA4ZzH; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="H2L+cvjc"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="oUgA4ZzH" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767721680; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oJWDVsQrdjkI82W7XIRW9GZaQx38RzjOYQDx4fy9JYc=; b=H2L+cvjcEhsghpimg+v0937w511anwlPF7+MphCkRm82AnnMapuThpD7BxQ23woChZvf+p EXNjKwJGSmnJUdqholdK1xirLNO90t1gbey20DQA25x7g27cZdQ2lmjCsiROcfuhNsnJxr VeCWuaJ7oiiwuzPsbzewyWLyXyvVcQE= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-202-5iBfZtOcPgCjNAMPImr7rw-1; Tue, 06 Jan 2026 12:47:59 -0500 X-MC-Unique: 5iBfZtOcPgCjNAMPImr7rw-1 X-Mimecast-MFC-AGG-ID: 5iBfZtOcPgCjNAMPImr7rw_1767721678 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8ba026720eeso331901485a.1 for ; Tue, 06 Jan 2026 09:47:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767721678; x=1768326478; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=oJWDVsQrdjkI82W7XIRW9GZaQx38RzjOYQDx4fy9JYc=; b=oUgA4ZzHJqK9hSjfbITtnSapTt5AjtuyXhH6qFZFbohNES54kiaqtAnNQZKBGIZUpr wKBqHo59bdrPZuFIhxT2wQL8E+5AQxplAGfz/MgNx3Bx5p9KGp9CPDYF94BnACuqSz41 HehbfY/uDPkMirPGmLMkMjGnGnrl82B4x3QJaOIGFS3tsYrqvj9mkS9uFvGqnJjxw7iZ yWvTvxpMfPpniEVSujjS8yAOH5k1bcz3SvKDUbtUYdzCM6TF34M3d4Y6ktcXq5g13Gls WuAf8ila4XZ60krrYNrm5O9x5T93BWfg8ANSmXYs/35+rf4wmkd4eTQdNvASuGhXgz2U QfMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767721678; x=1768326478; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oJWDVsQrdjkI82W7XIRW9GZaQx38RzjOYQDx4fy9JYc=; b=byn3qr7mAZq7zUHfFfmFxSX688wysTvuBb0oYUioP8Lbg5KBd+oaue2sS/CNMp3WEZ NPIEf78IHh6vLSRITEjBC2R63cCw3mKLecl/GbSh9y4Wpe61/f6jttm/jDE8N0xqxQXs lFy25GHscdEUvbSAR3I5eXSN1+Umy1tnBwxB8IE9AgpkPMr2Cupv89AV6akKhVGZf6UM 9wsWgIMYjkuxP8cDikEa5mcGe2JK6CWD+TGk0p6xJzHtNsxV85lMJdsbL9xeY+gc+AzH K3ysQE0PF5ayp611x4NKPMB/wwCxQo83HhQRdPv7O6E7oU63u3BErgfzXrNv30lmxjhQ ebxQ== X-Forwarded-Encrypted: i=1; AJvYcCUZq9SVKxl66bu/hpG3mvlrsqC93VCN3UQqP7dNHuUxa4oQCApa6tl2OpcKHW5CkQIfEPBSdrTZJaFSLAE=@vger.kernel.org X-Gm-Message-State: AOJu0Yz+zjZzCHj6xF7OZPgTc4OcRo2nZqUYxOs+VuhwBcx9QAFNlBrN MuqCfvLliZwHGaNH7GLdDoLMfrwUvW3LyB1zbMxwekewMRvvPww4TlD2KIZTKlrFIT5RchYU8YX 94nfAtX1L/HbTOfLzUF4AqqmKnwQjL03k3FYwn67nC98XAPdgtzO3kh9vdytaECDY2A== X-Gm-Gg: AY/fxX7ioRUHSOFTFtw6P8n8qZlw8k+A63zYieP7IeO8a0q7N9YVP+FDnR/CdLEMW1J TC6rkT8bW4dt7Z728ET7SD7OI1CAeOPcwoehcvWIEwtCqCjRE3DMYQHUlvxbO0zTvCdZ6mEr0CB EaHYZXz+cyxHU99IICn9xYhZqWpKGekKxNlbPP5tvLYeuOZa0EfsMESfsCyetgw2JfE2Vghduvz lANvnDVbUQN5GkwFNuOojtFfldEExWsXTatAO+29+51wxwG3/FCL9dkU4dzC+rDt290GqjXsRNp rBL/cEiz+t+tSy8M7skSp5vaZ/vZ4j1KeZk63W4WhwWCE2ur3aoTWVlFziZ0tN9kXix4fQBMlOW M9L2u6rRsw9WdzdwZkxOyzy8hznK7tPONS0RDVppXhw== X-Received: by 2002:a05:620a:460c:b0:8b2:ef70:64f5 with SMTP id af79cd13be357-8c37eb9531fmr459175285a.48.1767721678547; Tue, 06 Jan 2026 09:47:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IEYhjDvwxLGXHNf6+LajgJjCf5rsdNaikOD40LwMHuIfDWWifrsAEjgFG5uPe7nk6mz2ZtTmw== X-Received: by 2002:a05:620a:460c:b0:8b2:ef70:64f5 with SMTP id af79cd13be357-8c37eb9531fmr459172285a.48.1767721678151; Tue, 06 Jan 2026 09:47:58 -0800 (PST) Received: from crwood-thinkpadp16vgen1.minnmso.csb ([2601:447:cc81:56d0:ab94:b2cb:29a6:7ac0]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8c37f53c422sm212786185a.46.2026.01.06.09.47.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jan 2026 09:47:57 -0800 (PST) Message-ID: Subject: Re: [PATCH v2 15/18] rtla: Make stop_tracing variable volatile From: Crystal Wood To: Steven Rostedt , Wander Lairson Costa Cc: Tomas Glozar , Ivan Pravdin , Costa Shulyupin , John Kacur , Tiezhu Yang , "open list:Real-time Linux Analysis (RTLA) tools" , "open list:Real-time Linux Analysis (RTLA) tools" , "open list:BPF [MISC]:Keyword:(?:\\b|_)bpf(?:\\b|_)" Date: Tue, 06 Jan 2026 11:47:56 -0600 In-Reply-To: <20260106110519.40c97efe@gandalf.local.home> References: <20260106133655.249887-1-wander@redhat.com> <20260106133655.249887-16-wander@redhat.com> <20260106110519.40c97efe@gandalf.local.home> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2 (3.56.2-2.fc42) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Tue, 2026-01-06 at 11:05 -0500, Steven Rostedt wrote: > On Tue, 6 Jan 2026 08:49:51 -0300 > Wander Lairson Costa wrote: >=20 > > Add the volatile qualifier to stop_tracing in both common.c and > > common.h to ensure all accesses to this variable bypass compiler > > optimizations and read directly from memory. This guarantees that > > when the signal handler sets stop_tracing, the change is immediately > > visible to the main program loop, preventing potential hangs or > > delayed shutdown when termination signals are received. >=20 > In the kernel, this is handled via the READ_ONCE() macro. Perhaps rtla > should implement that too. Or just get it from tools/include/linux/compiler.h. No need to reinvent the wheel (even though several other tools do). That said, signal safety is a pretty routine use for volatile. -Crystal