From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751262AbdBLLQF (ORCPT ); Sun, 12 Feb 2017 06:16:05 -0500 Received: from mail-lf0-f47.google.com ([209.85.215.47]:33158 "EHLO mail-lf0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751153AbdBLLQE (ORCPT ); Sun, 12 Feb 2017 06:16:04 -0500 Subject: Re: [PATCH v3 net-next 1/9] sunvnet: make sunvnet common code dynamically loadable To: Shannon Nelson , netdev@vger.kernel.org, davem@davemloft.net References: <1486748305-240339-1-git-send-email-shannon.nelson@oracle.com> <1486748305-240339-2-git-send-email-shannon.nelson@oracle.com> Cc: sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org From: Sergei Shtylyov Message-ID: Date: Sun, 12 Feb 2017 14:16:02 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <1486748305-240339-2-git-send-email-shannon.nelson@oracle.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello! On 2/10/2017 8:38 PM, Shannon Nelson wrote: > When the sunvnet_common code was split out for use by both sunvnet > and the newer ldmvsw, it was made into a static kernel library, which > limits the usefulness of sunvnet and ldmvsw as loadables, since most > of the real work is being done in the shared code. Also, this is > simply dead code in kernels that aren't running the LDoms. > > This patch makes the sunvnet_common into a dynamically loadable > module and makes sunvnet and ldmvsw dependent on sunvnet_common. > > Signed-off-by: Shannon Nelson > --- > drivers/net/ethernet/sun/Kconfig | 8 ++++++-- > drivers/net/ethernet/sun/sunvnet_common.c | 5 +++++ > 2 files changed, 11 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/sun/Kconfig b/drivers/net/ethernet/sun/Kconfig > index a4b40e3..a7d91da 100644 > --- a/drivers/net/ethernet/sun/Kconfig > +++ b/drivers/net/ethernet/sun/Kconfig > @@ -70,19 +70,23 @@ config CASSINI > . > > config SUNVNET_COMMON > - bool > + tristate "Common routines to support Sun Virtual Networking" > depends on SUN_LDOMS > - default y if SUN_LDOMS > + default m if SUN_LDOMS Sounds tautological... maybe just "default m"? [...] MBR, Sergei