From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B6F9EB64DA for ; Sat, 24 Jun 2023 13:26:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232993AbjFXN0y (ORCPT ); Sat, 24 Jun 2023 09:26:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229452AbjFXN0v (ORCPT ); Sat, 24 Jun 2023 09:26:51 -0400 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B6ADDD; Sat, 24 Jun 2023 06:26:45 -0700 (PDT) Received: by mail-pj1-x1034.google.com with SMTP id 98e67ed59e1d1-260a60b4421so726974a91.1; Sat, 24 Jun 2023 06:26:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687613205; x=1690205205; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=HzHR5VGsBkmKTRWsr9Fr6/IuDbgm5PM65lp5AFdyOdU=; b=j4S9zj7lUuy3sqeeDhUPOz9rwvMJbGSEdKnwRk/XZ+y08PrJVIgqGnCRVMjv5QysTG qw+xSrtWimmK0w+c8oUxGgA/hWWS3mddb5TfZRZZkZXCB9iy4qhZcLzmK/w1rFGHNOlD u6YXzvdMzyxYCBki+QXeLCsaSepsuUuVeoUWLvfvN2Dfxqqx0oSY8FZK/DD2zqhKZHfv RYvqwhQB7QGRxNAtgIU6NHSikcQzK9FTked9KfdwhJI/KFzaz6eCW0C1QabmKjtdXE0H kEFZFV+Sc13EU6p5oRwnRdHPaXUEyY8PcvUlBsvAgUzJqMVPy3L5lDhMq3dGib+XWXWt gQpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687613205; x=1690205205; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HzHR5VGsBkmKTRWsr9Fr6/IuDbgm5PM65lp5AFdyOdU=; b=OB0UlxkzefUV7F/ot8tpApTQM++41OnwCAEAo/a43YEKk7prIoDbez1RiOnehkHzBl Z2ic6RMv7tO36pasr8r8vlil1yZj7ho3HLJyy58GBD9IoJRx5zaWYUXqers11XW4BnkZ 2CbSLKeCPns+sil924ldagJH47ryFejHFj017u7bXcnnx+QE6ysm+PClLN8Cmjp2Tmnh bz/GpFnP1k0kxi9xHV2LM9qN7UO5yvTWfjl7N7XSFIVjdEFEaenrytCePq99AQfP1V6v /6LgRVCFm/86ftaDbunRMIYKdyMcmepw5xoz5EXUg+KvLbCzMAl5RKTA5npEdpgOlmit KTaw== X-Gm-Message-State: AC+VfDyENW7V4O8vjO8mw53+0G1yTcOKGRlmcdO/mIe/w5Nrb9IH2Ifh am7POc1SD0hm3h/jNQ/+eh0= X-Google-Smtp-Source: ACHHUZ7BC5DQswxC/X8knfo6PJ0Ce0pzV2b4lrahqjLtajzjQRmz1UcB8/ZZrwmJOMsABWyiGJPEWQ== X-Received: by 2002:a17:90b:251:b0:25b:d304:6eaf with SMTP id fz17-20020a17090b025100b0025bd3046eafmr14080091pjb.24.1687613204832; Sat, 24 Jun 2023 06:26:44 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id n189-20020a6327c6000000b0055387ffef10sm1282333pgn.24.2023.06.24.06.26.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 24 Jun 2023 06:26:44 -0700 (PDT) Sender: Guenter Roeck Message-ID: Date: Sat, 24 Jun 2023 06:26:40 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [v3,17/19] arch/sparc: Implement fb_is_primary_device() in source file Content-Language: en-US To: Arnd Bergmann , Thomas Zimmermann Cc: Daniel Vetter , Helge Deller , Javier Martinez Canillas , Greg Kroah-Hartman , Linux-Arch , linux-fbdev@vger.kernel.org, linux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org, linux-sh@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, linux-m68k@lists.linux-m68k.org, loongarch@lists.linux.dev, sparclinux@vger.kernel.org, linux-snps-arc@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, "David S . Miller" , linux-arm-kernel@lists.infradead.org References: <20230417125651.25126-18-tzimmermann@suse.de> <55130a50-d129-4336-99ce-3be4229b1c7d@app.fastmail.com> From: Guenter Roeck In-Reply-To: <55130a50-d129-4336-99ce-3be4229b1c7d@app.fastmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/24/23 02:27, Arnd Bergmann wrote: > On Sat, Jun 24, 2023, at 03:55, Guenter Roeck wrote: >> >> On Mon, Apr 17, 2023 at 02:56:49PM +0200, Thomas Zimmermann wrote: >>> Other architectures implment fb_is_primary_device() in a source >>> file. Do the same on sparc. No functional changes, but allows to >>> remove several include statement from . >>> >>> v2: >>> * don't include in header file >>> >>> Signed-off-by: Thomas Zimmermann >>> Cc: "David S. Miller" >> >> This patch results (or appears to result) in the following build error >> when trying to build sparc64:allmodconfig. >> >> Error log: >> :1519:2: warning: #warning syscall clone3 not implemented [-Wcpp] >> WARNING: modpost: drivers/cpufreq/sparc-us2e-cpufreq: section mismatch >> in reference: cpufreq_us2e_driver+0x20 (section: .data) -> >> us2e_freq_cpu_init (section: .init.text) >> WARNING: modpost: drivers/cpufreq/sparc-us3-cpufreq: section mismatch >> in reference: cpufreq_us3_driver+0x20 (section: .data) -> >> us3_freq_cpu_init (section: .init.text) >> ERROR: modpost: "__xchg_called_with_bad_pointer" [lib/atomic64_test.ko] >> undefined! > > These all look like old bugs that would be trivially fixed if > anyone cared about sparc. > Odd argument, given that this _is_ a sparc patch. Those may be old bugs, but at least in 6.4-rc7 sparc64:allmodconfig does at least compile. Sure, I can stop build testing it if that is where things are going. Guenter >> ERROR: modpost: missing MODULE_LICENSE() in arch/sparc/video/fbdev.o > > I checked that there are no callers of fb_is_primary_device() > in built-in code when CONFIG_FB is =m, so adding the MODULE_LICENSE() > and MODULE_DESCRIPTION() tags to the file is the correct fix. > > Arnd