From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81C6EEEB59F for ; Fri, 15 Sep 2023 06:47:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232419AbjIOGrk (ORCPT ); Fri, 15 Sep 2023 02:47:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43052 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232396AbjIOGrh (ORCPT ); Fri, 15 Sep 2023 02:47:37 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A02152708; Thu, 14 Sep 2023 23:47:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1694760449; x=1726296449; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=nbiNTtCye3B4MOA9keAnL3jGRC3Z0ZFqO6c5ckMzgn4=; b=DezGOKHC77KnfZ4+W70StJamxTSX9G4/vDZdgQgNkmJIk7xKsOuLSTYd cgKsiTGD3QE09NWsL3cAWG68GTXvv5fq9AgKzzppeQsXlM1SBDVSfJ5Ch SXC+NRFKy6ldk/xVL2WSxP5xFTRdU7YFuayf9MdfOczejFnrkfqQ9yh4B m6+tMlP58l9OELQLiwb7Ee67casNkwmXlg5kz4Tv078X15bd29OlPsYaY MoM4ado6curPC/YXYlQ6SdpMhVQN68HcqUQPjP4fWdk/UPHfhRZEHjKH9 odvwn9MhuZaDV50NsLT/fHnCzQvtjmWAppnb8ilkwCCgVcrvbbBjtMdIH A==; X-IronPort-AV: E=McAfee;i="6600,9927,10833"; a="383000904" X-IronPort-AV: E=Sophos;i="6.02,148,1688454000"; d="scan'208";a="383000904" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2023 23:47:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10833"; a="744857575" X-IronPort-AV: E=Sophos;i="6.02,148,1688454000"; d="scan'208";a="744857575" Received: from xiaoyaol-hp-g830.ccr.corp.intel.com (HELO [10.93.29.154]) ([10.93.29.154]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2023 23:47:16 -0700 Message-ID: Date: Fri, 15 Sep 2023 14:47:13 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.15.1 Subject: Re: [RFC PATCH v12 01/33] KVM: Tweak kvm_hva_range and hva_handler_t to allow reusing for gfn ranges Content-Language: en-US To: Sean Christopherson , Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , "Matthew Wilcox (Oracle)" , Andrew Morton , Paul Moore , James Morris , "Serge E. Hallyn" Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Chao Peng , Fuad Tabba , Jarkko Sakkinen , Anish Moorthy , Yu Zhang , Isaku Yamahata , Xu Yilun , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" References: <20230914015531.1419405-1-seanjc@google.com> <20230914015531.1419405-2-seanjc@google.com> From: Xiaoyao Li In-Reply-To: <20230914015531.1419405-2-seanjc@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/14/2023 9:54 AM, Sean Christopherson wrote: > Rework and rename "struct kvm_hva_range" into "kvm_mmu_notifier_range" so > that the structure can be used to handle notifications that operate on gfn > context, i.e. that aren't tied to a host virtual address. > > Practically speaking, this is a nop for 64-bit kernels as the only > meaningful change is to store start+end as u64s instead of unsigned longs. > > Reviewed-by: Paolo Bonzini > Signed-off-by: Sean Christopherson > --- > virt/kvm/kvm_main.c | 34 +++++++++++++++++++--------------- > 1 file changed, 19 insertions(+), 15 deletions(-) > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index 486800a7024b..0524933856d4 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -541,18 +541,22 @@ static inline struct kvm *mmu_notifier_to_kvm(struct mmu_notifier *mn) > return container_of(mn, struct kvm, mmu_notifier); > } > > -typedef bool (*hva_handler_t)(struct kvm *kvm, struct kvm_gfn_range *range); > +typedef bool (*gfn_handler_t)(struct kvm *kvm, struct kvm_gfn_range *range); Is it worth mentioning the rename of it as well in changelog? Anyway, Reviewed-by: Xiaoyao Li