mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: "André Almeida" <andrealmeid@igalia.com>,
	"ZhuangZhuang Wang" <wzz_123123@163.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Shuah Khan <shuah@kernel.org>,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] selftests: kselftest: Fix debug message formatting
Date: Sat, 26 Sep 2026 13:27:51 -0600	[thread overview]
Message-ID: <d41f6f1b-b317-404d-b1f9-ed6f4170fa26@linuxfoundation.org> (raw)
In-Reply-To: <dfb3afb2-cec0-42e0-8e5d-25e89f54215b@igalia.com>

On 9/22/26 14:06, André Almeida wrote:
> Em 16/09/2026 16:04, ZhuangZhuang Wang escreveu:
>> ksft_print_dbg_msg() passes a va_list to ksft_print_msg() as a regular
>> variadic argument. As a result, format specifiers consume the va_list
>> representation instead of the caller's arguments and print garbage.
>>
>> Add a va_list-based helper and use it from both message printing
>> functions. Also annotate ksft_print_dbg_msg() so the compiler can check
>> its format arguments.
>>
>> Fixes: f2662ec26b26 ("selftests: kselftest: Create ksft_print_dbg_msg()")

Does it really fix this commit? I don't see that is the case. Please don't
add fixes tag unless it fixes the problem in the commit.

>> Signed-off-by: ZhuangZhuang Wang <wzz_123123@163.com>
> 
> Reviewed-by: André Almeida <andrealmeid@igalia.com>

Also can you tell me how this problem was found and what;s the output
before and after this change?

thanks,
-- Shuah

      reply	other threads:[~2026-09-26 19:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-16 19:04 ZhuangZhuang Wang
2026-09-22 20:06 ` André Almeida
2026-09-26 19:27   ` Shuah Khan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d41f6f1b-b317-404d-b1f9-ed6f4170fa26@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=andrealmeid@igalia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=wzz_123123@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®