From: "Mark Pearson" <mpearson-lenovo@squebb.ca>
To: "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>
Cc: "Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
ikepanhc@gmail.com, "Armin Wolf" <W_Armin@gmx.de>,
linux-kernel@vger.kernel.org,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
ibm-acpi-devel@lists.sourceforge.net
Subject: Re: [PATCH 2/2] platform/x86: export thinkpad_acpi handles
Date: Thu, 08 May 2025 11:01:50 -0400 [thread overview]
Message-ID: <d423ac66-bb8f-44e4-b995-f88cf2ece70c@app.fastmail.com> (raw)
In-Reply-To: <aBzAWrgEgmnAnum-@smile.fi.intel.com>
On Thu, May 8, 2025, at 10:31 AM, Andy Shevchenko wrote:
> On Wed, May 07, 2025 at 03:04:35PM -0400, Mark Pearson wrote:
>> Add API to be able to get the thinkpad_acpi various handles.
>>
>> Will use this to start pulling some of the thinkpad_acpi functionality
>> into separate modules in the future.
>
> ...
>
>> +#ifndef _TP_ACPI_H_
>> +#define _TP_ACPI_H_
>
> + include for acpi_handle typedef.
> Or it the forward declaration works
>
> acpi_handle;
>
> but I haven't checked and my gut feelings that it's not correct syntax as
> compiler doesn't know what the heck this word means.
>
OK - I'll have a look and figure out what makes sense.
Thanks for the review
Mark
next prev parent reply other threads:[~2025-05-08 15:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-07 19:04 [PATCH 1/2] platform/x86: Move Lenovo files into lenovo subdir Mark Pearson
2025-05-07 19:04 ` [PATCH 2/2] platform/x86: export thinkpad_acpi handles Mark Pearson
2025-05-08 14:03 ` Ilpo Järvinen
2025-05-08 14:28 ` Mark Pearson
2025-05-08 14:32 ` Andy Shevchenko
2025-05-08 15:02 ` Mark Pearson
2025-05-08 14:31 ` Andy Shevchenko
2025-05-08 15:01 ` Mark Pearson [this message]
2025-05-08 14:01 ` [PATCH 1/2] platform/x86: Move Lenovo files into lenovo subdir Ilpo Järvinen
2025-05-08 14:23 ` Mark Pearson
2025-05-08 14:27 ` Ilpo Järvinen
2025-05-08 14:29 ` Mark Pearson
2025-05-08 14:29 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d423ac66-bb8f-44e4-b995-f88cf2ece70c@app.fastmail.com \
--to=mpearson-lenovo@squebb.ca \
--cc=W_Armin@gmx.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=ikepanhc@gmail.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®