From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1E73C2BA2B for ; Sat, 11 Apr 2020 15:48:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 818FF20757 for ; Sat, 11 Apr 2020 15:48:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726669AbgDKPs4 (ORCPT ); Sat, 11 Apr 2020 11:48:56 -0400 Received: from smtprelay0102.hostedemail.com ([216.40.44.102]:57636 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726054AbgDKPsz (ORCPT ); Sat, 11 Apr 2020 11:48:55 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay08.hostedemail.com (Postfix) with ESMTP id 4DFFD182CCCD0; Sat, 11 Apr 2020 15:48:55 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: cub63_13801b5604b35 X-Filterd-Recvd-Size: 1639 Received: from XPS-9350.home (unknown [47.151.136.130]) (Authenticated sender: joe@perches.com) by omf18.hostedemail.com (Postfix) with ESMTPA; Sat, 11 Apr 2020 15:48:53 +0000 (UTC) Message-ID: Subject: Re: [PATCH] usb: phy: jz4770: Add a missing '\n' in a log message From: Joe Perches To: Paul Cercueil , Christophe JAILLET Cc: balbi@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Date: Sat, 11 Apr 2020 08:46:49 -0700 In-Reply-To: References: <20200411063811.6767-1-christophe.jaillet@wanadoo.fr> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2020-04-11 at 15:13 +0200, Paul Cercueil wrote: > Hi Christophe, > > Le sam. 11 avril 2020 à 8:38, Christophe JAILLET > a écrit : > > Message logged by 'dev_xxx()' or 'pr_xxx()' should end with a '\n'. > > Is that so? > From what I could see these macros add the \n themselves if needed. Not so. > So the \n were omitted on purpose. Just a trivial oversight really. AFAIK: It's an issue _only_ in two cases: p another process emits a printk with KERN_CONT (or pr_cont) that might extend this message in the log on the same line. o this message wukk not be emitted into the log until another message arrives