From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751823AbdJRPnq (ORCPT <rfc822;w@1wt.eu>);
        Wed, 18 Oct 2017 11:43:46 -0400
Received: from mout.web.de ([217.72.192.78]:49445 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750914AbdJRPnn (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 18 Oct 2017 11:43:43 -0400
Subject: Re: char-TPM: Adjustments for ten function implementations
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
        linux-integrity@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Corentin Labbe <clabbe.montjoie@gmail.com>,
        Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
        Jerry Snitselaar <jsnitsel@redhat.com>,
        Kenneth Goldman <kgold@linux.vnet.ibm.com>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Nayna Jain <nayna@linux.vnet.ibm.com>,
        Paul Mackerras <paulus@samba.org>,
        =?UTF-8?Q?Peter_H=c3=bcwe?= <PeterHuewe@gmx.de>,
        Stefan Berger <stefanb@linux.vnet.ibm.com>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
References: <1d3516a2-a8e6-9e95-d438-f115fac84c7f@users.sourceforge.net>
 <20171016183139.otyh3m5c5yurtmow@linux.intel.com>
 <20171016183512.3bz6x4b6lbhpbkje@linux.intel.com>
 <2e5e24b4-ea4d-e43b-22b2-e6b65e7203d2@users.sourceforge.net>
 <20171018150436.j2uhzxsu4ebjoz3c@linux.intel.com>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <d429115f-a54f-4307-0ee1-31058041b721@users.sourceforge.net>
Date: Wed, 18 Oct 2017 17:43:17 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171018150436.j2uhzxsu4ebjoz3c@linux.intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 8bit
X-Provags-ID: V03:K0:DkpLH3MmIYJK+s2YbVlTnxFfsWnhyyIF9kd4S3PLhvCGNCn5Wvb
 HQGcEcIy4tDAOis786q3ZwztQyuhxItxC+W3qTTD8NXGfiiqCCXqZ8OfXz8V460YBgVDrdS
 pus/I3H5TkJIXMmUr8Df71E4heBOehjrUOvYm8vWStTa6tNK2rBL1O8DEV58pKOkkpIkPzZ
 XFwuzWuFjNEOFLzoqvxOw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:vCf3a2byUR4=:mUKZUoYBRrYoqMnxxerwjY
 QDrjmlSJjh6CElqWcHm81fTuo4G2ueOBsGMuZfw8ezU6sMYO+dW41jKtFjzyBzgCP1tQeAmWM
 ZDVJA2RxJrEkWUr3dR7iZzr2btiUtM9Z9pFg2gnfIDExTRHr57wUFroxgDrBp+FAAfCBz9mkz
 cBNXCGi3wYTbQgXFb8+AEX6uvwNT6C3KGv2qr9g5UyU9PI+0meIUAMZdS1dZhul/VbziNElr0
 bdTyCq+VCwE7a41UEizBg1L5qkQL1N3v9VqPaPMJWwfVDnVGsRSx9PUrcvN75s6BjBif4s1wd
 kD8fCOIv1tgHF+qthP/ipjI62WYPu2LQoRmh7X4FNIG2+HjmnTAuFA+T6xePL67r7Y13j90e0
 62Q8WDJgKJnCzhqg9sgqvbzrV+ae/Nzftpx0ho/skAtM5Fbto8HNhCIO2zIjnyxjZc9c3H5Dr
 h6IeKemhnSZUy9qG7YymRiKBBwZV6cYsXI7uALzhMxcuYgL08pDYlGYgNGI9+bnqhAckzmFq7
 eXE+AsH7U6r7Omj+cv5ysNlynAzEO3ys0eMCLNo5YOoCuUDmTdQyaH5oWn8bNQlXYlDYzty/0
 hjd2PICkg0No1d++4sAdvRPxfK3kQT0wXlkJYd8dGZfJP1uHmDwP1Ay5KSPUgA7bm77sBHKC/
 J5R7TYUHB74NJCsRNraIua3vJuVy8W9Z1vB21L/GdsBlvpBGYNsBwUGA2BlkgM1LRZU2PmsRJ
 leg1SqgyJ61IW3KKkjnqPfBWf7ke5XHXZYMcQCbHBOjDnxG9g3/ROry6FxvIczi1FwaQnokiQ
 CSoV0VnFSX1lqlJiRDjDU3M3YENcgre9/IpuLhQhxPCDDQjBro=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>>> A minor complaint: all commits are missing "Fixes:" tag.
>>
>> * Do you require it to be added to the commit messages?
> 
> I don't require it. It's part of the development process:
> 
> https://www.kernel.org/doc/html/v4.12/process/submitting-patches.html

Yes. - But other contributors pointed the detail out again
that not every change is qualified for using this tag.


>> * Would you like to get a finer patch granularity then?
> 
> I don't understand what you are asking.

If you would insist on the addition of this tag to all my commits
for the discussed patch series, I imagine that I would need to split
the update step “Improve a size determination in nine functions”
into smaller parts.


>> * Do you find any more information missing?
> 
> I think I already answered to this in my earlier responses
> (commit messages).

Partly.


> I probably won't take "sizeof(*foo)" type of change even if it
> is a recommended style if that is the only useful thing that the
> commit does.

How much do you care for the section “14) Allocating memory”
in the document “coding-style.rst” then?

Regards,
Markus