From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755725AbdJJAkB (ORCPT ); Mon, 9 Oct 2017 20:40:01 -0400 Received: from esa5.microchip.iphmx.com ([216.71.150.166]:30077 "EHLO esa5.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754280AbdJJAkA (ORCPT ); Mon, 9 Oct 2017 20:40:00 -0400 X-IronPort-AV: E=Sophos;i="5.42,502,1500966000"; d="scan'208";a="5424812" Subject: Re: [PATCH 09/15] ARM: dts: at91: sama5d2_xplained: Add charger node of pmic. To: Claudiu Beznea , , , , , CC: , , , Wenyou Yang References: <1507565377-1545-1-git-send-email-claudiu.beznea@microchip.com> <1507565377-1545-10-git-send-email-claudiu.beznea@microchip.com> From: "Yang, Wenyou" Message-ID: Date: Tue, 10 Oct 2017 08:39:48 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1507565377-1545-10-git-send-email-claudiu.beznea@microchip.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Claudiu, On 2017/10/10 0:09, Claudiu Beznea wrote: > Add charger device node as a sub-device node of act8945a mfd, move > the charger's properties to this node, and use the "interrupts" > property to replace "active-semi,irq_gpios" to denote the act8945a > charger's irq. > > Signed-off-by: Wenyou Yang > [claudiu.beznea@microchip.com: replace numbers with pin macros] > Signed-off-by: Claudiu Beznea This patch has already applied on at91-dt branch. https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git/commit/?h=at91-dt&id=4b6ad41f267b8ddabf5dd1b02a318bc74f0b95e9 > --- > arch/arm/boot/dts/at91-sama5d2_xplained.dts | 23 +++++++++++++++-------- > 1 file changed, 15 insertions(+), 8 deletions(-) > > diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dts/at91-sama5d2_xplained.dts > index c7e9ccf2bc87..848ca1b025be 100644 > --- a/arch/arm/boot/dts/at91-sama5d2_xplained.dts > +++ b/arch/arm/boot/dts/at91-sama5d2_xplained.dts > @@ -160,14 +160,6 @@ > compatible = "active-semi,act8945a"; > reg = <0x5b>; > active-semi,vsel-high; > - active-semi,chglev-gpios = <&pioA PIN_PA12 GPIO_ACTIVE_HIGH>; > - active-semi,lbo-gpios = <&pioA PIN_PC8 GPIO_ACTIVE_LOW>; > - active-semi,irq_gpios = <&pioA PIN_PB13 GPIO_ACTIVE_LOW>; > - active-semi,input-voltage-threshold-microvolt = <6600>; > - active-semi,precondition-timeout = <40>; > - active-semi,total-timeout = <3>; > - pinctrl-names = "default"; > - pinctrl-0 = <&pinctrl_charger_chglev &pinctrl_charger_lbo &pinctrl_charger_irq>; > status = "okay"; > > regulators { > @@ -220,6 +212,21 @@ > regulator-always-on; > }; > }; > + > + charger { > + compatible = "active-semi,act8945a-charger"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_charger_chglev &pinctrl_charger_lbo &pinctrl_charger_irq>; > + interrupt-parent = <&pioA>; > + interrupts = ; > + > + active-semi,chglev-gpios = <&pioA PIN_PA12 GPIO_ACTIVE_HIGH>; > + active-semi,lbo-gpios = <&pioA PIN_PC8 GPIO_ACTIVE_LOW>; > + active-semi,input-voltage-threshold-microvolt = <6600>; > + active-semi,precondition-timeout = <40>; > + active-semi,total-timeout = <3>; > + status = "okay"; > + }; > }; > }; > Best Regards, Wenyou Yang