From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED2A837C0E7 for ; Wed, 8 Jul 2026 13:32:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783517572; cv=none; b=Fim3xsePGU7CPr4IlXqUfCZ6nPh11IMEUV6mZYu4hmxjYF2cCH9UwCG342Fku7KpfYLCtHxBwKYgJ10M484UAk+iB4qH35oEM/qTNp8epPuqRdUBr1RGxt/9l9ZOAb34UZ7382VL8rTKKiiwM2ifBYJl+8y50tbafH9h/w0MrIU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783517572; c=relaxed/simple; bh=TBQnnf1ISW62j4RHZSvYvNLSTDQ9QzUk7AAeKMrk3ZM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=A9CVT0n/6/DvGSoIHaSSHM+6zXjUbA1pT86erCx1aNI63t/vVGyCXKDSThU0BjphMtm7W55rDfoRljSuq9HiEeG9M1ETBwCfpm/VuhyWlzvzmIINNdDS3K6ldsbYySLUJZ21wnylcWJBP8uzzUt+5Gdu5vfXSauaMfpKmX8h5RQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=itYhycSw; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=XKZAolcw; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="itYhycSw"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="XKZAolcw" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783517567; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d6QdbQflS+GfJz88gA8xHxJyZ3hxbQBYcalujojmxh0=; b=itYhycSwcJzN81XYD7KNzKlbBgVj61gcoLgsunKJcfmKZdLktgeHWuXKROpTqcNHjoXDmM WeBmRp6ZkOUXFNyHq2I6CfhO3vHwy8k7z51w+CsBcAy9FAzkk/oihgNLyU18Ux6y5kOaGQ EYQ4CuWj/52xhwPQrUcYdkvXHHR0etE= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-607-9gIN07naM9K6PfHFfBAPLw-1; Wed, 08 Jul 2026 09:32:44 -0400 X-MC-Unique: 9gIN07naM9K6PfHFfBAPLw-1 X-Mimecast-MFC-AGG-ID: 9gIN07naM9K6PfHFfBAPLw_1783517563 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-92e53b8a302so76196785a.1 for ; Wed, 08 Jul 2026 06:32:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1783517563; x=1784122363; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=d6QdbQflS+GfJz88gA8xHxJyZ3hxbQBYcalujojmxh0=; b=XKZAolcw5ErbQbwpF6UKOiN0HNqCoVzDuKrGMaTezgEbNMntK8YGp/2apCjnodGbpp 9nFOmca5h8zmL+7k0O4AD1hSJhhWyjCAIzvwTKa1kjZ/YrQDP7tWBKQlNWM6mlBcGD/a D8zt0LnIw7pEB4LjuTVfQkt8r8mTWnu610Q5Zpu1rWKbxC5DCTZ4eWbt4M+UcMoKg1iI NuhUEUjQ8NlyBRnFoWjMqTLP75qwxWjV1aIicMmUAkFFJauZoNuOfZhtiPejx73AxlPR TSp+FzXxMKcb/jKx+A4qpLiWnh+Hx6gsUbggotBEZsUqxywLK0XPlWkzv8h5WGTiw+rI bbaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783517563; x=1784122363; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=d6QdbQflS+GfJz88gA8xHxJyZ3hxbQBYcalujojmxh0=; b=KzAYNQJobUAQz7orUxfk5C+bw5TpvhfrQ0yjkJzXePfvG+/73EAROclBW95EbUoTZW QLq4SjRQC4hVWq9bfiBot+op0p1D5MRLIi9Olk4Dt8zqCqU7LFVZ6lr2hBU0n6imSy/R N5q7h5d/Cw9pdw2hvS6Zd+2muJVfu1ZzDxG+TO7mS1e/70n+VDCYrYFPGee9fS1Y+N4N FpfC5UaUZnbFVOzNR/l3NACsRV/GEP34Xg/NbneS33SVWHVxxDj/+dhN9k64kGvYqa25 H/2e7wI/MrmONyWbfw4OTUqytgTNLfqT8QK+LJE4uyPttY6KTMMoS9w5GgOL+3xXBPyJ N9LA== X-Gm-Message-State: AOJu0YwNatCtgT2RVukVVefL9ab9ky+s9FBGGFKO6BofqWel/7bygcVM PZqXZEnJNNsNxr9E63jCwJk2eiiuSu+z0VRbmtHVkj5fWfuo5/PchBTiuuB8iTXUYV4ePPwFdV7 AJtV+5MCDoBGJBlIgHSADQ43GY7yS8n9tkk672cL6OM6ptTF4kIgSYLl6ItgTozl0KQ== X-Gm-Gg: AfdE7cksEYVKGqwvSEbWClQ4F+GlyTCaA563lbG+OnaVhxtTBuZLrUPKc01mNeKr3uW WybgUeICgMByL2XOILthmGtMSrqo26RIHmsuX29OyBcNxq1QdDW/xKO99GFiWXUb2qhCA+S9+PM A09+GqXX65vWKGNFdpY7tK1boZ+lCnFYPqgWQe0z74lZF8944xu4KkqkZqhIvYipdaZXdKRb3DM K5Z75/rNwFGsgGJWZluGvvnq/GhHVcQUfGdNWVgfDd/5fG+BmFC3Ci02VWLWwzPuAmf0OnUPoFq 6eafLmuJHjLqdpyFT25ZCJldxg9g7DnQ+LQR4fKpLnUz7xY9vNaHBujYlDS5cT/4PHyUdaBV5/d 9KWNsXDeCpw== X-Received: by 2002:a05:620a:46ac:b0:92e:c197:e9f5 with SMTP id af79cd13be357-92ecf92af35mr203842985a.77.1783517563386; Wed, 08 Jul 2026 06:32:43 -0700 (PDT) X-Received: by 2002:a05:620a:46ac:b0:92e:c197:e9f5 with SMTP id af79cd13be357-92ecf92af35mr203839485a.77.1783517562934; Wed, 08 Jul 2026 06:32:42 -0700 (PDT) Received: from [192.168.8.207] ([45.81.3.233]) by smtp.gmail.com with ESMTPSA id af79cd13be357-92e90ba7e62sm1430433785a.13.2026.07.08.06.32.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jul 2026 06:32:42 -0700 (PDT) Message-ID: Date: Wed, 8 Jul 2026 07:34:17 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] bug: fix warning suppressions with kunit built as module To: Bartosz Golaszewski , Shuah Khan , Guenter Roeck , Albert Esteve , Kees Cook , Alessandro Carminati , Andrew Morton , Brendan Higgins , David Gow , Rae Moar Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, brgl@kernel.org, stable@vger.kernel.org References: <20260707125837.57256-1-bartosz.golaszewski@oss.qualcomm.com> From: Nico Pache Content-Language: en-US In-Reply-To: <20260707125837.57256-1-bartosz.golaszewski@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/7/26 6:58 AM, Bartosz Golaszewski wrote: > CONFIG_KUNIT is a tristate symbol but the warning suppression code in > lib/bug.c is only built if it's built-in. Use IS_ENABLE(CONFIG_KUNIT) to > enable it for a loadable kunit module as well. When using a plain #ifdef, > the suppressions only work if kunit is built-in. > > Cc: stable@vger.kernel.org > Fixes: 85347718ab0d ("bug/kunit: Core support for suppressing warning backtraces") > Signed-off-by: Bartosz Golaszewski I ran into the same issue and found the following fix also resolved the issue. Tested-by: Nico Pache Acked-by: Nico Pache > --- > lib/bug.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/bug.c b/lib/bug.c > index 292420f45811..b9820a0226f5 100644 > --- a/lib/bug.c > +++ b/lib/bug.c > @@ -219,7 +219,7 @@ static enum bug_trap_type __report_bug(struct bug_entry *bug, unsigned long buga > no_cut = bug->flags & BUGFLAG_NO_CUT_HERE; > has_args = bug->flags & BUGFLAG_ARGS; > > -#ifdef CONFIG_KUNIT > +#if IS_ENABLED(CONFIG_KUNIT) > /* > * Before the once logic so suppressed warnings do not consume > * the single-fire budget of WARN_ON_ONCE().