Re:[PATCH] Add rev and func to warning message when acpi_evaluate_dsm failed.

["David Wang" <00107082@163.com>]

I made a mistake about the patch title, please ignore this and I will send another one.

David

At 2024-08-26 12:38:58, "David Wang" <00107082@163.com> wrote:
>When acpi_evaluate_dsm failed, the warning message lacks the rev
>and func information which is available and helpful. For example,
>iwlwifi would make DSM queries for lari config, and with some HW,
>DSM error would return:
>	ACPI: \: failed to evaluate _DSM bf0212f2-788f-c64d-a5b3-1f738e285ade (0x1001)
>	ACPI: \: failed to evaluate _DSM bf0212f2-788f-c64d-a5b3-1f738e285ade (0x1001)
>	ACPI: \: failed to evaluate _DSM bf0212f2-788f-c64d-a5b3-1f738e285ade (0x1001)
>	ACPI: \: failed to evaluate _DSM bf0212f2-788f-c64d-a5b3-1f738e285ade (0x1001)
>	ACPI: \: failed to evaluate _DSM bf0212f2-788f-c64d-a5b3-1f738e285ade (0x1001)
>	ACPI: \: failed to evaluate _DSM bf0212f2-788f-c64d-a5b3-1f738e285ade (0x1001)
>	ACPI: \: failed to evaluate _DSM bf0212f2-788f-c64d-a5b3-1f738e285ade (0x1001)
>	ACPI: \: failed to evaluate _DSM bf0212f2-788f-c64d-a5b3-1f738e285ade (0x1001)
>With this patch, the warning would be more informative:
>	ACPI: \: failed to evaluate _DSM bf0212f2-788f-c64d-a5b3-1f738e285ade rev:0 func:1 (0x1001)
>	ACPI: \: failed to evaluate _DSM bf0212f2-788f-c64d-a5b3-1f738e285ade rev:0 func:6 (0x1001)
>	ACPI: \: failed to evaluate _DSM bf0212f2-788f-c64d-a5b3-1f738e285ade rev:0 func:7 (0x1001)
>	ACPI: \: failed to evaluate _DSM bf0212f2-788f-c64d-a5b3-1f738e285ade rev:0 func:8 (0x1001)
>	ACPI: \: failed to evaluate _DSM bf0212f2-788f-c64d-a5b3-1f738e285ade rev:0 func:3 (0x1001)
>	ACPI: \: failed to evaluate _DSM bf0212f2-788f-c64d-a5b3-1f738e285ade rev:0 func:9 (0x1001)
>	ACPI: \: failed to evaluate _DSM bf0212f2-788f-c64d-a5b3-1f738e285ade rev:0 func:10 (0x1001)
>	ACPI: \: failed to evaluate _DSM bf0212f2-788f-c64d-a5b3-1f738e285ade rev:0 func:12 (0x1001)
>
>Signed-off-by: David Wang <00107082@163.com>
>---
> drivers/acpi/utils.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/acpi/utils.c b/drivers/acpi/utils.c
>index ae9384282273..6de542d99518 100644
>--- a/drivers/acpi/utils.c
>+++ b/drivers/acpi/utils.c
>@@ -801,7 +801,8 @@ acpi_evaluate_dsm(acpi_handle handle, const guid_t *guid, u64 rev, u64 func,
> 
> 	if (ret != AE_NOT_FOUND)
> 		acpi_handle_warn(handle,
>-				 "failed to evaluate _DSM %pUb (0x%x)\n", guid, ret);
>+				 "failed to evaluate _DSM %pUb rev:%lld func:%lld (0x%x)\n",
>+				 guid, rev, func, ret);
> 
> 	return NULL;
> }
>-- 
>2.39.2