From: Justin Chen <justin.chen@broadcom.com>
To: Myeonghun Pak <mhun512@gmail.com>,
Al Cooper <alcooperx@gmail.com>, Vinod Koul <vkoul@kernel.org>
Cc: Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Manivannan Sadhasivam <mani@kernel.org>,
linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org,
Ijae Kim <ae878000@gmail.com>
Subject: Re: [PATCH] phy: broadcom: brcm-usb: unwind clocks on probe failure
Date: Mon, 14 Sep 2026 12:33:25 -0700 [thread overview]
Message-ID: <d43cfb62-f048-42c8-909b-79a0300790df@broadcom.com> (raw)
In-Reply-To: <20260913012956.16443-1-mhun512@gmail.com>
On 9/12/26 6:29 PM, Myeonghun Pak wrote:
> brcm_usb_phy_dvr_init() enables the optional USB2 and USB3 clocks before
> creating all PHYs and acquiring the remaining probe resources. Several
> later failures return without disabling clocks that were already enabled,
> and deferred probe retries can keep increasing their enable counts.
>
> Track each successful clock enable and unwind only those clocks, in reverse
> order, when initialization fails. Keep the existing successful probe path
> unchanged. This is limited to the BCM4908 and Broadcom STB USB PHY driver.
>
> This issue was identified during our ongoing static-analysis research while
> reviewing kernel code.
>
> Fixes: 49859e55e364 ("phy: usb: phy-brcm-usb: Add Broadcom STB USB phy driver")
> Assisted-by: OpenAI:GPT-5.6
> Co-developed-by: Ijae Kim <ae878000@gmail.com>
> Signed-off-by: Ijae Kim <ae878000@gmail.com>
> Signed-off-by: Myeonghun Pak <mhun512@gmail.com>
Reviewed-by: Justin Chen <justin.chen@broadcom.com>
prev parent reply other threads:[~2026-09-14 19:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-13 1:29 Myeonghun Pak
2026-09-14 19:33 ` Justin Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d43cfb62-f048-42c8-909b-79a0300790df@broadcom.com \
--to=justin.chen@broadcom.com \
--cc=ae878000@gmail.com \
--cc=alcooperx@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=mani@kernel.org \
--cc=mhun512@gmail.com \
--cc=neil.armstrong@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®