From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08788EE49A8 for ; Sat, 19 Aug 2023 14:56:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233718AbjHSO40 (ORCPT ); Sat, 19 Aug 2023 10:56:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233640AbjHSO4Z (ORCPT ); Sat, 19 Aug 2023 10:56:25 -0400 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95C3227D12 for ; Sat, 19 Aug 2023 07:56:23 -0700 (PDT) Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-31969580797so1661627f8f.3 for ; Sat, 19 Aug 2023 07:56:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692456982; x=1693061782; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=MxRSmeCuLOS6YzS9MfIa//5eeOBZqb48nHjyrxA8WzI=; b=En6nC4fqO+PskFjOAQuLEZB9JXv0/OMn1PDfdnvvOE8BGR65hcqMco+8e5bNKer2Z4 l+VQHp612JIYRx44HxZg9UxVP7d+t1xLjkG6sVxwi3C4cr2corh3a7zzGDVLB85MwcvV bYzrOCOSW2ZGgx+E27VM6eEy4tqrO/SSkRvpJmu35+TcME7fZuMyKmmRTVHc7t+VLXNc 4HrQK6npihtpaLB7Tgg4G+h+2EP37aAjL8m3Turw0P8Km4FJouX6jopr2kpBYYcYmxA/ YyS59fWkV0gP9ZcMfqsqVkRSnEP64r8KF2qsoP8jwbM7ypH5sPVFv6ee5DPWlwohbWoz QdYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692456982; x=1693061782; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MxRSmeCuLOS6YzS9MfIa//5eeOBZqb48nHjyrxA8WzI=; b=jBAwRNXqHkZ5W0MFC0NBJGw/N9xaM6k86YBf6ypwJe+2AGY71j9sVaGL+mdl73pZs6 zMDLb33kcuuOT1mqPtr6/6WmnfrEKVvs/SOVRPXWMWb3o6NUTWlOQyFHCh8adIF0YlO7 Go7PL+2LRVZPaPMdz8nYQZvDsOcKy5+o8dLFsSUIrbpMIUcSmr1x0U9prooHV2Sp77go TxQmhN8uqrLPgIj/mCvls9TOP2qL3uz8BPiLwhofAYwO2K20k7klqParKg5d4baiB0Ia JyY3s6Wy1kSCOUK+us/wzsF4/Yq+fWEqXgTHQkNgCUtgeQ1C1PlOZrfWS9Uu60s/IDxF 3tig== X-Gm-Message-State: AOJu0Yx84QN1Ao9vVdSzjCHCclBS2+zccd1UlPXYABlP7ZPnAq+UlrQp l1IE5a34R4X7S4aF7HOXOdtMqA== X-Google-Smtp-Source: AGHT+IFgpAq5xIx0P9Bwca/UOggFEiVzYoL5V61sehqVLAzYQiNhsac9R636xuw4V4Uhu/R0GjHoKA== X-Received: by 2002:adf:ef91:0:b0:318:f7a:e3c8 with SMTP id d17-20020adfef91000000b003180f7ae3c8mr1551475wro.57.1692456981957; Sat, 19 Aug 2023 07:56:21 -0700 (PDT) Received: from [192.168.0.162] (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id k12-20020adfe3cc000000b0031ad5470f89sm6485519wrm.18.2023.08.19.07.56.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 19 Aug 2023 07:56:21 -0700 (PDT) Message-ID: Date: Sat, 19 Aug 2023 15:56:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2 07/13] media: qcom: camss: Use >= CAMSS_SDM845 for vfe_get/vfe_put Content-Language: en-US To: Konrad Dybcio , rfoss@kernel.org, todor.too@gmail.com, agross@kernel.org, andersson@kernel.org, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com, andrey.konovalov@linaro.org Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230817143812.677554-1-bryan.odonoghue@linaro.org> <20230817143812.677554-8-bryan.odonoghue@linaro.org> <4d14de78-16a9-4720-9422-b684f261df01@linaro.org> From: Bryan O'Donoghue In-Reply-To: <4d14de78-16a9-4720-9422-b684f261df01@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/08/2023 13:29, Konrad Dybcio wrote: > On 18.08.2023 14:28, Konrad Dybcio wrote: >> On 17.08.2023 16:38, Bryan O'Donoghue wrote: >>> From sdm845 onwards we need to ensure the VFE is powered on prior to >>> switching on the CSID. >>> >>> Alternatively we could model up the GDSCs and clocks the CSID needs >>> without the VFE but, there's a real question of the legitimacy of such a >>> use-case. >>> >>> For now drawing a line at sdm845 and switching on the associated VFEs is >>> a perfectly valid thing to do. >>> >>> Rather than continually extend out this clause for at least two new SoCs >>> with this same model - making the vfe_get/vfe_put path start to look >>> like spaghetti we can simply test for >= sdm845 here. >>> >>> Signed-off-by: Bryan O'Donoghue >>> --- >> Using >= here is veeery arbitrary and depends on the next person >> adding a SoC in chronological, or used-tech-chronological order >> correctly.. Not a fan! > > Perhaps some sort of a compatible-bound flag would be better suited > > Konrad I take the point. I'll look at a macro or a helper function if (csid_within_vfe(version)) {} That way there's just one source of truth and the chronology is irrelevant. --- bod