From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C313CC433F5 for ; Wed, 22 Sep 2021 06:38:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9EE9B60EC0 for ; Wed, 22 Sep 2021 06:38:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232808AbhIVGjv (ORCPT ); Wed, 22 Sep 2021 02:39:51 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:51194 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232718AbhIVGjt (ORCPT ); Wed, 22 Sep 2021 02:39:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632292700; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z3XTCa1nu8hCtlYTFFK2GZognBOtLDAkX/kYxcYF1XA=; b=DYR/cNYjYXx0ukC/9ghCQ44fMKmGf4EmHP54m3+KELovum0qTcLDOKnDi2hEmzViIjpX21 HFCodzhVpFmWdtnp2MqpEKrqs+nsEDUdBfT0UZ1NTDzcQYTF6Z0iLqI24GuG2QTaEKtuwN cs3HIsVqwqgI4DMQTgjKzqTbIRJXDu4= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-592-CFq32KV0My62Ze-qr0UW3A-1; Wed, 22 Sep 2021 02:38:18 -0400 X-MC-Unique: CFq32KV0My62Ze-qr0UW3A-1 Received: by mail-wr1-f70.google.com with SMTP id z2-20020a5d4c82000000b0015b140e0562so1175755wrs.7 for ; Tue, 21 Sep 2021 23:38:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Z3XTCa1nu8hCtlYTFFK2GZognBOtLDAkX/kYxcYF1XA=; b=xJvhw8XZ13EJTaFP+McxJ8i8Y6SH80OI6WkI7k5wriQTViOx1hVTHot1Abf6k7luRZ Wiw8tKwhOrTc7qPomEKvuGt+sqldXbU4YLWycQdfP2F2KQRLqx1Exq1D2sf9VGGA97aQ g52wg95KiZJY9aW3TEIxR8/RETNryhvYhVztx2sqRaVMq8zJdC6c8NfJLgigmyX00tHb Y6xwS2uO5kJzPyorzc9q+vjAfHPK2bNZcENoI+0OTNU27of/XxroFslU5wBf1T5x5rEY S9Y8GoKJ3hjA5x+CQ2xTpLIXuqRTDXIET+atKODNXD9fHXjbOkEmdi7qbX8ElCxr3qaA LWHQ== X-Gm-Message-State: AOAM533IxPjfwjvMGwBSBfQae17ABZksdbVcIvLZ9a7zFMFAOPzlvDRN TCCdv5rBuQXk8jMjt/6siPjKv02VT5twh9DTxZ3sFcWJ0gueY153eqxd7XLFETMTRZ0ieM1N/Jx g1H2fcCs7Id5+ELQw0LzMLxOx X-Received: by 2002:a05:600c:21c8:: with SMTP id x8mr8614019wmj.163.1632292697325; Tue, 21 Sep 2021 23:38:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJywCmZIrNrFYOLYwz4uLurAI8KkuEnxjxQSJf2bjooMgzy2h0qoOTiWQbU4UgbH2lcfc2iQrA== X-Received: by 2002:a05:600c:21c8:: with SMTP id x8mr8613976wmj.163.1632292697089; Tue, 21 Sep 2021 23:38:17 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id j21sm1162153wrd.48.2021.09.21.23.38.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Sep 2021 23:38:16 -0700 (PDT) Subject: Re: [PATCH v3 11/16] KVM: x86: More precisely identify NMI from guest when handling PMI To: Sean Christopherson , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Will Deacon , Mark Rutland , Marc Zyngier , Guo Ren , Nick Hu , Greentime Hu , Vincent Chen , Paul Walmsley , Palmer Dabbelt , Albert Ou , Boris Ostrovsky , Juergen Gross Cc: Alexander Shishkin , Jiri Olsa , Namhyung Kim , James Morse , Alexandru Elisei , Suzuki K Poulose , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Stefano Stabellini , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, Artem Kashkanov , Like Xu , Zhu Lingshan References: <20210922000533.713300-1-seanjc@google.com> <20210922000533.713300-12-seanjc@google.com> From: Paolo Bonzini Message-ID: Date: Wed, 22 Sep 2021 08:38:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210922000533.713300-12-seanjc@google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/09/21 02:05, Sean Christopherson wrote: > Note, this also doesn't completely prevent false positives if perf > somehow ends up calling into KVM, e.g. an NMI can arrive in host after > KVM sets its flag. s/calling into KVM/being called from KVM/ ? Not sure about what you meant though. The code is nice, so Reviewed-by: Paolo Bonzini Paolo