From: Mario Limonciello <mario.limonciello@amd.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-pm@vger.kernel.org, Richard Gong <richard.gong@amd.com>,
linux-usb@vger.kernel.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 10/10] HID: usbhid: Set USB mice as s2idle wakeup resources
Date: Fri, 1 Jul 2022 13:00:17 -0500 [thread overview]
Message-ID: <d444c3e5-79b1-f6a6-10e9-e597b3227434@amd.com> (raw)
In-Reply-To: <Yr6bELakZTVhpknY@kroah.com>
(FYI - combined both of Greg's responses in this message rather than
responding to them separately)
> Note, this is very different than older versions of Windows. Any idea
when this behavior and prescription changed?
Older versions of Windows also didn't support Modern Standby, so I would
hypothesize it's either Windows 8 or Windows 10 that changed it.
> Where are patches 1-9 of this series?
Patch 1 was based on your comment in v2 that there was no helper (it
introduces a helper).
Patches 2-9 are just changes across the kernel to use this helper.
The entire series was submitted to LKML, but individual patches only to
the relevant maintainers for the subsystem. If there is a v4 patch I'll
CC everyone on everything.
Here is a lore link to the whole series:
https://lore.kernel.org/lkml/20220701023328.2783-1-mario.limonciello@amd.com/
On 7/1/22 01:58, Greg KH wrote:
> On Thu, Jun 30, 2022 at 09:33:28PM -0500, Mario Limonciello wrote:
>> The USB HID transport layer doesn't configure mice for wakeup by default.
>> Thus users can not wake system from s2idle via USB mouse. However, users
>> can wake the same system from Modern Standby on Windows with the same USB
>> mouse.
>>
>> Microsoft documentation indicates that all USB mice and touchpads should
>> be waking the system from Modern Standby.
>
> As I said before, their documentation indicates that all _EXTERNAL_ mice
> and touchpads. You forgot about internally connected mice and touchpads
> here, you wouldn't want them to wake up a device asleep, right?
>
Is this actually a thing? I've been in the PC industry a while but
never seen a design that supported Modern Standby/s2idle that opted to
use USB to connect an "internal" touchpad/mouse. Microsoft's own
documentation in the same link advises against it at least too.
"We recommend using HIDI2C for input peripherals whenever possible for
better power efficiency, but this is not a requirement".
But in any case - wakeup from this type of device is a grey area. They
require that internal touchpads connected to I2C be a wake source and
also USB touchpads.
There is nothing on that page prescribing the behavior for an "internal"
USB touchpad.
Reading between the lines given the intent, I would argue if such a
design is created or exists internal USB mice and touchpads should also
be a wake up.
next prev parent reply other threads:[~2022-07-01 18:00 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-01 2:33 [PATCH v3 01/10] PM: suspend: Introduce `pm_suspend_preferred_s2idle` Mario Limonciello
2022-07-01 2:33 ` [PATCH v3 02/10] ACPI / x86: Use new `pm_suspend_preferred_s2idle` Mario Limonciello
2022-07-13 18:33 ` Rafael J. Wysocki
2022-07-01 2:33 ` [PATCH v3 03/10] ACPI: LPIT: " Mario Limonciello
2022-07-01 13:01 ` kernel test robot
2022-07-01 2:33 ` [PATCH v3 04/10] ata: ahci: Use `pm_suspend_preferred_s2idle` Mario Limonciello
2022-07-01 5:06 ` Damien Le Moal
2022-07-01 18:01 ` Mario Limonciello
2022-07-02 9:34 ` kernel test robot
2022-07-01 2:33 ` [PATCH v3 05/10] rtc: cmos: " Mario Limonciello
2022-07-01 11:50 ` kernel test robot
2022-07-01 2:33 ` [PATCH v3 06/10] thermal: intel: pch: " Mario Limonciello
2022-07-01 2:33 ` [PATCH v3 07/10] drm/amd: " Mario Limonciello
2022-07-01 2:33 ` [PATCH v3 08/10] drm/amd: Use `pm_suspend_default_s2idle` Mario Limonciello
2022-07-01 2:33 ` [PATCH v3 09/10] HID: I2C-HID: Use `pm_suspend_preferred_s2idle` Mario Limonciello
2022-07-01 2:33 ` [PATCH v3 10/10] HID: usbhid: Set USB mice as s2idle wakeup resources Mario Limonciello
2022-07-01 6:57 ` Greg KH
2022-07-01 6:58 ` Greg KH
2022-07-01 18:00 ` Mario Limonciello [this message]
2022-07-01 11:30 ` kernel test robot
2022-07-12 19:06 ` [PATCH v3 01/10] PM: suspend: Introduce `pm_suspend_preferred_s2idle` Rafael J. Wysocki
2022-07-12 20:16 ` Limonciello, Mario
2022-07-13 18:27 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d444c3e5-79b1-f6a6-10e9-e597b3227434@amd.com \
--to=mario.limonciello@amd.com \
--cc=benjamin.tissoires@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=richard.gong@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®