From: Waiman Long <longman@redhat.com>
To: Tejun Heo <tj@kernel.org>
Cc: Li Zefan <lizefan@huawei.com>,
Johannes Weiner <hannes@cmpxchg.org>,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH cgroup/for-4.13-fixes] cgroup: create dfl_root files on subsys registration
Date: Tue, 18 Jul 2017 18:09:16 -0400 [thread overview]
Message-ID: <d44b7b53-0be6-7019-169a-aa45b4d02598@redhat.com> (raw)
In-Reply-To: <20170718215746.GG3365493@devbig577.frc2.facebook.com>
On 07/18/2017 05:57 PM, Tejun Heo wrote:
> On subsystem registration, css_populate_dir() is not called on the new
> root css, so the interface files for the subsystem on cgrp_dfl_root
> aren't created on registration. This is a residue from the days when
> cgrp_dfl_root was used only as the parking spot for unused subsystems,
> which no longer is true as it's used as the root for cgroup2.
>
> This is often fine as later operations tend to create them as a part
> of mount (cgroup1) or subtree_control operations (cgroup2); however,
> it's not difficult to mount cgroup2 with the controller interface
> files missing as Waiman found out.
>
> Fix it by invoking css_populate_dir() on the root css on subsys
> registration.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Reported-by: Waiman Long <longman@redhat.com>
> Cc: stable@vger.kernel.org # v4.5+
> ---
> Hello, Waiman.
>
> Can you please verify that this fixes the bug?
>
Yes, this patch fix the problem.
Tested-by: Waiman Long <longman@redhat.com>
next prev parent reply other threads:[~2017-07-18 22:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 19:32 [PATCH] cgroup: Show control files in cgroup2 root after mount Waiman Long
2017-07-18 19:51 ` Tejun Heo
2017-07-18 20:00 ` Waiman Long
2017-07-18 20:12 ` Tejun Heo
2017-07-18 20:29 ` Waiman Long
2017-07-18 20:50 ` Tejun Heo
2017-07-18 21:06 ` Tejun Heo
2017-07-18 21:57 ` [PATCH cgroup/for-4.13-fixes] cgroup: create dfl_root files on subsys registration Tejun Heo
2017-07-18 22:09 ` Waiman Long [this message]
2017-07-18 22:11 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d44b7b53-0be6-7019-169a-aa45b4d02598@redhat.com \
--to=longman@redhat.com \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®