From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86CC8C41604 for ; Sat, 3 Oct 2020 21:35:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3C8DE206C1 for ; Sat, 3 Oct 2020 21:35:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726021AbgJCVf2 (ORCPT ); Sat, 3 Oct 2020 17:35:28 -0400 Received: from smtprelay0099.hostedemail.com ([216.40.44.99]:46694 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725913AbgJCVf1 (ORCPT ); Sat, 3 Oct 2020 17:35:27 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay07.hostedemail.com (Postfix) with ESMTP id 15FD6181D337B; Sat, 3 Oct 2020 21:35:26 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: rail62_5216b07271b0 X-Filterd-Recvd-Size: 2049 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf17.hostedemail.com (Postfix) with ESMTPA; Sat, 3 Oct 2020 21:35:24 +0000 (UTC) Message-ID: Subject: Re: [PATCH v3] net: usb: rtl8150: set random MAC address when set_ethernet_addr() fails From: Joe Perches To: Anant Thazhemadam Cc: linux-kernel-mentees@lists.linuxfoundation.org, syzbot+abbc768b560c84d92fd3@syzkaller.appspotmail.com, Petko Manolov , "David S. Miller" , Jakub Kicinski , linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Sat, 03 Oct 2020 14:35:23 -0700 In-Reply-To: <20201003211931.11544-1-anant.thazhemadam@gmail.com> References: <20201003211931.11544-1-anant.thazhemadam@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.4-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2020-10-04 at 02:49 +0530, Anant Thazhemadam wrote: > When get_registers() fails, in set_ethernet_addr(),the uninitialized > value of node_id gets copied as the address. This can be considered as > set_ethernet_addr() itself failing. [] > diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c [] > @@ -909,7 +914,10 @@ static int rtl8150_probe(struct usb_interface *intf, > goto out1; > } > fill_skb_pool(dev); > - set_ethernet_addr(dev); > + if (!set_ethernet_addr(dev)) { > + dev_err(&intf->dev, "assigining a random MAC address\n"); > + eth_hw_addr_random(dev->netdev); 4 things: o Typo for assigning o Reverse the assignment and message to show the new random MAC o This should use netdev_ o Is this better as error or notification? if (!set_ethernet_addr(dev)) { eth_hw_addr_random(dev->netdev); netdev_notice(dev->netdev, "Assigned a random MAC: %pM\n", dev->netdev->dev_addr); }