From: Krzysztof Kozlowski <krzk@kernel.org>
To: Swati Agarwal <swati.agarwal@oss.qualcomm.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Icenowy Zheng" <uwu@icenowy.me>,
"Matthias Kaehlcke" <mka@chromium.org>,
"Mike Looijmans" <mike.looijmans@topic.nl>,
"Pin-yen Lin" <treapking@chromium.org>,
"Chaoyi Chen" <chaoyi.chen@rock-chips.com>,
"J . Neuschäfer" <j.ne@posteo.net>,
"Jens Glathe" <jens.glathe@oldschoolsolutions.biz>,
"Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konradybcio@kernel.org>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v6 0/4] Enable secondary USB controller in host mode
Date: Mon, 23 Mar 2026 08:42:31 +0100 [thread overview]
Message-ID: <d44ec842-1763-4f5a-a987-f41a6e624e87@kernel.org> (raw)
In-Reply-To: <CAHz4bYvs9mnDwfkfjkebucZSQpugEqr6+sFf1-hgzNO8SodzQA@mail.gmail.com>
On 23/03/2026 08:36, Swati Agarwal wrote:
> On Wed, Mar 18, 2026 at 12:33 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On Wed, Mar 18, 2026 at 09:36:40AM +0530, Swati Agarwal wrote:
>>> Enable secondary USB controller in host mode.
>>>
>>> This patch depends on:
>>> https://lore.kernel.org/all/20260306091355.1178333-1-swati.agarwal@oss.qualcomm.com/
>>
>> Honestly? No. Drivers cannot depend on DTS.
> Hi Krysztof,
>
> Here what i meant by dependency is that I have rebase this patch
> series over below patch series. Below patch series is related to USB2
And you should not. Drivers cannot be based on DTS branch.
> micro USB controller support on lemans EVK.
> https://lore.kernel.org/all/20260306091355.1178333-1-swati.agarwal@oss.qualcomm.com/
>
> There is no dependency of drivers on DT.
>
>>
>> Also, combining here USB is a no-go. Do not combine independent
>> patchsets into one patchset.
>>
>> I also do not see how you addressed my comments from previous version.
>> You never bothered to respond and I do not see them implemented.
>
> Apologies if i missed replying any comments.
> Regarding your comment on v3 series below:- GL3590 hub used in lemans
> EVK requires only 1.2V and 3.3V supplies for operation, confirmes the
> same from our internal HW team and update the same in thereafter patch
> sets.
> https://lore.kernel.org/all/20251220-economic-gay-firefly-1873a9@quoll/
This does not address the feedback. I did not talk about Lemans EVK. I
don't even have its datasheet. We speak here about GL3590. I found at
least three supplies in datasheet. Your binding has only two.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-03-23 7:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-18 4:06 Swati Agarwal
2026-03-18 4:06 ` [PATCH v6 1/4] dt-bindings: usb: Add binding for Genesys Logic GL3590 hub Swati Agarwal
2026-03-18 7:01 ` Krzysztof Kozlowski
2026-03-26 10:07 ` Swati Agarwal
2026-03-26 10:09 ` Krzysztof Kozlowski
2026-03-26 11:42 ` Swati Agarwal
2026-03-18 4:06 ` [PATCH v6 2/4] usb: misc: onboard_usb_hub: Add Genesys Logic GL3590 hub support Swati Agarwal
2026-03-30 11:43 ` Dmitry Baryshkov
2026-03-18 4:06 ` [PATCH v6 3/4] arm64: dts: qcom: lemans-evk: Rename hd3ss3220_ instance for primary port controller Swati Agarwal
2026-03-18 4:06 ` [PATCH v6 4/4] arm64: dts: qcom: lemans-evk: Enable secondary USB controller in host mode Swati Agarwal
2026-03-18 7:03 ` [PATCH v6 0/4] " Krzysztof Kozlowski
2026-03-23 7:36 ` Swati Agarwal
2026-03-23 7:42 ` Krzysztof Kozlowski [this message]
2026-03-26 7:04 ` Swati Agarwal
2026-03-26 7:26 ` Krzysztof Kozlowski
2026-03-26 10:09 ` Swati Agarwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d44ec842-1763-4f5a-a987-f41a6e624e87@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=chaoyi.chen@rock-chips.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=j.ne@posteo.net \
--cc=jens.glathe@oldschoolsolutions.biz \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mike.looijmans@topic.nl \
--cc=mka@chromium.org \
--cc=robh@kernel.org \
--cc=swati.agarwal@oss.qualcomm.com \
--cc=treapking@chromium.org \
--cc=uwu@icenowy.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®