From: Andrew Lunn <andrew@lunn.ch>
To: Pufan Jin <cyan2254650260@gmail.com>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3] net: phy: realtek: Add support for JLSemi JL2101 and JL2121 PHYs
Date: Wed, 21 Oct 2026 14:19:08 +0200 [thread overview]
Message-ID: <d4517460-7598-4c87-8540-3abd6f6339b3@lunn.ch> (raw)
In-Reply-To: <20261021042029.44853-1-cyan2254650260@gmail.com>
> - Drop standalone driver drivers/net/phy/jlsemi.c and extend the Realtek
> PHY driver directly as suggested by Andrew Lunn.
> +#define JLSEMI_JL2101_PHYID 0x937c4032
> +#define JLSEMI_JL2121_PHYID 0x937c4030
> + }, {
> + PHY_ID_MATCH_EXACT(JLSEMI_JL2101_PHYID),
> + .name = "JLSemi JL2101 Gigabit Ethernet",
...
> + }, {
> + PHY_ID_MATCH_MODEL(JLSEMI_JL2121_PHYID),
> + .name = "JLSemi JL2121 Gigabit Ethernet",
Do you have any documentation about these IDs? Why do you think one
should be an exact match, and the other a model match? The fact the
2102 is within the 2121 range makes this look odd to me. So it would
be good to have some explanation.
Andrew
prev parent reply other threads:[~2026-10-21 12:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 4:20 Pufan Jin
2026-10-21 12:19 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4517460-7598-4c87-8540-3abd6f6339b3@lunn.ch \
--to=andrew@lunn.ch \
--cc=cyan2254650260@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®