From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751930AbdHGUGQ (ORCPT ); Mon, 7 Aug 2017 16:06:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46252 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751589AbdHGUGO (ORCPT ); Mon, 7 Aug 2017 16:06:14 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 3EA7F1555A Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=prarit@redhat.com Subject: Re: [PATCH v4] printk: Add monotonic, boottime, and realtime timestamps To: John Stultz References: <1502121162-27981-1-git-send-email-prarit@redhat.com> <9452a611-aefb-543e-e2f7-32301b29a2cc@redhat.com> Cc: lkml , Mark Salyzyn , Jonathan Corbet , Petr Mladek , Sergey Senozhatsky , Steven Rostedt , Thomas Gleixner , Stephen Boyd , Andrew Morton , Greg Kroah-Hartman , "Paul E. McKenney" , Christoffer Dall , Deepa Dinamani , Ingo Molnar , Joel Fernandes , Kees Cook , Peter Zijlstra , Geert Uytterhoeven , "Luis R. Rodriguez" , Nicholas Piggin , "Jason A. Donenfeld" , Olof Johansson , Josh Poimboeuf , linux-doc@vger.kernel.org From: Prarit Bhargava Message-ID: Date: Mon, 7 Aug 2017 16:06:09 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Mon, 07 Aug 2017 20:06:14 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/07/2017 02:47 PM, John Stultz wrote: > On Mon, Aug 7, 2017 at 11:04 AM, Prarit Bhargava wrote: >> On 08/07/2017 12:52 PM, John Stultz wrote: >>> Still not quite following why you're updating all the defconfigs. I'd >>> make sure the Kconfig default settings are right, and leave updating >>> the defconfig to arch/device maintainers. It adds a lot of noise to >>> the patch. >> >> Hmm ... I thought it was up to the patch submitter to make sure that >> 'make defconfig' still worked? Are you sure I can leave that broken? >> >> /me *really* doesn't want to get yelled at by every arch maintainer. > > No. Don't break systems, but at the same time, can't you use the > default value in Kconfig to set it properly so the old defconfig > settings don't really matter? > > Apologies if I've not followed the issue properly, but it is odd, as > I'm not sure I can think of a patch I've seen before that had so much > defconfig noise in it. Again, I've not looked into it closely, so it > may just be my own ignorance, but it makes me suspect there is a > better way. > peterz? Want to offer a suggestion? The issue is that I'm changing a bool config option to an int and that impacts all the arch's defconfigs. John points out that this is a lot of churn and we're both wondering if there's a better way to do the configs. P.