From: Andy Yan <andy.yan@rock-chips.com>
To: "Heiko Stübner" <heiko@sntech.de>, "Andy Yan" <andyshrk@163.com>
Cc: hjc@rock-chips.com, dri-devel@lists.freedesktop.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
devicetree@vger.kernel.org, sebastian.reichel@collabora.com,
kever.yang@rock-chips.com, chris.obbard@collabora.com
Subject: Re: [PATCH v4 16/17] arm64: dts: rockchip: Add vop on rk3588
Date: Sat, 9 Dec 2023 09:28:55 +0800 [thread overview]
Message-ID: <d45b1a26-3ea3-4699-b86f-cc7d38718721@rock-chips.com> (raw)
In-Reply-To: <4730849.ejJDZkT8p0@diego>
Hi Heiko:
On 12/9/23 00:26, Heiko Stübner wrote:
> Hi Andy,
>
> Am Donnerstag, 7. Dezember 2023, 09:02:47 CET schrieb Andy Yan:
>> From: Andy Yan <andy.yan@rock-chips.com>
>>
>> Add vop dt node for rk3588.
>>
>> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
>> ---
>>
>> (no changes since v1)
>>
>> arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 96 +++++++++++++++++++++++
>> 1 file changed, 96 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
>> index 7064c0e9179f..a9810ca78dc4 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
>> +++ b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
>> @@ -593,6 +608,87 @@ i2c0: i2c@fd880000 {
>> status = "disabled";
>> };
>>
>> + vop: vop@fdd90000 {
>> + compatible = "rockchip,rk3588-vop";
>> + reg = <0x0 0xfdd90000 0x0 0x4200>, <0x0 0xfdd95000 0x0 0x1000>;
>> + reg-names = "vop", "gamma_lut";
>> + interrupts = <GIC_SPI 156 IRQ_TYPE_LEVEL_HIGH 0>;
>> + clocks = <&cru ACLK_VOP>,
>> + <&cru HCLK_VOP>,
>> + <&cru DCLK_VOP0>,
>> + <&cru DCLK_VOP1>,
>> + <&cru DCLK_VOP2>,
>> + <&cru DCLK_VOP3>,
>> + <&cru PCLK_VOP_ROOT>;
>> + clock-names = "aclk",
>> + "hclk",
>> + "dclk_vp0",
>> + "dclk_vp1",
>> + "dclk_vp2",
>> + "dclk_vp3",
>> + "pclk_vop";
>> + resets = <&cru SRST_A_VOP>,
>> + <&cru SRST_H_VOP>,
>> + <&cru SRST_D_VOP0>,
>> + <&cru SRST_D_VOP1>,
>> + <&cru SRST_D_VOP2>,
>> + <&cru SRST_D_VOP3>;
>> + reset-names = "axi",
>> + "ahb",
>> + "dclk_vp0",
>> + "dclk_vp1",
>> + "dclk_vp2",
>> + "dclk_vp3";
>
> resets and reset-names do not seem to be part of the binding, so
> should probably be added there.
I will drop resets and reset-names in next version.
>
>
>> + iommus = <&vop_mmu>;
>> + power-domains = <&power RK3588_PD_VOP>;
>> + rockchip,grf = <&sys_grf>;
>> + rockchip,vop-grf = <&vop_grf>;
>> + rockchip,vo1-grf = <&vo1_grf>;
>> + rockchip,pmu = <&pmu>;
>> +
>
> move this blank line _below_ the status=disabled please.
ok, will do.
>
>> + status = "disabled";
>> + vop_out: ports {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + vp0: port@0 {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + reg = <0>;
>> + };
>> +
>> + vp1: port@1 {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + reg = <1>;
>> + };
>> +
>> + vp2: port@2 {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + reg = <2>;
>> + };
>> +
>> + vp3: port@3 {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + reg = <3>;
>> + };
>> + };
>> + };
>> +
>> + vop_mmu: iommu@fdd97e00 {
>> + compatible = "rockchip,rk3588-iommu", "rockchip,rk3568-iommu";
>> + reg = <0x0 0xfdd97e00 0x0 0x100>, <0x0 0xfdd97f00 0x0 0x100>;
>> + interrupts = <GIC_SPI 156 IRQ_TYPE_LEVEL_HIGH 0>;
>> + interrupt-names = "vop_mmu";
>
> interrupt-names is not part of the mainline iommu binding, so should be dropped
will do.
>
>
> Thanks
> Heiko
>
>
next prev parent reply other threads:[~2023-12-09 1:44 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 7:59 [PATCH v4 00/17] Add VOP2 support " Andy Yan
2023-12-07 7:59 ` [PATCH v4 01/17] drm/rockchip: move output interface related definition to rockchip_drm_drv.h Andy Yan
2023-12-07 7:59 ` [PATCH v4 02/17] Revert "drm/rockchip: vop2: Use regcache_sync() to fix suspend/resume" Andy Yan
2023-12-07 8:00 ` [PATCH v4 03/17] drm/rockchip: vop2: set half_block_en bit in all mode Andy Yan
2023-12-07 8:00 ` [PATCH v4 04/17] drm/rockchip: vop2: clear afbc en and transform bit for cluster window at linear mode Andy Yan
2023-12-07 8:00 ` [PATCH v4 05/17] drm/rockchip: vop2: Add write mask for VP config done Andy Yan
2023-12-07 8:00 ` [PATCH v4 06/17] drm/rockchip: vop2: Set YUV/RGB overlay mode Andy Yan
2023-12-07 8:00 ` [PATCH v4 07/17] drm/rockchip: vop2: set bg dly and prescan dly at vop2_post_config Andy Yan
2023-12-07 8:01 ` [PATCH v4 08/17] drm/rockchip: vop2: rename grf to sys_grf Andy Yan
2023-12-07 8:01 ` [PATCH v4 09/17] dt-bindings: soc: rockchip: add rk3588 vop/vo syscon Andy Yan
2023-12-07 8:01 ` [PATCH v4 10/17] dt-bindings: display: vop2: Add rk3588 support Andy Yan
2023-12-08 17:46 ` Krzysztof Kozlowski
2023-12-09 1:30 ` Andy Yan
2023-12-07 8:01 ` [PATCH v4 11/17] dt-bindings: rockchip,vop2: Add more endpoint definition Andy Yan
2023-12-07 8:01 ` [PATCH v4 12/17] drm/rockchip: vop2: Add support for rk3588 Andy Yan
2023-12-07 8:02 ` [PATCH v4 13/17] drm/rockchip: vop2: rename VOP_FEATURE_OUTPUT_10BIT to VOP2_VP_FEATURE_OUTPUT_10BIT Andy Yan
2023-12-11 7:02 ` Sascha Hauer
2023-12-07 8:02 ` [PATCH v4 14/17] drm/rockchip: vop2: Add debugfs support Andy Yan
2023-12-11 6:59 ` Sascha Hauer
2023-12-07 8:02 ` [PATCH v4 15/17] dt-bindings: iommu: rockchip: Add Rockchip RK3588 Andy Yan
2023-12-08 16:29 ` Heiko Stübner
2023-12-09 1:26 ` Andy Yan
2023-12-09 14:04 ` Heiko Stübner
2023-12-08 17:47 ` Krzysztof Kozlowski
2023-12-07 8:02 ` [PATCH v4 16/17] arm64: dts: rockchip: Add vop on rk3588 Andy Yan
2023-12-08 16:26 ` Heiko Stübner
2023-12-09 1:28 ` Andy Yan [this message]
2023-12-07 8:03 ` [PATCH v4 17/17] MAINTAINERS: Add myself as a reviewer for rockchip drm Andy Yan
2023-12-08 16:07 ` [PATCH v4 00/17] Add VOP2 support on rk3588 Heiko Stübner
2023-12-09 1:21 ` Andy Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d45b1a26-3ea3-4699-b86f-cc7d38718721@rock-chips.com \
--to=andy.yan@rock-chips.com \
--cc=andyshrk@163.com \
--cc=chris.obbard@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=kever.yang@rock-chips.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®