From: Richard Fitzgerald <rf@opensource.cirrus.com>
To: Claudiu <claudiu.beznea@tuxon.dev>,
support.opensource@diasemi.com, lgirdwood@gmail.com,
broonie@kernel.org, perex@perex.cz, tiwai@suse.com,
biju.das.jz@bp.renesas.com,
prabhakar.mahadev-lad.rj@bp.renesas.com
Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-renesas-soc@vger.kernel.org,
Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 1/2] ASoC: codecs: Use component driver suspend/resume
Date: Wed, 29 Oct 2025 14:38:05 +0000 [thread overview]
Message-ID: <d461038d-67c6-428d-8a88-5bd249dc25b3@opensource.cirrus.com> (raw)
In-Reply-To: <20251029141134.2556926-2-claudiu.beznea.uj@bp.renesas.com>
On 29/10/2025 2:11 pm, Claudiu wrote:
> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
>
> Since snd_soc_suspend() is invoked through snd_soc_pm_ops->suspend(),
> and snd_soc_pm_ops is associated with the soc_driver (defined in
> sound/soc/soc-core.c), and there is no parent-child relationship between
> the soc_driver and the DA7213 codec driver, the power management subsystem
> does not enforce a specific suspend/resume order between the DA7213 driver
> and the soc_driver.
>
> Because of this, the different codec component functionalities, called from
> snd_soc_resume() to reconfigure various functions, can race with the
> DA7213 resume function, leading to misapplied configuration.
> This occasionally results in clipped sound.
>
> Fix this by moving the regmap cache operations into
> struct snd_soc_component_driver::{suspend, resume}. This ensures the
> proper configuration sequence is handled by the ASoC subsystem.
>
> Cc: stable@vger.kernel.org
> Fixes: 431e040065c8 ("ASoC: da7213: Add suspend to RAM support")
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
> ---
> sound/soc/codecs/da7213.c | 38 +++++++++++++++++++++++++-------------
> 1 file changed, 25 insertions(+), 13 deletions(-)
The commit title starts "ASoC: codecs:", which implies that this
patch affects multiple codecs. But it only changes one file.
The commit title prefix should be "ASoC: da7213:", same as the
commit you reference in the Fixes: tag.
next prev parent reply other threads:[~2025-10-29 14:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 14:11 [PATCH 0/2] ASoC: renesas: Fix clip sounds Claudiu
2025-10-29 14:11 ` [PATCH 1/2] ASoC: codecs: Use component driver suspend/resume Claudiu
2025-10-29 14:37 ` Mark Brown
2025-10-29 15:22 ` claudiu beznea
2025-10-29 16:14 ` Mark Brown
2025-11-04 11:53 ` Claudiu Beznea
2025-10-29 14:37 ` Mark Brown
2025-10-29 15:29 ` claudiu beznea
2025-10-29 14:38 ` Richard Fitzgerald [this message]
2025-10-29 14:11 ` [PATCH 2/2] ASoC: renesas: rz-ssi: Use proper dma_buffer_pos after resume Claudiu
2025-10-30 11:09 ` (subset) [PATCH 0/2] ASoC: renesas: Fix clip sounds Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d461038d-67c6-428d-8a88-5bd249dc25b3@opensource.cirrus.com \
--to=rf@opensource.cirrus.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=broonie@kernel.org \
--cc=claudiu.beznea.uj@bp.renesas.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=stable@vger.kernel.org \
--cc=support.opensource@diasemi.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®