mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@kernel.org>
To: Joel Fernandes <joelagnelf@nvidia.com>
Cc: linux-kernel@vger.kernel.org, Boqun Feng <boqun.feng@gmail.com>,
	rcu@vger.kernel.org, Frederic Weisbecker <frederic@kernel.org>,
	Neeraj Upadhyay <neeraj.upadhyay@kernel.org>,
	Josh Triplett <josh@joshtriplett.org>,
	Uladzislau Rezki <urezki@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Lai Jiangshan <jiangshanlai@gmail.com>,
	Zqiang <qiang.zhang@linux.dev>
Subject: Re: [PATCH -next v3 0/3] rcu/nocb: Cleanup patches for next merge window
Date: Wed, 21 Jan 2026 11:58:31 -0800	[thread overview]
Message-ID: <d464331a-23dc-49d5-9fa4-be91d8ece84d@paulmck-laptop> (raw)
In-Reply-To: <cddea3f4-4041-491c-87f8-0ffba948a3b6@nvidia.com>

On Wed, Jan 21, 2026 at 02:50:54PM -0500, Joel Fernandes wrote:
> 
> 
> On 1/21/2026 2:41 PM, Paul E. McKenney wrote:
> > On Wed, Jan 21, 2026 at 02:13:56PM -0500, Joel Fernandes wrote:
> >>
> >>
> >> On 1/21/2026 2:09 PM, Paul E. McKenney wrote:
> >>> On Mon, Jan 19, 2026 at 06:12:20PM -0500, Joel Fernandes wrote:
> >>>> These are a few nocb related cleanup patches for the next merge window.
> >>>>
> >>>> Also Frederic please object to the second patch ("Remove dead callback overload
> >>>> handling") if you would like, but I think based on our discussion I have
> >>>> implemented your suggestion, so it should be good.
> >>>>
> >>>> Changes from v2:
> >>>> - Dropped patch 2 "Add warning if no rcuog wake up attempt happened during
> >>>>   overload" as it was not needed since we removed the dead CB overload handling.
> >>>> - Replaced "Add warning to detect if overload advancement is ever useful" with
> >>>>   "Remove dead callback overload handling" per Frederic's feedback - instead of
> >>>>   adding a warning, just remove the dead code path entirely.
> >>>>
> >>>> nocb rcutorture scenarios passed overnight testing on my system.
> >>>
> >>> I reverted three of your earlier patches in order to apply this, only
> >>> one of which I am really confident in.  Please check my -rcu tree to see
> >>> if any of the three should be added back in, and I am starting tests in
> >>> the meantime.Age	Commit message (Expand)	Author	Files	Lines
> >>
> >> Per your latest /dev branch
> >> (https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git/log/?h=dev),
> >> you have the latest 3 patches:
> >>
> >> Extract nocb_defer_wakeup_cancel() helperdev	Joel Fernandes	1	-8/+11
> >> rcu/nocb: Remove dead callback overload handling	Joel Fernandes	1	-12/+0
> >> rcu/nocb: Remove unnecessary WakeOvfIsDeferred wake path	Joel Fernandes	3	-36/+18
> > 
> > Thank you for checking!
> > 
> > And just to double-check, all of the patches that I reverted are obsolete,
> > correct?
> 
> Yes, those patches were from v2. You have correctly applied the latest v3 version.

Woo-hoo!!!  ;-)

							Thanx, Paul

      reply	other threads:[~2026-01-21 19:58 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-19 23:12 Joel Fernandes
2026-01-19 23:12 ` [PATCH -next v3 1/3] rcu/nocb: Remove unnecessary WakeOvfIsDeferred wake path Joel Fernandes
2026-01-22 21:56   ` Paul E. McKenney
2026-01-19 23:12 ` [PATCH -next v3 2/3] rcu/nocb: Remove dead callback overload handling Joel Fernandes
2026-01-19 23:53   ` Frederic Weisbecker
2026-01-20  0:07     ` Paul E. McKenney
2026-01-20  0:59       ` joelagnelf
2026-01-22 21:55   ` Paul E. McKenney
2026-01-22 23:43     ` Joel Fernandes
2026-01-23  0:12       ` Paul E. McKenney
2026-01-23  5:41   ` Paul E. McKenney
2026-01-19 23:12 ` [PATCH -next v3 3/3] rcu/nocb: Extract nocb_defer_wakeup_cancel() helper Joel Fernandes
2026-01-22 21:59   ` Paul E. McKenney
2026-01-21 19:09 ` [PATCH -next v3 0/3] rcu/nocb: Cleanup patches for next merge window Paul E. McKenney
2026-01-21 19:13   ` Joel Fernandes
2026-01-21 19:41     ` Paul E. McKenney
2026-01-21 19:50       ` Joel Fernandes
2026-01-21 19:58         ` Paul E. McKenney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d464331a-23dc-49d5-9fa4-be91d8ece84d@paulmck-laptop \
    --to=paulmck@kernel.org \
    --cc=boqun.feng@gmail.com \
    --cc=frederic@kernel.org \
    --cc=jiangshanlai@gmail.com \
    --cc=joelagnelf@nvidia.com \
    --cc=josh@joshtriplett.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=neeraj.upadhyay@kernel.org \
    --cc=qiang.zhang@linux.dev \
    --cc=rcu@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=urezki@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®