From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC04CC433E0 for ; Thu, 28 May 2020 04:07:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C704320888 for ; Thu, 28 May 2020 04:07:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726793AbgE1EHq (ORCPT ); Thu, 28 May 2020 00:07:46 -0400 Received: from smtprelay0226.hostedemail.com ([216.40.44.226]:53618 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725830AbgE1EHp (ORCPT ); Thu, 28 May 2020 00:07:45 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay05.hostedemail.com (Postfix) with ESMTP id 8167D18029597; Thu, 28 May 2020 04:07:44 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: hill77_1b1293126d57 X-Filterd-Recvd-Size: 8369 Received: from XPS-9350.home (unknown [47.151.136.130]) (Authenticated sender: joe@perches.com) by omf08.hostedemail.com (Postfix) with ESMTPA; Thu, 28 May 2020 04:07:43 +0000 (UTC) Message-ID: Subject: Re: [PATCH 1/2] xen-pciback: Use dev_printk() when possible From: Joe Perches To: Boris Ostrovsky , Bjorn Helgaas , Juergen Gross Cc: Stefano Stabellini , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, Bjorn Helgaas Date: Wed, 27 May 2020 21:07:41 -0700 In-Reply-To: <612fee00-4e7c-9b90-511d-4efb7676cbed@oracle.com> References: <20200527174326.254329-1-helgaas@kernel.org> <20200527174326.254329-2-helgaas@kernel.org> <612fee00-4e7c-9b90-511d-4efb7676cbed@oracle.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.2-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2020-05-27 at 15:34 -0700, Boris Ostrovsky wrote: > On 5/27/20 1:43 PM, Bjorn Helgaas wrote: > > @@ -155,8 +157,8 @@ int xen_pcibk_config_read(struct pci_dev *dev, int offset, int size, > > u32 value = 0, tmp_val; > > > > if (unlikely(verbose_request)) > > - printk(KERN_DEBUG DRV_NAME ": %s: read %d bytes at 0x%x\n", > > - pci_name(dev), size, offset); > > + dev_printk(KERN_DEBUG, &dev->dev, "read %d bytes at 0x%x\n", > > + size, offset); > > Maybe then dev_dbg() ? It likely would be better to remove verbose_request altogether and just use dynamic debugging and dev_dbg for all the output. $ git grep -w -A3 verbose_request drivers/pci/xen-pcifront.c:static int verbose_request; drivers/pci/xen-pcifront.c:module_param(verbose_request, int, 0644); drivers/pci/xen-pcifront.c- drivers/pci/xen-pcifront.c-static int errno_to_pcibios_err(int errno) drivers/pci/xen-pcifront.c-{ -- drivers/pci/xen-pcifront.c: if (verbose_request) drivers/pci/xen-pcifront.c- dev_info(&pdev->xdev->dev, drivers/pci/xen-pcifront.c- "read dev=%04x:%02x:%02x.%d - offset %x size %d\n", drivers/pci/xen-pcifront.c- pci_domain_nr(bus), bus->number, PCI_SLOT(devfn), -- drivers/pci/xen-pcifront.c: if (verbose_request) drivers/pci/xen-pcifront.c- dev_info(&pdev->xdev->dev, "read got back value %x\n", drivers/pci/xen-pcifront.c- op.value); drivers/pci/xen-pcifront.c- -- drivers/pci/xen-pcifront.c: if (verbose_request) drivers/pci/xen-pcifront.c- dev_info(&pdev->xdev->dev, drivers/pci/xen-pcifront.c- "write dev=%04x:%02x:%02x.%d - " drivers/pci/xen-pcifront.c- "offset %x size %d val %x\n", -- drivers/xen/xen-pciback/conf_space.c: if (unlikely(verbose_request)) drivers/xen/xen-pciback/conf_space.c- printk(KERN_DEBUG DRV_NAME ": %s: read %d bytes at 0x%x\n", drivers/xen/xen-pciback/conf_space.c- pci_name(dev), size, offset); drivers/xen/xen-pciback/conf_space.c- -- drivers/xen/xen-pciback/conf_space.c: if (unlikely(verbose_request)) drivers/xen/xen-pciback/conf_space.c- printk(KERN_DEBUG DRV_NAME ": %s: read %d bytes at 0x%x = %x\n", drivers/xen/xen-pciback/conf_space.c- pci_name(dev), size, offset, value); drivers/xen/xen-pciback/conf_space.c- -- drivers/xen/xen-pciback/conf_space.c: if (unlikely(verbose_request)) drivers/xen/xen-pciback/conf_space.c- printk(KERN_DEBUG drivers/xen/xen-pciback/conf_space.c- DRV_NAME ": %s: write request %d bytes at 0x%x = %x\n", drivers/xen/xen-pciback/conf_space.c- pci_name(dev), size, offset, value); -- drivers/xen/xen-pciback/conf_space_header.c: if (unlikely(verbose_request)) drivers/xen/xen-pciback/conf_space_header.c- printk(KERN_DEBUG DRV_NAME ": %s: enable\n", drivers/xen/xen-pciback/conf_space_header.c- pci_name(dev)); drivers/xen/xen-pciback/conf_space_header.c- err = pci_enable_device(dev); -- drivers/xen/xen-pciback/conf_space_header.c: if (unlikely(verbose_request)) drivers/xen/xen-pciback/conf_space_header.c- printk(KERN_DEBUG DRV_NAME ": %s: disable\n", drivers/xen/xen-pciback/conf_space_header.c- pci_name(dev)); drivers/xen/xen-pciback/conf_space_header.c- pci_disable_device(dev); -- drivers/xen/xen-pciback/conf_space_header.c: if (unlikely(verbose_request)) drivers/xen/xen-pciback/conf_space_header.c- printk(KERN_DEBUG DRV_NAME ": %s: set bus master\n", drivers/xen/xen-pciback/conf_space_header.c- pci_name(dev)); drivers/xen/xen-pciback/conf_space_header.c- pci_set_master(dev); -- drivers/xen/xen-pciback/conf_space_header.c: if (unlikely(verbose_request)) drivers/xen/xen-pciback/conf_space_header.c- printk(KERN_DEBUG DRV_NAME ": %s: clear bus master\n", drivers/xen/xen-pciback/conf_space_header.c- pci_name(dev)); drivers/xen/xen-pciback/conf_space_header.c- pci_clear_master(dev); -- drivers/xen/xen-pciback/conf_space_header.c: if (unlikely(verbose_request)) drivers/xen/xen-pciback/conf_space_header.c- printk(KERN_DEBUG drivers/xen/xen-pciback/conf_space_header.c- DRV_NAME ": %s: enable memory-write-invalidate\n", drivers/xen/xen-pciback/conf_space_header.c- pci_name(dev)); -- drivers/xen/xen-pciback/conf_space_header.c: if (unlikely(verbose_request)) drivers/xen/xen-pciback/conf_space_header.c- printk(KERN_DEBUG drivers/xen/xen-pciback/conf_space_header.c- DRV_NAME ": %s: disable memory-write-invalidate\n", drivers/xen/xen-pciback/conf_space_header.c- pci_name(dev)); -- drivers/xen/xen-pciback/pciback.h:extern int verbose_request; drivers/xen/xen-pciback/pciback.h- drivers/xen/xen-pciback/pciback.h-void xen_pcibk_test_and_schedule_op(struct xen_pcibk_device *pdev); drivers/xen/xen-pciback/pciback.h-#endif -- drivers/xen/xen-pciback/pciback_ops.c:int verbose_request; drivers/xen/xen-pciback/pciback_ops.c:module_param(verbose_request, int, 0644); drivers/xen/xen-pciback/pciback_ops.c- drivers/xen/xen-pciback/pciback_ops.c-static irqreturn_t xen_pcibk_guest_interrupt(int irq, void *dev_id); drivers/xen/xen-pciback/pciback_ops.c- -- drivers/xen/xen-pciback/pciback_ops.c: if (unlikely(verbose_request)) drivers/xen/xen-pciback/pciback_ops.c- printk(KERN_DEBUG DRV_NAME ": %s: enable MSI\n", pci_name(dev)); drivers/xen/xen-pciback/pciback_ops.c- drivers/xen/xen-pciback/pciback_ops.c- if (dev->msi_enabled) -- drivers/xen/xen-pciback/pciback_ops.c: if (unlikely(verbose_request)) drivers/xen/xen-pciback/pciback_ops.c- printk(KERN_DEBUG DRV_NAME ": %s: MSI: %d\n", pci_name(dev), drivers/xen/xen-pciback/pciback_ops.c- op->value); drivers/xen/xen-pciback/pciback_ops.c- -- drivers/xen/xen-pciback/pciback_ops.c: if (unlikely(verbose_request)) drivers/xen/xen-pciback/pciback_ops.c- printk(KERN_DEBUG DRV_NAME ": %s: disable MSI\n", drivers/xen/xen-pciback/pciback_ops.c- pci_name(dev)); drivers/xen/xen-pciback/pciback_ops.c- -- drivers/xen/xen-pciback/pciback_ops.c: if (unlikely(verbose_request)) drivers/xen/xen-pciback/pciback_ops.c- printk(KERN_DEBUG DRV_NAME ": %s: MSI: %d\n", pci_name(dev), drivers/xen/xen-pciback/pciback_ops.c- op->value); drivers/xen/xen-pciback/pciback_ops.c- return 0; -- drivers/xen/xen-pciback/pciback_ops.c: if (unlikely(verbose_request)) drivers/xen/xen-pciback/pciback_ops.c- printk(KERN_DEBUG DRV_NAME ": %s: enable MSI-X\n", drivers/xen/xen-pciback/pciback_ops.c- pci_name(dev)); drivers/xen/xen-pciback/pciback_ops.c- -- drivers/xen/xen-pciback/pciback_ops.c: if (unlikely(verbose_request)) drivers/xen/xen-pciback/pciback_ops.c- printk(KERN_DEBUG DRV_NAME ": %s: " \ drivers/xen/xen-pciback/pciback_ops.c- "MSI-X[%d]: %d\n", drivers/xen/xen-pciback/pciback_ops.c- pci_name(dev), i, -- drivers/xen/xen-pciback/pciback_ops.c: if (unlikely(verbose_request)) drivers/xen/xen-pciback/pciback_ops.c- printk(KERN_DEBUG DRV_NAME ": %s: disable MSI-X\n", drivers/xen/xen-pciback/pciback_ops.c- pci_name(dev)); drivers/xen/xen-pciback/pciback_ops.c- -- drivers/xen/xen-pciback/pciback_ops.c: if (unlikely(verbose_request)) drivers/xen/xen-pciback/pciback_ops.c- printk(KERN_DEBUG DRV_NAME ": %s: MSI-X: %d\n", drivers/xen/xen-pciback/pciback_ops.c- pci_name(dev), op->value); drivers/xen/xen-pciback/pciback_ops.c- return 0;