From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E553B48BD3C for ; Wed, 1 Jul 2026 12:55:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782910503; cv=none; b=lORP6tPJPFQ8sevgBH7rymcKeQ+JEHaF3Q6GWHW6lEzMU0oWj93TvUtrUeYDQaDPMGzmNf5R+34b8Rj5SrZfJCeid/0GDpOLxzlAau3lcUXdwp/jLbclDlQ8akFjyzGL1xNHoOVbKIvALaN5rraMciKTYnRQY7Wmosn04N7WYEs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782910503; c=relaxed/simple; bh=74p5OdZcEEGetMQvAyC2B1sZkPILGKwBYM/hhxiO4nE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=k1hphY6FkoD0xlW7bQIqh0iHgyCKctkZQfaSmUgF/5JSRs142g+qP5iv2Pm8CcXEfGsfc41fIkNKY0V8zb5bJO4Gslu02ypIrJyhlXGUgXAXuGlaAXTarYqERb9Wv0u0m9YzczWAs1aSTqcxqDqmACkwhJag6Ok7FKGsTGgCUm0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=MtSdEaD6; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZEPac8hB; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="MtSdEaD6"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZEPac8hB" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 661A9h9v723400 for ; Wed, 1 Jul 2026 12:55:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= nhlWz8cCtqL5ox7tNsxAOt2t1RqIW/0rkCL7ft+bkww=; b=MtSdEaD6slx+sUQx jGrKqq9oOpitSm3+7YllihpIWFsbms/IQtzHZpq0YzLf9l+yfGPclBHNT5MsT1XL lN+7julGIpxpbGGQo7NWrz4wsu59XWiamJsG7+6wupLbQNJTUlXE1xxvo8wOo/Sv DvxwW5ocUcHqJmAXGEXdc17uisw03Pg9MNmhZ5K7NpE0peghZkmrFVzPCUiVqUxx kh3tvH6bJ+pLCp4X3ldt5lRaHJxG7TzIT3aGhjmQ42+ooT6VR2TuJty2cYS6MkUu LBkUTNzNLGLq7avLyaVmFnyzwD0cEd22Tix9/5Vv4BxXzjM7AlTNwxsqpLtfdF4V cWeD7w== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f4jvwc4v0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 01 Jul 2026 12:55:00 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-84240683a82so647901b3a.1 for ; Wed, 01 Jul 2026 05:55:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782910500; x=1783515300; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nhlWz8cCtqL5ox7tNsxAOt2t1RqIW/0rkCL7ft+bkww=; b=ZEPac8hB71OdogfNBzw6EwZwbHja3MRCYsWzaBcL3sJxc58XwqcdAOmRG/e+bZD6zF 9oUwFogrcMBGJeBjpDVK/fzguHhRfuzE9wuxTm2vRKrjkBQSTPTDwG1Cp5oBbN/GVbKH JHpQWaicjTjahXMcUUBoMHMIY18IeJKGfXoey+0jTjN5fzcvUXePyuzgUaLCocJoqq3T /6nlgMF193pnaFsHmS32186FYnWmtDcy2VSrbvveuo9L2+vywpZss+84+aFqRltawPqz FAru0PZNp7JMuwBNxGxND6B38KtGKWRdO0Vx+nElHuz4BDo4LF/85br0+K35ps7k/Eex 6OzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782910500; x=1783515300; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nhlWz8cCtqL5ox7tNsxAOt2t1RqIW/0rkCL7ft+bkww=; b=R2xt0ZbmCwHVou6dKZZKdFEty2jipUcYDz7upGqkDKSsmpy14BbPDJ8olmiyJ+FZp7 0EHt4Tg3tKqLo5ZgdgNtFlckPutVdeA74HCrpHmC7TYQvcNevk30u2DTRK9TZaDKFyI7 xC6qwk68o6o4JHqTNqlU2mLQqh8uxf8LRmnYk5zV9GlmPM5VjubjKyV9KdxE+nANP1ZD NsD5PMwwe7dUdOCm0rb2pmsTaXGp5Nk5yXQUMHUG6BK+Z+TksS2E461feNfbSrfXALP8 Rz902eaCTIXAcvVXpV/tVjmG1sHaEM0xwwvX/2sB/AbxRexjvq2QW+G9VwV9fU6fldZR O2Xg== X-Forwarded-Encrypted: i=1; AHgh+Ro91nEwpF+tWynsznIZToiFnrDM7lFfNDaaOSqRPU2JIVu6a2kfbCnmNudyecscydaok6nt8B2Xgb0LiKA=@vger.kernel.org X-Gm-Message-State: AOJu0YxJwt5/Klnea/d/L2bPzPgBNx/FVdLUlTrQ4swueViW8mIexnuP c+VHJH/EkPz6vwnjILbho2cDE4VlSjwEzjQ27xUBEANaiCG2vF+iVvbqx2wjL+lagDWYCo2Zh9B xO/SvXDIuDvtzKxkZB3GyeW9LmAGjDQIykM1M0J59hPP/c0MMifNqLOZDsm5BH9gwT/8= X-Gm-Gg: AfdE7clx8qRIb4G+g6yOCCOD1OIdXfa4aS7aXxWCYBGMjpY5ye6AG2/BdMd/LTnVr6j pjXEdSCysEAxNGPAwVZXDeP4fCbX1IL25i3xg7W2QldcDxtihpeX/UOOsOV5SGaTg9O+WfyAPfB rIunFqVttgkCghZhRt8o5J95Y+QTUTDGFu1hhp7yIKXmr9b5Yok1UAWmCfzBHbh8XMsW+FvCIY1 an0boubga+jFTL0LwNk+j6ShHu0PFjAHl+Y8OWpicPioYOnFeEcMPEyd8uY2VN+igjqFg2DiYP3 ZRFv4BQrxilLiJqmIYa0u9kIJf19caO4Co6TUUxVa6rdgRIjezIa3J2UVd8llNQPlovClSpop0b stDwO78srMf8e03HuO8XcLZEfTzqhc8wOa9r8G+MyNvpNz6XfApWH0xkwmfuCjvoijKOokm6Fqf 4= X-Received: by 2002:aa7:9315:0:b0:847:888f:9b0f with SMTP id d2e1a72fcca58-847bf944a63mr1320511b3a.15.1782910499771; Wed, 01 Jul 2026 05:54:59 -0700 (PDT) X-Received: by 2002:aa7:9315:0:b0:847:888f:9b0f with SMTP id d2e1a72fcca58-847bf944a63mr1320474b3a.15.1782910499241; Wed, 01 Jul 2026 05:54:59 -0700 (PDT) Received: from [10.133.33.29] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-847a02cdfb7sm4008598b3a.39.2026.07.01.05.54.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2026 05:54:58 -0700 (PDT) Message-ID: Date: Wed, 1 Jul 2026 20:54:50 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/5] dt-bindings: arm: coresight-tnoc: Add standalone qcom,coresight-agtnoc compatible To: Konrad Dybcio , Krzysztof Kozlowski Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Tingwei Zhang , Jingyi Wang , Abel Vesa , Suzuki K Poulose , Mike Leach , James Clark , Leo Yan , Yuanfang Zhang , Abel Vesa , Alexander Shishkin , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org References: <20260701-fix-tracenoc-probe-issue-v4-0-aefab449a470@oss.qualcomm.com> <20260701-fix-tracenoc-probe-issue-v4-1-aefab449a470@oss.qualcomm.com> <20260701-stirring-piculet-of-vastness-a361e5@quoll> <4117c406-0d75-4eb1-842e-1d346b7fbf99@oss.qualcomm.com> <9aa63427-ba41-436d-ab19-a533082d336a@kernel.org> <62ac6887-1551-490b-b42b-2661d7152734@oss.qualcomm.com> <7838f7c3-0f38-4e93-a9c1-88f387e78ca9@oss.qualcomm.com> Content-Language: en-US From: Jie Gan In-Reply-To: <7838f7c3-0f38-4e93-a9c1-88f387e78ca9@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: DHLQQcp6Jno1qLWjOdW_EgsLULuWEvzZ X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAxMDEzNSBTYWx0ZWRfX9AuBKVcKrSK3 H4Y9r2IL7aVcC/1M76N94QFNliXCr6yiVWs2OhOKR4gmVFv6SlldRwkGueJ8wWZP5rN8blKmD+Y Yv37YJU2nNvgrw8FTYTdoNikIc9iSek= X-Authority-Analysis: v=2.4 cv=JKgLdcKb c=1 sm=1 tr=0 ts=6a450e24 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=i5S6TmXcA3_pwKZvcRIA:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-GUID: DHLQQcp6Jno1qLWjOdW_EgsLULuWEvzZ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAxMDEzNSBTYWx0ZWRfX5ArvcgHO0HQE HD152VF/X1HZF5m8BjqOgHHwYkIjsSc5INXnu2sLDWRDGQkClrHrGXiJBlhMnTIUunomBFbJ6W4 8LObz2LG16M0akx1qBlnxOiEgm6vCs5ulKYEqUMFwnq3Fq4ckqJv1BualFwtPSlNFRAwlfve8ag CmeKmXnO1agbon34k5LczLCCgyi4ZzK/GHr277s+qVzDqS0+oF2w0YauXey7LENHCT/3hjUHWL/ ArFvDfyMnFAWR8Znd/GGr957oIFtn3Q18wDd5JMbzwbt5XijcKri1h716jKvy6wNGtdvy0RILdO ID5mRJk0YIwt45AwPrzvzdLJjkdFZgBkS1UxDJ6R0b870hrLsph8Vz1UYbMBDSLpiPoM4YwMwqD lWNlRS8gyCVXE9Be5l7nQX9ksNE4wT4zFJBhg8aztC2kCJZGnFc7n0pi+WeJxaJNSaOoi+pIVE1 tFVLEZm0ES0q/6xwQhQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-01_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 priorityscore=1501 suspectscore=0 clxscore=1015 malwarescore=0 impostorscore=0 adultscore=0 phishscore=0 spamscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607010135 On 7/1/2026 7:02 PM, Konrad Dybcio wrote: > On 7/1/26 9:31 AM, Jie Gan wrote: >> >> >> On 7/1/2026 3:26 PM, Krzysztof Kozlowski wrote: >>> On 01/07/2026 09:16, Jie Gan wrote: >>>> >>>> >>>> On 7/1/2026 2:57 PM, Krzysztof Kozlowski wrote: >>>>> On Wed, Jul 01, 2026 at 09:53:41AM +0800, Jie Gan wrote: >>>>>> The TNOC compatible previously only allowed the two-string AMBA form >>>>>> "qcom,coresight-tnoc", "arm,primecell", which forces the device onto the >>>>>> AMBA bus. >>>>>> >>>>>> Convert the compatible to a oneOf and add a standalone >>>>>> "qcom,coresight-agtnoc" compatible alongside the existing AMBA form. The >>>>>> standalone string carries no "arm,primecell" entry, so the device is >>>>>> created on the platform bus instead of the AMBA bus. > > [...] > >>>> AMBA primecell identification. The purpose of the new compatible is to >>>> clearly distinguish this platform-specific case from the standard >>>> AMBA-based implementation. Or shall I re-use the existing compatible >>>> "qcom,coresight-tnoc" as platform standalone compatible? >>>> >>>> We already have a similar pattern for the interconnect TraceNoC device, >>>> which uses the platform-specific compatible string qcom,coresight-itnoc. >>> I do not see there a fake, duplicated compatible for the same device. >>> Can you elaborate how is that relevant? >> >> Will fix it by removing AMBA related description. >> >> Shall I update the clock name from apb_pclk to apb as a platform device? > > Why? For the previous platform devices, we got comments to add the clock-name with "apb" instead of "apb_pclk". Please check the qcom,coresight-ctcu.yaml and qcom,coresight-itnoc.yaml Thanks, Jie > > Konrad