From: Paolo Bonzini <pbonzini@redhat.com>
To: Sean Christopherson <sean.j.christopherson@intel.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] KVM: x86: use CPUID to locate host page table reserved bits
Date: Wed, 4 Dec 2019 16:36:16 +0100 [thread overview]
Message-ID: <d46bd0a8-5743-4665-85ea-14351fd85cdd@redhat.com> (raw)
In-Reply-To: <20191204152942.GB6323@linux.intel.com>
On 04/12/19 16:29, Sean Christopherson wrote:
>
> The extra bit of paranoia doesn't cost much, so play it safe? E.g.:
>
> if (unlikely(boot_cpu_data.extended_cpuid_level < 0x80000008)) {
> WARN_ON_ONCE(boot_cpu_has(X86_FEATURE_TME) || SME?);
> return boot_cpu_data.x86_phys_bits;
> }
>
> return cpuid_eax(0x80000008) & 0xff;
Sounds good. I wouldn't bother with the WARN even.
Paolo
next prev parent reply other threads:[~2019-12-04 15:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-04 14:51 Paolo Bonzini
2019-12-04 15:29 ` Sean Christopherson
2019-12-04 15:36 ` Paolo Bonzini [this message]
2019-12-11 16:36 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d46bd0a8-5743-4665-85ea-14351fd85cdd@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sean.j.christopherson@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®