From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932211AbdGKCOI (ORCPT ); Mon, 10 Jul 2017 22:14:08 -0400 Received: from merlin.infradead.org ([205.233.59.134]:47902 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932144AbdGKCOH (ORCPT ); Mon, 10 Jul 2017 22:14:07 -0400 Subject: Re: [patches] Re: [PATCH 01/17] lib: Add shared copies of some GCC library routines To: Palmer Dabbelt Cc: sfr@canb.auug.org.au, yamada.masahiro@socionext.com, mmarek@suse.com, will.deacon@arm.com, peterz@infradead.org, boqun.feng@gmail.com, mingo@redhat.com, daniel.lezcano@linaro.org, tglx@linutronix.de, jason@lakedaemon.net, marc.zyngier@arm.com, gregkh@linuxfoundation.org, jslaby@suse.com, davem@davemloft.net, mchehab@kernel.org, fweisbec@gmail.com, viro@zeniv.linux.org.uk, mcgrof@kernel.org, dledford@redhat.com, bart.vanassche@sandisk.com, sstabellini@kernel.org, daniel.vetter@ffwll.ch, mpe@ellerman.id.au, msalter@redhat.com, nicolas.dichtel@6wind.com, james.hogan@imgtec.com, paul.gortmaker@windriver.com, linux@roeck-us.net, heiko.carstens@de.ibm.com, schwidefsky@de.ibm.com, linux-kernel@vger.kernel.org, patches@groups.riscv.org, akpm@linux-foundation.org, albert@sifive.com References: From: Randy Dunlap Message-ID: Date: Mon, 10 Jul 2017 19:13:55 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/10/2017 07:09 PM, Palmer Dabbelt wrote: > On Mon, 10 Jul 2017 19:03:44 PDT (-0700), rdunlap@infradead.org wrote: >> On 07/10/2017 07:02 PM, Stephen Rothwell wrote: >>> Hi Palmer, >>> >>> On Mon, 10 Jul 2017 18:39:08 -0700 Palmer Dabbelt wrote: >>>> >>>> This patch adds a new copy of these library routine files, which are >>>> functionally identical to the various other copies. These are >>>> availiable via Kconfig as CONFIG_LIB_$ROUTINE, which currently isn't >>> >>> Umm, the patch actually uses CONFIG_GENERIC_$ROUTINE. >>> >>>> +config GENERIC_ASHLDI3 >>>> + def_bool n >>> >>> Just >>> bool >>> is the same. >>> >> >> and several "default n" lines can (should) be removed from Kconfig. > > I'm not much of a Kconfig hacker... How does this look? > Looks good. Thanks. > commit 4aaad1e6e8a70020dd95b8a13a4075af97cb858f > Author: Palmer Dabbelt > Date: Mon Jul 10 19:07:43 2017 -0700 > > lib: Remove "default n" lines from Kconfig > > These lines aren't necessary, as the default is "n" anyway. > > Signed-off-by: Palmer Dabbelt > > diff --git a/lib/Kconfig b/lib/Kconfig > index ee7d8bf0b7e1..78dec2408481 100644 > --- a/lib/Kconfig > +++ b/lib/Kconfig > @@ -15,7 +15,6 @@ config BITREVERSE > > config HAVE_ARCH_BITREVERSE > bool > - default n > depends on BITREVERSE > help > This option enables the use of hardware bit-reversal instructions on > @@ -48,7 +47,6 @@ config GENERIC_IOMAP > > config GENERIC_IO > bool > - default n > > config STMP_DEVICE > bool > @@ -199,7 +197,6 @@ config AUDIT_GENERIC > > config AUDIT_ARCH_COMPAT_GENERIC > bool > - default n > > config AUDIT_COMPAT_GENERIC > bool > @@ -208,7 +205,6 @@ config AUDIT_COMPAT_GENERIC > > config RANDOM32_SELFTEST > bool "PRNG perform self test on init" > - default n > help > This option enables the 32 bit PRNG library functions to perform a > self test on initialization. > @@ -405,12 +401,10 @@ config HAS_DMA > config DMA_NOOP_OPS > bool > depends on HAS_DMA && (!64BIT || ARCH_DMA_ADDR_T_64BIT) > - default n > > config DMA_VIRT_OPS > bool > depends on HAS_DMA && (!64BIT || ARCH_DMA_ADDR_T_64BIT) > - default n > > config CHECK_SIGNATURE > bool > -- ~Randy