From: "Martin Tůma" <tumic@gpxsee.org>
To: Arnd Bergmann <arnd@kernel.org>,
Martin Tuma <martin.tuma@digiteqautomotive.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Ricardo Ribalda <ribalda@chromium.org>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: pci: mgb4: include linux/errno.h
Date: Fri, 7 Mar 2025 19:27:16 +0100 [thread overview]
Message-ID: <d46f9862-ecb2-4e8c-86de-7dcc31bb77d1@gpxsee.org> (raw)
In-Reply-To: <20250307102431.73506-1-arnd@kernel.org>
On 07. 03. 25 11:24 dop., Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The errno.h header is not always included indirectly, leading
> to rare randconfig build warnings.
>
> drivers/media/pci/mgb4/mgb4_regs.c:20:11: error: use of undeclared identifier 'EINVAL'
> 20 | return -EINVAL;
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/media/pci/mgb4/mgb4_regs.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/pci/mgb4/mgb4_regs.c b/drivers/media/pci/mgb4/mgb4_regs.c
> index 31befd722d72..b45537dbfafa 100644
> --- a/drivers/media/pci/mgb4/mgb4_regs.c
> +++ b/drivers/media/pci/mgb4/mgb4_regs.c
> @@ -5,6 +5,7 @@
> */
>
> #include <linux/ioport.h>
> +#include <linux/errno.h>
> #include "mgb4_regs.h"
>
> int mgb4_regs_map(struct resource *res, struct mgb4_regs *regs)
Acked-by: Martin Tůma <martin.tuma@digiteqautomotive.com>
prev parent reply other threads:[~2025-03-07 18:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-07 10:24 Arnd Bergmann
2025-03-07 18:27 ` Martin Tůma [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d46f9862-ecb2-4e8c-86de-7dcc31bb77d1@gpxsee.org \
--to=tumic@gpxsee.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=martin.tuma@digiteqautomotive.com \
--cc=mchehab@kernel.org \
--cc=ribalda@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®