From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FAF1C388F7 for ; Tue, 10 Nov 2020 21:40:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BCBCF207D3 for ; Tue, 10 Nov 2020 21:40:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="TIJINkyM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731900AbgKJVg6 (ORCPT ); Tue, 10 Nov 2020 16:36:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726467AbgKJVg6 (ORCPT ); Tue, 10 Nov 2020 16:36:58 -0500 Received: from mail-il1-x143.google.com (mail-il1-x143.google.com [IPv6:2607:f8b0:4864:20::143]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A565C0613D3 for ; Tue, 10 Nov 2020 13:36:58 -0800 (PST) Received: by mail-il1-x143.google.com with SMTP id y17so13648107ilg.4 for ; Tue, 10 Nov 2020 13:36:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=7BM4+zzNWaE6TirCtLLYoQ9tppsE0QS4r3dvLHZsJ2Y=; b=TIJINkyMPlkffs9/+dOX6vGvoGglpDShCvG8w3RFc3lqyqbJ3NE9/t6GzJZHx3L6AT TUAbpyBqZ19xWo3q9M8uYllRuoQCEQyk1dwTRYUmQxltCH9oVKluHxyJpaGSulClCUfK w3Pu9Z8gjBZnbAL5eLXZrnejOMK0oxzqKND9c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7BM4+zzNWaE6TirCtLLYoQ9tppsE0QS4r3dvLHZsJ2Y=; b=BRu6NiqkqlaHGsTWFl5ZNONiZ2vslpiO1Zx5EMIQSwk9oOQe+Gq8c34h5eQ2GtSuIw TPejmzMXHlqPs8jL991l5+SrWfmixeACe7/l6itJBBofqxYexUAK4mDgYnyZKPxkhi8S PtrG9xsDYR3IQE+f04G3hQZ10VVRi28UML1kQNo8TUUVy3mXNxv4qDtBvC+Pr2fwN/8v 9aCM5OIGG2xEZOYrqsIEQXKqyVddworvVPdTvtukkqDAlgr8dbMTReQFFcSq3pkUNaxT Eu521t1DA1qoG0PxdGDHZMtbV9nrE/vQpaw85ft2IR1fb500yQgRcVeTGx4yRJK0yTE3 eqJg== X-Gm-Message-State: AOAM532swZHQbjFGABQ5I79WAolnvpZoIBSq5V0R+mL9cq6sYZl3ZrG4 4oj+mwnJpxZMb+XE/KDTFtRG+g== X-Google-Smtp-Source: ABdhPJyqj8WvPEO1P5u7sS0mUX+V0R+C3ezUg05U2S8qWDrIq/NQa1vuEKLQOS+Srmek8japJaQj/A== X-Received: by 2002:a92:5204:: with SMTP id g4mr15477146ilb.91.1605044217564; Tue, 10 Nov 2020 13:36:57 -0800 (PST) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id c80sm10181792ill.20.2020.11.10.13.36.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Nov 2020 13:36:57 -0800 (PST) Subject: Re: [PATCH] selftests/seccomp: Update kernel config To: =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= , Kees Cook , Shuah Khan Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Tycho Andersen , =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= , Shuah Khan References: <20201030121819.764395-1-mic@digikod.net> From: Shuah Khan Message-ID: Date: Tue, 10 Nov 2020 14:36:56 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.2 MIME-Version: 1.0 In-Reply-To: <20201030121819.764395-1-mic@digikod.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/30/20 6:18 AM, Mickaël Salaün wrote: > seccomp_bpf.c uses unshare(CLONE_NEWPID), which requires CONFIG_PID_NS > to be set. > > Cc: Kees Cook > Cc: Shuah Khan > Cc: Tycho Andersen > Fixes: 6a21cc50f0c7 ("seccomp: add a return code to trap to userspace") > Signed-off-by: Mickaël Salaün > --- > tools/testing/selftests/seccomp/config | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/testing/selftests/seccomp/config b/tools/testing/selftests/seccomp/config > index 64c19d8eba79..ad431a5178fb 100644 > --- a/tools/testing/selftests/seccomp/config > +++ b/tools/testing/selftests/seccomp/config > @@ -1,3 +1,4 @@ > +CONFIG_PID_NS=y > CONFIG_SECCOMP=y > CONFIG_SECCOMP_FILTER=y > CONFIG_USER_NS=y > > base-commit: 3650b228f83adda7e5ee532e2b90429c03f7b9ec > Your from and Signed-off-by don't match. Please send the patch from your igned-off-by address. WARNING: From:/Signed-off-by: email address mismatch: 'From: "Mickaël Salaün" ' != 'Signed-off-by: Mickaël Salaün ' thanks, -- Shuah