From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32B03C18E5B for ; Tue, 10 Mar 2020 23:10:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DD8872071B for ; Tue, 10 Mar 2020 23:10:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cloud.ionos.com header.i=@cloud.ionos.com header.b="AFnM8/qV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727806AbgCJXKH (ORCPT ); Tue, 10 Mar 2020 19:10:07 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:41803 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727588AbgCJXKH (ORCPT ); Tue, 10 Mar 2020 19:10:07 -0400 Received: by mail-ed1-f67.google.com with SMTP id m25so490750edq.8 for ; Tue, 10 Mar 2020 16:10:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.ionos.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ZjzfLVKcrEVYs6WhxkjJMrt4JgyDW89UP2lOPu52OFg=; b=AFnM8/qVZ5INpBhagP0TzCOiNgkxgenab2JvoMJ9TochGwwsyROWvjIewmaXHDUmar l+T11XTf3Z5/Ln3tLw8rQzmHYyAEoebfFfwlJsw4tdw5dINkokIRH6NS2P54C8D6wCSe ws5FELqRVVqhVPNU17Zok/L7q8FpBv0xeV2Yx/a7IwZ+YYOXOhMa8eTAabzdA20EG7IY J84WyBNSEyA/7FhPiNt9Zcn8JPOOzmRwoHz4R7hn1NRoq0KTMVjRHrmh0e6pxHuZgivu ZZqYfgk18R1hF/eFxnc6c5j6COc0wlMKtMCm0st1cu2neOcTZro4+BlqXr2NtmU9v/Vs 2n4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ZjzfLVKcrEVYs6WhxkjJMrt4JgyDW89UP2lOPu52OFg=; b=Vn45SZI67ou8UKI+h7kReN11H9/X3NOT52sFCZaGzEQft5ObkKQ0c7yVhAVdRDygTO lVf+YjsPbxPqkWg8//2LNJ1nDeAR9eLf3kkfE15BVzYMTB6BSYi5AACkyKB5xAMQtPQe GEUD0IjZyGcm3SQpbBL0Cvdi/3Lv9C0c/kOIoHazE51rxbSwheCT8RZVmAuMwInnJJyg oM8lV7XRqqPkHD1EC4r9jvxp8b4GKR1hMOt2PfXFLoK6UFjIQJcAHeju/Z1FSvDlNuUb VHCyd4m9RGrTr66JjGa7ptcU3aeZUCHKO2E41lQgCV2k63THvYKn4i7WnxDngFNX7AVf k4ww== X-Gm-Message-State: ANhLgQ1udWCXMLOloj8AFtue9XcGd1CcBA3JhCqzPSdxl6FXNqgww665 bXbHHAWsjGBy53ZDiVZsF0PrJQ== X-Google-Smtp-Source: ADFU+vuw/QrLgknOBSnLL6UEPd5ZmG0mMBAvF0lDukG/ngJ9XGt+BMvhR1Vfo0DVxEJ2jx46GiOIfQ== X-Received: by 2002:a05:6402:549:: with SMTP id i9mr174325edx.323.1583881805877; Tue, 10 Mar 2020 16:10:05 -0700 (PDT) Received: from ?IPv6:2001:16b8:4849:2c00:55b0:6e1e:26ab:27a5? ([2001:16b8:4849:2c00:55b0:6e1e:26ab:27a5]) by smtp.gmail.com with ESMTPSA id h22sm3715651eds.88.2020.03.10.16.10.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Mar 2020 16:10:05 -0700 (PDT) Subject: Re: [PATCH v2] block: refactor duplicated macros To: Matteo Croce , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org, xen-devel@lists.xenproject.org, linux-scsi@vger.kernel.org, linux-nfs@vger.kernel.org Cc: Jens Axboe , "James E.J. Bottomley" , Ulf Hansson , Anna Schumaker , Dan Williams , Song Liu References: <20200310223516.102758-1-mcroce@redhat.com> From: Guoqing Jiang Message-ID: Date: Wed, 11 Mar 2020 00:10:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200310223516.102758-1-mcroce@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/10/20 11:35 PM, Matteo Croce wrote: > +++ b/drivers/md/raid1.c > @@ -2129,7 +2129,7 @@ static void process_checks(struct r1bio *r1_bio) > int vcnt; > > /* Fix variable parts of all bios */ > - vcnt = (r1_bio->sectors + PAGE_SIZE / 512 - 1) >> (PAGE_SHIFT - 9); > + vcnt = (r1_bio->sectors + PAGE_SECTORS - 1) >> (PAGE_SHIFT - 9); Maybe replace "PAGE_SHIFT - 9" with "PAGE_SECTORS_SHIFT" too. Thanks, Guoqing