mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tanmay Shah <tanmay.shah@amd.com>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: <andersson@kernel.org>, <mst@redhat.com>, <jasowang@redhat.com>,
	<xuanzhuo@linux.alibaba.com>, <eperezma@redhat.com>,
	<linux-kernel@vger.kernel.org>,
	<linux-remoteproc@vger.kernel.org>,
	<virtualization@lists.linux.dev>, <xiaoxiang@xiaomi.com>
Subject: Re: [RFC PATCH 0/2] Enhance RPMsg buffer management
Date: Wed, 17 Dec 2025 16:20:33 -0600	[thread overview]
Message-ID: <d4733fde-b1de-4852-9c75-c1c7e1896a9e@amd.com> (raw)
In-Reply-To: <aUMhLc9fe5inQN7X@p14s>



On 12/17/25 3:31 PM, Mathieu Poirier wrote:
> On Fri, Nov 14, 2025 at 10:46:38AM -0800, Tanmay Shah wrote:
>> Take rx and tx buffer size from virtio device config space in the
>> resource table. This allows each firmware to configure RPMsg buffer size
>> as needed in each direction.
>>
>> Original seris:
>> https://lore.kernel.org/all/1548949280-31794-1-git-send-email-xiaoxiang@xiaomi.com/
>>
>> Following modificaitons are done to the original series:
>>   - Separate dma allocation is not done for tx and rx buffers. Instead
>>     allocated chunk of memory is split between tx and rx buffers.
>>   - If vdev doesn't support VIRTIO_RPMSG_F_BUFSZ feature then use the 
>>     default size of 512 bytes for buffers
>>   - Change MAX_RPMSG_BUF_SIZE to DEFAULT_RPMSG_BUF_SIZE
>>   - move virtio_rpmsg.h from uapi to linux dir
>>   - RPMsg buffer size must be set to hold rpmsg header at minimum in the
>>     vdev config space of the firmware.
>>   - align total buf size to page size when allocating and deallocating
>>     memory
>>
>> Xiang Xiao (2):
>>   rpmsg: virtio_rpmsg_bus: allow the different vring size for send/recv
>>   rpmsg: virtio_rpmsg_bus: get buffer size from config space
>>
>>  drivers/rpmsg/virtio_rpmsg_bus.c | 105 ++++++++++++++++++++-----------
>>  include/linux/virtio_rpmsg.h     |  24 +++++++
>>  2 files changed, 93 insertions(+), 36 deletions(-)
>>  create mode 100644 include/linux/virtio_rpmsg.h
>>
> 
> This set is going somewhere.  Please address the comments that were received and
> send a new revision.
> 
> Apologies for the long review delay.
> Mathieu
>  

Sure Mathieu, no problem. I will be on leave in the January, and will start
working on this patch series once I come back.

Thanks,
Tanmay

>>
>> base-commit: f982fbb1a6ca3553c15763ad9eb2beeae78d3684
>> -- 
>> 2.34.1
>>


      reply	other threads:[~2025-12-17 22:20 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-14 18:46 Tanmay Shah
2025-11-14 18:46 ` [RFC PATCH 1/2] rpmsg: virtio_rpmsg_bus: allow the different vring size for send/recv Tanmay Shah
2025-11-21  9:40   ` Arnaud POULIQUEN
2025-12-03 17:38     ` Tanmay Shah
2025-12-17 20:58   ` Mathieu Poirier
2025-11-14 18:46 ` [RFC PATCH 2/2] rpmsg: virtio_rpmsg_bus: get buffer size from config space Tanmay Shah
2025-11-21  9:44   ` Arnaud POULIQUEN
2025-12-03 18:00     ` Tanmay Shah
2025-11-22 12:05   ` Zhongqiu Han
2025-12-03 18:12     ` Tanmay Shah
2025-12-03 19:35       ` Michael S. Tsirkin
2025-12-04 16:55         ` Tanmay Shah
2025-12-16 22:45           ` Mathieu Poirier
2025-12-05 16:01       ` Arnaud POULIQUEN
2025-12-16 22:43         ` Mathieu Poirier
2025-12-17 21:31 ` [RFC PATCH 0/2] Enhance RPMsg buffer management Mathieu Poirier
2025-12-17 22:20   ` Tanmay Shah [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d4733fde-b1de-4852-9c75-c1c7e1896a9e@amd.com \
    --to=tanmay.shah@amd.com \
    --cc=andersson@kernel.org \
    --cc=eperezma@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=mst@redhat.com \
    --cc=virtualization@lists.linux.dev \
    --cc=xiaoxiang@xiaomi.com \
    --cc=xuanzhuo@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome