From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from GVXPR05CU001.outbound.protection.outlook.com (mail-swedencentralazon11023113.outbound.protection.outlook.com [52.101.83.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D7692EDD6C for ; Fri, 10 Jul 2026 16:15:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.83.113 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783700138; cv=fail; b=o4s9t0DrV+Cz3W8bMDKrVFWO7UGx9XBDfqhIXChCeiyDHf9uwlbuvRAU+ckKUZQxNxmwozgT4+Ywqd1TFUMfdiidHWN/fvHExvh9yAa1IbyBOkDuihBL3gYxOV3QpJ7T2jvQR/ufVEFx6YAwMYnIZ55JA+Ih6GgPIs3NOsgzoMA= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783700138; c=relaxed/simple; bh=xHzF2JbJZbJqkZYVSFDr91+YmKqVQ02IeO9suWbEIzw=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=tXIJ9OxIZon0QZCYFr5L8T9yeLcG0q1AsDeND2+Ka0MAYfmVONFOHunpdNQLNWLoNK4SjZ4UKiSVqfB8Qp2NWWY54KrjDD/ocqNxyqxz0qVj7fgcrg5xXj0fL/h9Z2kSjbjAsCQ/I2j4WZyP6B8DxVcKFPT/iUKhfi5kyaWDq4g= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=virtuozzo.com; spf=pass smtp.mailfrom=virtuozzo.com; dkim=pass (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b=R3/VXqN1; arc=fail smtp.client-ip=52.101.83.113 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=virtuozzo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=virtuozzo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="R3/VXqN1" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=zBPYtC9f1KNlPSsO5hUCAsZtNV9BIGA0kKC+g1iCsQqZ9WAg2xOaAHlpghuahMlGK3swYtFr4lK5TxMbNxG9B/c+lZug7cHMzyLfv/h3uE4n5I2zTLTkQ1VR/MZkPl+mU3nTQdm0jvr/J7reYyxCMdfmqlvuZ73ZeTdtAolzuPFvc/K2d4+c0+GTsHSFT/9dMWPcdRsVOeEUEBRzG3dqPgwebL1Go8k4zajOKvzpDIHL8js1si1wejBAoFClvViGFcyZFbKdqe7w+ZXCYMnJfHqkl7X7Vt4uXaKIuF6d5agdH7XS/xO1KOed9HU+gaIl2ejjg0FPKp0pa3yrkr1YbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dXGli3VNjJ38gYrjqqdAhwQxrbo6Dj0svXV0FOsTRUg=; b=DoILQ9SPDAU+IpNcFnDavK9/512m9D2LRA8FocJ2eL8xXFZJlTZniBv3jv3A9KXCFVN7wCSpFYxlzwg8Swuc+1zJPvYkdnrp2y4L3Amqzjf4g6GihOQ3UpidvWpvZUsicJ+kJK+2KQGJBFNOMS670juAhMzT83gYq3MssQFHm0EPGslLeu3QEARN8t9LPmfdNrpxjQdQ0Kpc0+1WmoH3Fb5JbSOaylS+7QUKkUk6JNhaVQZFwzYKu3pBC8S4mdbqus1aiX/3kzmNj5lhpPf3ozL97IhG6pQE1JGzCA92dVTiFIrGLTfvk6UXP9i65aw1gfEohyTo2P0KkAGYFa3G6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dXGli3VNjJ38gYrjqqdAhwQxrbo6Dj0svXV0FOsTRUg=; b=R3/VXqN1pArfW/qBxNGBAww998rv6vVuu+p0YRPSOB8vhru/52ILQeDB9g7pySykJxEAnoYvbUCrjVWdTwqeJymFOEmy98Gt8s7q7cvKWJNEDXi96Xn55a7rClqFCWw/PSaRUGQ6JYGJPFY8mlYy02f1T2gAoithiPJ0k9rX+ohx/fdsCVjImVBeV46eHn+eYZWC1fEeGjejJTw5ueRyqDsNl9uMEdUKTnUTnIf0zgQoQFKoHTK9KguF0iNK4cfR5xplfjONlsWEjCXucJrYTiOWOIqAg3dnveL2sndt4+cmc6G7w3vPFmVBkbGEL5iYD9uGANqCukhwrEnoB0Go3w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from AM9PR08MB5892.eurprd08.prod.outlook.com (2603:10a6:20b:2dd::16) by DB9PR08MB8359.eurprd08.prod.outlook.com (2603:10a6:10:3d9::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.15; Fri, 10 Jul 2026 16:15:30 +0000 Received: from AM9PR08MB5892.eurprd08.prod.outlook.com ([fe80::94bb:633f:1f55:4bbd]) by AM9PR08MB5892.eurprd08.prod.outlook.com ([fe80::94bb:633f:1f55:4bbd%2]) with mapi id 15.21.0181.016; Fri, 10 Jul 2026 16:15:30 +0000 Message-ID: Date: Fri, 10 Jul 2026 18:15:28 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86/mm/pat: take cpa_lock around large-page collapse To: "Denis V. Lunev" , Dave Hansen , Andy Lutomirski , Peter Zijlstra , x86@kernel.org Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , "Mike Rapoport (Microsoft)" , Juergen Gross , Kiryl Shutsemau , linux-kernel@vger.kernel.org References: <20260626163213.2284080-1-den@openvz.org> Content-Language: en-US From: "Denis V. Lunev" In-Reply-To: <20260626163213.2284080-1-den@openvz.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: VI1PR09CA0123.eurprd09.prod.outlook.com (2603:10a6:803:78::46) To AM9PR08MB5892.eurprd08.prod.outlook.com (2603:10a6:20b:2dd::16) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM9PR08MB5892:EE_|DB9PR08MB8359:EE_ X-MS-Office365-Filtering-Correlation-Id: be82cb33-af6e-4aa8-5613-08dede9e7600 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|7416014|366016|10070799003|23010399003|5023799004|56012099006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: +BkVT3cJeJ2+CSATvs4/qVQOhUjrUcZCpiOZouBPChNBKmUxtpQF/0Ms9UAf7OwISCmuVPNRYzrrax1+XSsuDMYv1YU0t8aA6iVMkh6NfTptRIfrnLidpnIB0yvXKgSeRpYdHA+PWSzDZc+1caUu9U+P0c6ds2RN0p/wgVw80E7QutijtA+7/0zPVXbYjlWlRivntQlm+nbbijAxp32QpH1wpE1UyRbka+AUmemr7lS+mAKnZiJeQ9PlBZ7oYlebMJiNKIpLjD8bqHxQ32aS1Ocj/5INobqFk9TwS+YN3uMTExowS5/p+xSqbyFSP76d8+PaSbQlyiwAyudhdTpHG/iFuFv31ypW+ncpE18iL1ngvfJZ0G8WiQ4HpurZnNvOyF0+xsUk63NQGwosud1kVSibti8zTugX912HmBOlnuAOJSQ1BQXgDe7wRhbgD1JICMyY2hEoEKxWQHOggU8tNOh1Z/rvxe7f0+c6ZF5un+aQCILQtFflH+QAPVkiQva11aH7E9Hv+CyCHZg1TUgPX22hawf3x/Pq+1oW/BnPS0v2kPcP2KwH+kHz/kOrRSHzQ4SukDwxkInjIa8cP69VQgMyV2/ajXAYucZdSmJa7y0yJ0icpsvj6+ub5p1FEWwG119kApbCicUoejL2gZGcDXXortuim5js+mjeNSHeRhs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM9PR08MB5892.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(7416014)(366016)(10070799003)(23010399003)(5023799004)(56012099006)(18002099003)(22082099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZGhKcWFCYVhyVGhaR1BVMGxPZFlFL2M0aEZLdndxY2pjdlVJMTZ4YndMUEZa?= =?utf-8?B?dWhwdk1LcmZuYU93NkRQaWVCWm0zNmJSZmd1anUrd1N0bTNpMVQ0OEJqSWNX?= =?utf-8?B?WURpV2o1Z0pDYTZ0ekhpR242RzZLbU5WdVA0VFppUkhTbnNkYkZ5emlpMHN6?= =?utf-8?B?NjVrWjhiaG9nTXppYktnMzZDdTFwYjcyUjRZbjVVVWpGNUdhV3ZtSmp2T2dr?= =?utf-8?B?STdwdWRRZUpQSTZnQk5DaUlRWW5NSlh0NktzY0lZdjl2Nk1xQ1QvaE01SGZl?= =?utf-8?B?SDVPeURuYmQ0dW5EWnRiKzRmTW94K1lBRWFZUWdvczZuam5pd0pWSk93eWtS?= =?utf-8?B?OEFNdHNQUUkzdldYM1BDYlZVR0RKczFSaHBzRnlKY1JuRG5ZOVR4cjdyZmNa?= =?utf-8?B?THVZWG9yU3pTNmVWVFBPbkVYZ3FyNnFZYkxSM2krWmEyQmphM1QrVmV5dm5T?= =?utf-8?B?OHk1ZUt0RndVOElCdjVmR2pSUGM5bVd2V3N2dllrdGtNSEUxUUJ5ejJFcThC?= =?utf-8?B?d2hadjNFN3JpcldQUXlrRTZuQ3RCSG1PVCt4aWhPVVAxWXlRNXBzaEk1OWFW?= =?utf-8?B?aytIUXdhcUUvRUhCdmpDdnlrbTVwa1F1YmVPQ1ZWUE5BNEFRaDUrV1BNVXZX?= =?utf-8?B?MjZXZjZWSm5aMkh5VUJzNkZDcldaUG11MDRST3pCOHV5WmZFMGFHOFJHMzU4?= =?utf-8?B?WlhzcnVhbkJqVjkrTnc2RUI1M2FwNlBPTFFyY0ZSeWpVL1NNSS9XQTRWWFhS?= =?utf-8?B?S0kvd3QyQml2d1lmeXRGVjVsOWQyNEs1L21JTUtXV0Q0QzRMU0ZUMmtZNUpk?= =?utf-8?B?bWhQYkhMdTNUSnRHeFQ2ZDViSTBKcUZ3c0hTVVAvVlBBZHVickxDZmlNbUJj?= =?utf-8?B?MnJSZjhJVkptWGFWblZnSktsRUVuWDAxUXNnRGR4aE10K3NhcUpuU1pJSHpU?= =?utf-8?B?YTBUbWR0Zlhva2Z6bkRjV200TWw4S2NVWTN3MTR2ZXVsL3lnQldPbkZUdFlQ?= =?utf-8?B?QnhFSUxJZEw4UDFRYXdMUDdrUklnL3RpWUF2MmJIZk1IUjdKRmUvekFWR05t?= =?utf-8?B?UmYyYmpJRjBhUVdnMEJvRDFMUS9mZ2MxWERnU0hoL3FSanRjcU5PcWRPWXo0?= =?utf-8?B?QjBBM3RLMUtoeW9rNjZaRXZyQlhUd0ZVZWlKRTQyV0REZFZBU1hyVUNKMUQ4?= =?utf-8?B?SDl5NGNBdG9OWGlZdnZwOVZkb2s0V0NHVHRTS3E4eHc1ZXVNbDhjNGJMSTJi?= =?utf-8?B?L1FvdGFnYld6QVNXK0loZ2pBd1h2RTFCcXdRY2VpeWpQZE12ZjdtbGFGUUpI?= =?utf-8?B?N1Z3RlNrd0RFRkhPSmFVNUhNRkE3U2hNYU5LcGpWSkprL3VQMzl2UVBmcGNX?= =?utf-8?B?TTYrL3ZrUzRkK1FBcTl5cVdrSElaRzFQdkluQlhOc0RNeTJPYTh6Y2ZLOFdO?= =?utf-8?B?S1I5TDRFMG5lQjB1RmRydGVUVnhhTkhlT3o1cG1iR1piZ0V0V1VheW1RS2tU?= =?utf-8?B?SXdnVU54QVlFNzZCZlBpTWI5V1IrN3FsSmw4K2xwcHVhRDJZNW1pSWwrczRZ?= =?utf-8?B?SkF4RENVWEFQODdrVU5oNUtCK1JLTzF0MEdZYWxCd2JuelRDSlEyazZUUGNK?= =?utf-8?B?VXhkcy9BZlhJWkw1ai9ITGs0TmR5OHJuUzN5d1pNbFhDNDRScDVUSVMxNkNn?= =?utf-8?B?L0hNRmFpeW85anpYOVZQSnk0bVhvaTBGT3JXT0dRY3pCZnZRSXVZRSttZkdV?= =?utf-8?B?NURrMlFIdEU1VUo0RlMwbDFlUXhRMXVBUHpzOFlGTzBFWmNtK1gvRkVUbCtF?= =?utf-8?B?OTdIRUZPNjk4c01vRGdQNXEzQW9zeTN1dWMraTFYVXFLZTFMa2s2dnpWMnQy?= =?utf-8?B?cHcwbk1Hb2sxZWtkNG5QVEJodGJHdEZ4MEdrNEw2ZXo5MGlZNTJMQ3BzTHNS?= =?utf-8?B?dUJOdjUrL1FxQlRoTzE5SHFvajd1djltWitmYjc0RmNkaVdIZGNPSzRnWmd4?= =?utf-8?B?bGYza3EzWlJwbEZ0K0twL3VMWTYxbWZnSWh0T005aktPcW5STXdPN2FBK1RL?= =?utf-8?B?R0FEUHo4ZkFnTjBYaFZXYkVxTkxIQkJCZHA0UnpzeWxaT2h0WHAwcnJXMnRl?= =?utf-8?B?b0xMRVhMM21kSG5BOGhHNjQrazlFd1J3UjBhOExBTU41Zld4Znd1ck1OTzFL?= =?utf-8?B?aUhIU2FJUVZpUmxwUzRPc0ZXd1hDV0FKS2ZXRE9ZV0g2dFRaeTJYUzZnUVBo?= =?utf-8?B?Y3ErTkFBNTBuaHpSdXM2WVVFSE1CT2tSbWZva1Qva012eDdtQ2RGVEpOSWpY?= =?utf-8?B?cnd1UFNuVWJONmZwbDJMODlVUFBhVzFRR3dqZGhFRG02dk5lNW91UnhMQkZk?= =?utf-8?Q?x8sVXva1ngSAFk/uoCer0dDNZYOKqql398jL+YZcHzQ9m?= X-MS-Exchange-AntiSpam-MessageData-1: 7dH938YxzTS8gQ== X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: be82cb33-af6e-4aa8-5613-08dede9e7600 X-MS-Exchange-CrossTenant-AuthSource: AM9PR08MB5892.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2026 16:15:30.0286 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BFfJM9DM/8P7w0yxU95oDembZSspZqiCxjOlQDfQ/PBII0qVoAhq1xo34w4JezCgMVKSD5t1QDSqlGdOWtQB6g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB8359 On 6/26/26 18:32, Denis V. Lunev wrote: > This email originated from an IP that might not be authorized by the domain it was sent from. > Do not click links or open attachments unless it is an email you expected to receive. > Loading and unloading modules concurrently on several CPUs on a KASAN > build, with a short delay injected at the CPA page-table lookup to > widen the window, faults within minutes: > > BUG: KASAN: use-after-free in __change_page_attr+0x7cc/0x7e0 > Write of size 8 at addr ffff888181139718 by task modprobe > ... > The buggy address belongs to the physical page: > pfn:0x181139 ... page_type: f2(table) > > cpa_collapse_large_pages() rebuilds a leaf PMD from its 4K PTEs and > frees the old PTE-table pages, while __change_page_attr() fetches a > PTE pointer from a lockless lookup_address_in_pgd_attr() and writes > it with set_pte_atomic() only later. When module text is served from > a shared large ROX mapping the two run on the same PMD: > > CPU A (module load) CPU B (module finalize) > ------------------- ----------------------- > execmem_make_temp_rw > set_memory_nx > __change_page_attr > split 2M -> 4K table P > kpte = &P[i] (lockless) > execmem_restore_rox > set_memory_rox (CPA_COLLAPSE) > cpa_collapse_large_pages > rebuild leaf PMD > flush_tlb_all > pagetable_free(P) > set_pte_atomic(kpte, ...) > -> writes into freed P > > P is a page-table page (page_type: table), reused at once, so the > write corrupts whatever got the page next: a bad-pte or bad-page > splat, or a fatal fault once P has been turned into read-only text. > > The flush_tlb_all() before the free does not close this: its IPI only > serializes against page-table walkers that run with interrupts off > (e.g. GUP-fast); the walk in __change_page_attr() runs with interrupts > on, so nothing stops it from holding a stale pointer into P. > > Serialize the collapse - the PMD rebuild, TLB flush and PTE-table > free - under cpa_lock, the lock __change_page_attr() takes for the > split path, so a concurrent walker can no longer hold a pointer into > a table the collapse is about to free. > > debug_pagealloc bypasses cpa_lock in __change_page_attr() (the direct > map is 4K then, with no large pages to serialize), so the lock cannot > order the two there. Skip the collapse in that config: it is only an > optimization, and not freeing the tables leaves the unserialized walk > nothing to race. > > Fixes: 41d88484c71c ("x86/mm/pat: restore large ROX pages after fragmentation") > Signed-off-by: Denis V. Lunev > --- > arch/x86/mm/pat/set_memory.c | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) > > diff --git a/arch/x86/mm/pat/set_memory.c b/arch/x86/mm/pat/set_memory.c > index d023a40a1e03..ff6e3f612986 100644 > --- a/arch/x86/mm/pat/set_memory.c > +++ b/arch/x86/mm/pat/set_memory.c > @@ -418,6 +418,16 @@ static void cpa_collapse_large_pages(struct cpa_data *cpa) > int collapsed = 0; > int i; > > + /* > + * debug_pagealloc bypasses cpa_lock, so __change_page_attr() walks > + * unserialized and freeing collapsed PTE-tables could race it; skip > + * the optional merge there. > + */ > + if (debug_pagealloc_enabled()) > + return; > + > + spin_lock(&cpa_lock); > + > if (cpa->flags & (CPA_PAGES_ARRAY | CPA_ARRAY)) { > for (i = 0; i < cpa->numpages; i++) > collapsed += collapse_large_pages(__cpa_addr(cpa, i), > @@ -431,8 +441,10 @@ static void cpa_collapse_large_pages(struct cpa_data *cpa) > collapsed += collapse_large_pages(addr, &pgtables); > } > > - if (!collapsed) > + if (!collapsed) { > + spin_unlock(&cpa_lock); > return; > + } > > flush_tlb_all(); > > @@ -440,6 +452,8 @@ static void cpa_collapse_large_pages(struct cpa_data *cpa) > list_del(&ptdesc->pt_list); > pagetable_free(ptdesc); > } > + > + spin_unlock(&cpa_lock); > } > > static void cpa_flush(struct cpa_data *cpa, int cache) > > base-commit: b81d185839fade27f7c4e885856696cf497d53c1 ping v2