From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Maarten Zanders <maarten.zanders@mind.be>,
Pavel Machek <pavel@ucw.cz>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: leds-lp55xx: add ti,disable-charge-pump
Date: Wed, 2 Nov 2022 12:19:25 -0400 [thread overview]
Message-ID: <d475d80b-37b5-29ee-4a5d-dee8c4083834@linaro.org> (raw)
In-Reply-To: <7cbb1cc5-e333-db25-77e2-7a1ebda70e24@mind.be>
On 29/10/2022 03:48, Maarten Zanders wrote:
>
> On 10/29/22 00:07, Krzysztof Kozlowski wrote:
>> Drop |
> OK.
>>> + Disable the internal charge pump.
>> Does it mean that it is enabled by default?
>
> The device default after reset is "off".
> The current implementation sets it to "auto".
> Other possible modes are "bypass" and "boost".
>
> Should I change to an optional "ti,charge_pump_mode" as string and set
> default to "auto"?
enum makes more sense in that case. Just don't user underscores in
property names.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-02 16:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 13:34 [PATCH 0/2] leds: lp55xx: support disabling the charge pump Maarten Zanders
2022-10-28 13:34 ` [PATCH 1/2] dt-bindings: leds-lp55xx: add ti,disable-charge-pump Maarten Zanders
2022-10-28 22:07 ` Krzysztof Kozlowski
2022-10-29 7:48 ` Maarten Zanders
2022-11-02 16:19 ` Krzysztof Kozlowski [this message]
2022-10-28 13:34 ` [PATCH 2/2] leds: lp55xx: add option to disable charge pump Maarten Zanders
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d475d80b-37b5-29ee-4a5d-dee8c4083834@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=maarten.zanders@mind.be \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®