mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: icenowy@aosc.io
To: Maxime Ripard <maxime.ripard@free-electrons.com>,
	Chen-Yu Tsai <wens@csie.org>
Cc: linux-sunxi@googlegroups.com, Priit Laes <plaes@plaes.org>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH v4 1/3] clk: sunxi-ng: div: Add support for fixed post-divider
Date: Sun, 13 Aug 2017 10:50:40 +0800	[thread overview]
Message-ID: <d47777b1acaae095020697fa7c2064ac@aosc.io> (raw)
In-Reply-To: <20170812124352.24148-2-icenowy@aosc.io>

在 2017-08-12 20:43,Icenowy Zheng 写道:
> From: Priit Laes <plaes@plaes.org>
> 
> SATA clock on sun4i/sun7i is of type (parent) / M / 6 where
> 6 is fixed post-divider.
> 
> Signed-off-by: Priit Laes <plaes@plaes.org>

Signed-off-by: Icenowy Zheng <icenowy@aosc.io>

> ---
> It's based on the patch in v6 of the A10/A20 CCU patchset, but with
> ccu_div_round_rate fixed.
> 
>  drivers/clk/sunxi-ng/ccu_div.c | 22 +++++++++++++++++++---
>  drivers/clk/sunxi-ng/ccu_div.h |  3 ++-
>  2 files changed, 21 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/clk/sunxi-ng/ccu_div.c 
> b/drivers/clk/sunxi-ng/ccu_div.c
> index c0e5c10d0091..baa3cf96507b 100644
> --- a/drivers/clk/sunxi-ng/ccu_div.c
> +++ b/drivers/clk/sunxi-ng/ccu_div.c
> @@ -21,10 +21,18 @@ static unsigned long ccu_div_round_rate(struct
> ccu_mux_internal *mux,
>  {
>  	struct ccu_div *cd = data;
> 
> -	return divider_round_rate_parent(&cd->common.hw, parent,
> +	if (cd->common.features & CCU_FEATURE_FIXED_POSTDIV)
> +		rate *= cd->fixed_post_div;
> +
> +	rate = divider_round_rate_parent(&cd->common.hw, parent,
>  					 rate, parent_rate,
>  					 cd->div.table, cd->div.width,
>  					 cd->div.flags);
> +
> +	if (cd->common.features & CCU_FEATURE_FIXED_POSTDIV)
> +		rate /= cd->fixed_post_div;
> +
> +	return rate;
>  }
> 
>  static void ccu_div_disable(struct clk_hw *hw)
> @@ -62,8 +70,13 @@ static unsigned long ccu_div_recalc_rate(struct 
> clk_hw *hw,
>  	parent_rate = ccu_mux_helper_apply_prediv(&cd->common, &cd->mux, -1,
>  						  parent_rate);
> 
> -	return divider_recalc_rate(hw, parent_rate, val, cd->div.table,
> -				   cd->div.flags);
> +	val = divider_recalc_rate(hw, parent_rate, val, cd->div.table,
> +				  cd->div.flags);
> +
> +	if (cd->common.features & CCU_FEATURE_FIXED_POSTDIV)
> +		val /= cd->fixed_post_div;
> +
> +	return val;
>  }
> 
>  static int ccu_div_determine_rate(struct clk_hw *hw,
> @@ -86,6 +99,9 @@ static int ccu_div_set_rate(struct clk_hw *hw,
> unsigned long rate,
>  	parent_rate = ccu_mux_helper_apply_prediv(&cd->common, &cd->mux, -1,
>  						  parent_rate);
> 
> +	if (cd->common.features & CCU_FEATURE_FIXED_POSTDIV)
> +		rate *= cd->fixed_post_div;
> +
>  	val = divider_get_val(rate, parent_rate, cd->div.table, 
> cd->div.width,
>  			      cd->div.flags);
> 
> diff --git a/drivers/clk/sunxi-ng/ccu_div.h 
> b/drivers/clk/sunxi-ng/ccu_div.h
> index 08d074451204..f3a5028dcd14 100644
> --- a/drivers/clk/sunxi-ng/ccu_div.h
> +++ b/drivers/clk/sunxi-ng/ccu_div.h
> @@ -86,9 +86,10 @@ struct ccu_div_internal {
>  struct ccu_div {
>  	u32			enable;
> 
> -	struct ccu_div_internal		div;
> +	struct ccu_div_internal	div;
>  	struct ccu_mux_internal	mux;
>  	struct ccu_common	common;
> +	unsigned int		fixed_post_div;
>  };
> 
>  #define SUNXI_CCU_DIV_TABLE_WITH_GATE(_struct, _name, _parent, _reg,	\

  parent reply	other threads:[~2017-08-13  2:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-12 12:43 [PATCH v4 0/3] Allwinner R40 CCU driver Icenowy Zheng
2017-08-12 12:43 ` [PATCH v4 1/3] clk: sunxi-ng: div: Add support for fixed post-divider Icenowy Zheng
2017-08-12 12:49   ` icenowy
2017-08-13  2:50   ` icenowy [this message]
2017-08-14 14:37     ` [linux-sunxi] " Chen-Yu Tsai
2017-08-12 12:43 ` [PATCH v4 2/3] clk: sunxi-ng: nkm: add " Icenowy Zheng
2017-08-14 14:46   ` [linux-sunxi] " Chen-Yu Tsai
2017-08-12 12:43 ` [PATCH v4 3/3] clk: sunxi-ng: support R40 SoC Icenowy Zheng
2017-08-14 16:12   ` Chen-Yu Tsai
2017-08-14 16:53     ` icenowy
2017-08-15  2:16       ` [linux-sunxi] " Chen-Yu Tsai
2017-08-15  2:26         ` icenowy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d47777b1acaae095020697fa7c2064ac@aosc.io \
    --to=icenowy@aosc.io \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=maxime.ripard@free-electrons.com \
    --cc=plaes@plaes.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®