From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754968AbdGSOvG (ORCPT <rfc822;w@1wt.eu>);
        Wed, 19 Jul 2017 10:51:06 -0400
Received: from mx2.suse.de ([195.135.220.15]:35832 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1754774AbdGSOvF (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 19 Jul 2017 10:51:05 -0400
Subject: Re: [PATCH v2] xen: xen-pciback: remove DRIVER_ATTR() usage
To: Greg KH <gregkh@linuxfoundation.org>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
References: <20170719125817.GD17776@kroah.com>
 <20170719144344.GA10632@kroah.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <d47a6490-a06f-aca1-3392-a12149471ecc@suse.com>
Date: Wed, 19 Jul 2017 16:51:02 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <20170719144344.GA10632@kroah.com>
Content-Type: text/plain; charset=utf-8
Content-Language: de-DE
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 19/07/17 16:43, Greg KH wrote:
> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> It's better to be explicit and use the DRIVER_ATTR_RW() and
> DRIVER_ATTR_RO() macros when defining a driver's sysfs file.
> 
> Bonus is this fixes up a checkpatch.pl warning.
> 
> This is part of a series to drop DRIVER_ATTR() from the tree entirely.
> 
> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Cc: Juergen Gross <jgross@suse.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Reviewed-by: Juergen Gross <jgross@suse.com>

I'll take this through the Xen tree, unless you want to use your tree.


Thanks,

Juergen