From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 834C3233927 for ; Mon, 13 Jul 2026 16:55:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783961758; cv=none; b=sERcwJPC81LHNOEFfIw0AOW84il7+gf47iTlfCUGxH4Ub0mPBbau+S5Fldv+LHyaKmTL0+v/D9qFE76c4KTWhz7BscghCiM8nAtRBZk1U8VuD8ogN8472HcJHjnbospkcKsYb1ja2k3bsqagFhTcjfjE/a1WdUbatdARwn1Ydh4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783961758; c=relaxed/simple; bh=3N0ABRarTdfq54f1BH3wC39dBAKNrx/Lg+8U/uI7/mg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iPzA5VyRNQ2L6OZrR2c3uiwQ/X3ENQLJRO3YFC68izDmpv5gP9+0V5vOJDIqn6xwnTSvpTFsLv18nWQE9QSA280l/KMSmxPyDNeqFFa0CEh7ZzWof5nEVglfrJbKJNODEfRq2Dy7pw7SwRoJZPfCImz53FuQGk9ENWorf2S3sNI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=VqQgExBO; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=b3UsKqdY; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="VqQgExBO"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="b3UsKqdY" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66DG5GnK2030798 for ; Mon, 13 Jul 2026 16:55:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= e2l5AlR95TaD7LKI1gelB+DwJJ4uQc1DBAVxbTpujtI=; b=VqQgExBO2ziP4XXl LxBo0E/0b747DcAle8B0dbc0WkvL8drMvHnEqh9Q3gKBKfaTEIrPCNGMpkaTfEKB OVeY064Nx3a2PkiqsMVVaSePwnK0TQx9YHyCCi/TH7304L0xolX1Sp7deLkiBSK/ 7IJEg+ktDj0SdU01Q8zOFAR/zgbO4b0dQDtEwnBgdylwbzLYYxMDe+DE4IGCFudl S9IbOmNEhUlzMR+0N4w73ZCboDFyUcKTBU606dlc4pMHKt6ryRpH942izoXhvxcO 4ut/aWwQxIsEYbzmQqrGnQDRvK5+linr2e7qpo6Qr88VHyTWra/6QvpYT0Vq8mfw Zlx+qQ== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fd37x872a-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 13 Jul 2026 16:55:55 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-38d7fcd1f66so5046261a91.2 for ; Mon, 13 Jul 2026 09:55:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783961755; x=1784566555; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=e2l5AlR95TaD7LKI1gelB+DwJJ4uQc1DBAVxbTpujtI=; b=b3UsKqdYy2TjBiShZaJzrBoCJgI+hyWRfaR+xe/87Kem74jAzuiFkSeKeJmzTmmGl+ 4VX2Y3dcPVi0uPM9mSBAUtz6sN7qdksrUFZTd2F+GpUXY1Ton1tpLcDgWqc1huL5Zyl9 05hQjr9mu2qxnsxG7hKY9ZIqlMTa+V/KY47oCoAkyyqlKwDsVM8IiPKWS/TRmnPKQfA+ vvdMnL1VfybOyhexBaGoD5gIiJqHU2IDTLGtxvfK/xgLI9lv/0wih7A0fPX6bq9XJXSU D4i8Wr4C+EHEFvFyX7fjGz1+ZzRH63C6tmZMXeLAjbuJItQX5dWFMSPO5iESiHsu4Yme 8WOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783961755; x=1784566555; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=e2l5AlR95TaD7LKI1gelB+DwJJ4uQc1DBAVxbTpujtI=; b=lNsLKmntUU9/ustRiTvBJB4jLQRTxtCo59WPrhuYW3T60GM+Vz/Y+AAeLTG4H+iMX3 VuqYtGcOxhRi7BbGFuNj3WY0qh1qa7+Q8pfcYcHF5cbodnLNiCev9oeNcawOqQqZbfza joX4a5tFYV27Ir84kP4nJcFfngOPu/CITyw6EwDyh+tD0Tv4NZbPBYopWS+bQsMfSni2 9ubXoN8MLaxeg+l/+K/mHOSL+dU7t9NuM3QP8QE9JKxMuzQTqJ3c7NaI1vVef8bmIkDP 5h2ND7HzuLJ6S8SzssclVv155pdr6/PhHFQ2C6MS2crfIrhsNYZ07cNC4c3MewXjRzLd FrbA== X-Forwarded-Encrypted: i=1; AHgh+RptaaJom6mrphiGoBetbI1p3ax8QHyxrridbkAhn4tXYUKM1Dl3dUZnI34nBDo4C39rmNm3d122rRY/WbQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxRMjB451pkm56bL0+ta6ntLoW4pfOEQEsfX80AoBbQnPIDBZ2L nLGNGFhnI3i7RiObOUBJM8Elz0DZ4gJ4bVwIREhErkM8fSnksLLOWMp5TkX1mTDP0VqCD9m+n8p s+ZYMLAKs859GmeCuTR8ngD3Xfa0AJfsfFOtHAUjQNh1ul2C0GyWXC7WTmyw2S58UQM0= X-Gm-Gg: AfdE7cmvvE3+YKffUucLSTszWQSanDK7K/kWbpbiP6SAqKHcx69Oo40/sf7DMR5Z0E2 tt8kUn7+E4lGvNeS06awUSjToxzkzOhKbVBeYLL9X4UeNyGPWjtr9MumtCid1iTi1v8hGL7Kxdm Kag6ZUPoWvX7XeILzNB4RRPKwgiZEZpMQmJbMS4XG/yEEQ1BZlxkrF0bfoUU7NJ+9Sd+vSEhovP tPWHPydpyOwdmEHC+RqtbXuEzXwVJAoKE4jxGgermlccxVZ590SIHeIOLm2Blorl10QRJYjdoNC Z2p0xy1p/dckV1l1tmoMjAXj2/0JTD+sslg9kPjCi/j6RwGg8lLL4WUMmmbwP6acD/1ZC+8Jj1O Gdu3mjvYvlmccVjKtvQ5b5qlzxyTJjLvYmWlEH1IJTvxikw== X-Received: by 2002:a17:90b:2750:b0:37c:18e0:90dc with SMTP id 98e67ed59e1d1-38dc75ebea3mr9509029a91.16.1783961754977; Mon, 13 Jul 2026 09:55:54 -0700 (PDT) X-Received: by 2002:a17:90b:2750:b0:37c:18e0:90dc with SMTP id 98e67ed59e1d1-38dc75ebea3mr9508992a91.16.1783961754510; Mon, 13 Jul 2026 09:55:54 -0700 (PDT) Received: from [192.168.1.100] ([157.48.180.168]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3117d847e17sm71653953eec.18.2026.07.13.09.55.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jul 2026 09:55:54 -0700 (PDT) Message-ID: Date: Mon, 13 Jul 2026 22:25:43 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/3] iio: adc: qcom-spmi-adc5-gen3: Remove an unnecessary print To: Andy Shevchenko Cc: Jonathan Cameron , David Lechner , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Amit Kucheria , Thara Gopinath , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , linux-arm-msm@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Kamal Wadhwa , David Collins , Anjelique Melendez , Neil Armstrong , Stephan Gerhold References: <20260705-gen3_adc_tm-v3-0-ac62f387dbce@oss.qualcomm.com> <20260705-gen3_adc_tm-v3-2-ac62f387dbce@oss.qualcomm.com> Content-Language: en-US From: Jishnu Prakash In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzEzMDE3NSBTYWx0ZWRfX4yEiJVm3wjsI GSGBIHKocBoAPsV9IPF9TbLqmcHk+7Qs0GgYkYs4RtCkxCKyCzAs4zoJn1ZyZ5QB0JAiKTsA4MJ Ew4LFCVBfC8/YxWn4oT5LCrkaiEf28dh/fDJ0gejqNS/N5dex8fvfsGSzAz1buEbQpdn99Ausd5 KksEXTKktvBYBDFOnbKDvSOHzu9mgqZZOEyNXLv0Dpw/ejYtWjQLSlIjl988jrBnhA6hJjP+rSs q8T0tWtsYEOCAESeR9tzgfq8XGlGnjqBC2Aok7O7sC3Rd4263Xv9N1VnKhlLyCEXChBHbem61sT RPlQA8rGabGUd3o6EA/ZnU6gWiGXZxh9URe01Yx0plp2iCPgdZoOItptzWJ72PEK9f15p/lF9V6 yxITBFtgd4EXrmpQ0MnGmSxhwtUzvV0gySISTkua5KjQObkRhuSzZTp6Y4PfoHCGQ54x+i9+moc +vywBQqg/PniHtAd4ew== X-Authority-Analysis: v=2.4 cv=BNWDalQG c=1 sm=1 tr=0 ts=6a55189b cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=62VzjLAzdHZQ3L95IMgkXw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=QyXUC8HyAAAA:8 a=aSuIdP_MvOpnUHuhdBcA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-ORIG-GUID: Wh7MQsikJNS-e95Wt9UfH9pNJXfRrCa5 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzEzMDE3NSBTYWx0ZWRfX/XHCdx0R4MPv rVrTXX6nDVrLSgP/wh+O/B2rZrvRTb1Xi9LEDcZuTxN3jCPoP7t1VossyFMD4IkC9z5Ms2AtXvn NGrwXDkGrLW+fEsVvIFv/l1rMv3FcMg= X-Proofpoint-GUID: Wh7MQsikJNS-e95Wt9UfH9pNJXfRrCa5 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-13_04,2026-07-10_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 phishscore=0 priorityscore=1501 malwarescore=0 clxscore=1015 bulkscore=0 lowpriorityscore=0 adultscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607130175 Hi Andy, On 7/6/2026 11:14 AM, Andy Shevchenko wrote: > On Sun, Jul 05, 2026 at 10:23:34PM +0530, Jishnu Prakash wrote: >> devm_request_threaded_irq internally prints an error message using > > devm_request_threaded_irq() > >> dev_err_probe in case of any errors. Remove the error print in the > > dev_err_probe() > >> devm_request_threaded_irq failure path as it is not needed. > devm_request_threaded_irq() > > This patch should go first. The patch 1 is not marked as a fix and we don't > need this message to be printed even before the patch 1 of your current version > of the series. > > With that being addressed, > Reviewed-by: Andy Shevchenko > Sure, I'll put this patch first and fix the function names when pushing the next series. I'll also add the Suggested-by tag as you mentioned in another mail. Thanks, Jishnu > Also note we refer to the functions as func(), id est mind the parentheses. >