From: Tang Yizhou <tangyizhou@huawei.com>
To: <peterz@infradead.org>, <mingo@redhat.com>,
<vincent.guittot@linaro.org>, <dietmar.eggemann@arm.com>,
<corbet@lwn.net>
Cc: <linux-kernel@vger.kernel.org>, <linux-doc@vger.kernel.org>,
<zhengbin13@huawei.com>, <tangyeechou@gmail.com>
Subject: Re: [PATCH] docs: scheduler: Fix outdated parameter of rebalance_domains
Date: Mon, 10 Jan 2022 20:38:04 +0800 [thread overview]
Message-ID: <d48506d2-91bb-7d40-12c1-5c16ad89916a@huawei.com> (raw)
In-Reply-To: <20211221031818.23186-1-tangyizhou@huawei.com>
Friendly ping.
Any feedback?
On 2021/12/21 11:18, Tang Yizhou wrote:
> According to the function prototype of rebalance_domains(), its first
> parameter is *rq* and the document need to be updated.
>
> Signed-off-by: Tang Yizhou <tangyizhou@huawei.com>
> ---
> Documentation/scheduler/sched-domains.rst | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/scheduler/sched-domains.rst b/Documentation/scheduler/sched-domains.rst
> index 84dcdcd2911c..e57ad28301bd 100644
> --- a/Documentation/scheduler/sched-domains.rst
> +++ b/Documentation/scheduler/sched-domains.rst
> @@ -37,10 +37,10 @@ rebalancing event for the current runqueue has arrived. The actual load
> balancing workhorse, run_rebalance_domains()->rebalance_domains(), is then run
> in softirq context (SCHED_SOFTIRQ).
>
> -The latter function takes two arguments: the current CPU and whether it was idle
> -at the time the scheduler_tick() happened and iterates over all sched domains
> -our CPU is on, starting from its base domain and going up the ->parent chain.
> -While doing that, it checks to see if the current domain has exhausted its
> +The latter function takes two arguments: the runqueue of current CPU and whether
> +the CPU was idle at the time the scheduler_tick() happened and iterates over all
> +sched domains our CPU is on, starting from its base domain and going up the ->parent
> +chain. While doing that, it checks to see if the current domain has exhausted its
> rebalance interval. If so, it runs load_balance() on that domain. It then checks
> the parent sched_domain (if it exists), and the parent of the parent and so
> forth.
>
next prev parent reply other threads:[~2022-01-10 12:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-21 3:18 Tang Yizhou
2022-01-10 12:38 ` Tang Yizhou [this message]
2022-02-01 23:30 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d48506d2-91bb-7d40-12c1-5c16ad89916a@huawei.com \
--to=tangyizhou@huawei.com \
--cc=corbet@lwn.net \
--cc=dietmar.eggemann@arm.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tangyeechou@gmail.com \
--cc=vincent.guittot@linaro.org \
--cc=zhengbin13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®