From: Tejun Heo <tj@kernel.org>
To: Ridong Chen <ridong.chen@linux.dev>
Cc: "Waiman Long" <longman@redhat.com>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Michal Koutný" <mkoutny@suse.com>,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
"Ridong Chen" <chenridong@xiaomi.com>
Subject: Re: [PATCH next] cgroup/cpuset: Move cpuset_update_flag() to cpuset-v1.c
Date: Wed, 30 Sep 2026 14:10:20 -1000 [thread overview]
Message-ID: <d4863576d83e373b00ecf9899b00dc73@kernel.org> (raw)
In-Reply-To: <20260930023139.495964-1-ridong.chen@linux.dev>
On Wed, Sep 30, 2026 at 10:31:39AM +0800, Ridong Chen wrote:
> From: Ridong Chen <chenridong@xiaomi.com>
>
> cpuset_update_flag() is only used by the legacy (v1) interface: its
> callers are the write handlers of cpuset1_files via cpuset_write_u64(),
> and cpuset_css_offline() which invokes it only on the legacy hierarchy
> (!cpuset_v2() && is_sched_load_balance()).
>
> Move it, together with its sole helper cpuset1_update_tasks_flags(),
> into cpuset-v1.c so both can go back to being static and drop out of
> cpuset-internal.h.
Applied to cgroup/for-7.4 with the description tweaked to say that
cpuset1_update_tasks_flags() already lives in cpuset-v1.c.
Thanks.
--
tejun
prev parent reply other threads:[~2026-10-01 0:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 2:31 Ridong Chen
2026-09-30 3:07 ` Waiman Long
2026-10-01 0:10 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4863576d83e373b00ecf9899b00dc73@kernel.org \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=chenridong@xiaomi.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mkoutny@suse.com \
--cc=ridong.chen@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®