From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFB50C433B4 for ; Sun, 25 Apr 2021 06:22:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9805E61285 for ; Sun, 25 Apr 2021 06:22:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229660AbhDYGVY (ORCPT ); Sun, 25 Apr 2021 02:21:24 -0400 Received: from out30-133.freemail.mail.aliyun.com ([115.124.30.133]:47968 "EHLO out30-133.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229522AbhDYGVY (ORCPT ); Sun, 25 Apr 2021 02:21:24 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R101e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04420;MF=joseph.qi@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0UWeubQZ_1619331642; Received: from B-D1K7ML85-0059.local(mailfrom:joseph.qi@linux.alibaba.com fp:SMTPD_---0UWeubQZ_1619331642) by smtp.aliyun-inc.com(127.0.0.1); Sun, 25 Apr 2021 14:20:42 +0800 Subject: Re: [PATCH] ocfs2: Remove repeated uptodate check for buffer To: Wan Jiabing , Mark Fasheh , Joel Becker , ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org, akpm Cc: kael_w@yeah.net References: <20210425025702.13628-1-wanjiabing@vivo.com> From: Joseph Qi Message-ID: Date: Sun, 25 Apr 2021 14:20:42 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210425025702.13628-1-wanjiabing@vivo.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/25/21 10:57 AM, Wan Jiabing wrote: > In commit 60f91826ca62 ("buffer: Avoid setting buffer bits that are > already set"), function set_buffer_##name was added a test_bit() to > check buffer, which is the same as function buffer_##name. > The !buffer_uptodate(bh) here is a repeated check. Remove it. > > Signed-off-by: Wan Jiabing Looks good. Reviewed-by: Joseph Qi > --- > fs/ocfs2/aops.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/ocfs2/aops.c b/fs/ocfs2/aops.c > index ad20403b383f..bd039fdbb27e 100644 > --- a/fs/ocfs2/aops.c > +++ b/fs/ocfs2/aops.c > @@ -634,8 +634,7 @@ int ocfs2_map_page_blocks(struct page *page, u64 *p_blkno, > } > > if (PageUptodate(page)) { > - if (!buffer_uptodate(bh)) > - set_buffer_uptodate(bh); > + set_buffer_uptodate(bh); > } else if (!buffer_uptodate(bh) && !buffer_delay(bh) && > !buffer_new(bh) && > ocfs2_should_read_blk(inode, page, block_start) && >