From: David Ahern <dsahern@gmail.com>
To: 禹舟键 <ufo19890607@gmail.com>, "Jiri Olsa" <jolsa@redhat.com>
Cc: peterz@infradead.org, mingo@redhat.com,
alexander.shishkin@linux.intel.com, jolsa@kernel.org,
namhyung@kernel.org, Milian Wolff <milian.wolff@kdab.com>,
Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
Wind Yu <yuzhoujian@didichuxing.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] Add a new element for the struct perf_tool, and add the --per-event-dump option for perf script
Date: Mon, 25 Sep 2017 20:44:26 -0600 [thread overview]
Message-ID: <d48e0922-2d17-b975-a116-5d51bddc026a@gmail.com> (raw)
In-Reply-To: <CAHCio2hkYkgqiMEaz=miTDGNvDwR89xVPvJWBw_3kkB42gUTNQ@mail.gmail.com>
On 9/25/17 8:41 PM, 禹舟键 wrote:
> The changelogs are in the cover-letter.
> changes in v2:
> - remove the set of script.tool.per_event_dump variable.
> - add the __maybe_unused attribute for the fp argument in the
> second patch.
> - remove the fp_selection_helper function for setting the fp
> argument.
> - split the original second patch(Makes all those related
> functions receive the FILE pointer) to two patches.
> - modify the file name of per-event-dump to <ORIGINAL PERF DATA
> FILE NAME>-script-dump-<EVENT NAME>.txt
Each patch should have a single focus and a changelog describing what is
changed and why. Impacts to the user experience should have example output.
next prev parent reply other threads:[~2017-09-26 2:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-24 11:12 [PATCH v2 0/4] perf script: Add script per-event-dump support yuzhoujian
2017-09-24 11:12 ` [PATCH v2 1/4] Add a new element for the struct perf_tool, and add the --per-event-dump option for perf script yuzhoujian
2017-09-25 12:56 ` Jiri Olsa
[not found] ` <CAHCio2hkYkgqiMEaz=miTDGNvDwR89xVPvJWBw_3kkB42gUTNQ@mail.gmail.com>
2017-09-26 2:44 ` David Ahern [this message]
2017-09-24 11:12 ` [PATCH v2 2/4] Add fp argument to print functions yuzhoujian
2017-09-24 11:12 ` [PATCH v2 3/4] Replace printf with fprintf for all " yuzhoujian
2017-09-24 11:12 ` [PATCH v2 4/4] Make all print functions receive the fp argument, and opens a dump file in process_event yuzhoujian
-- strict thread matches above, loose matches on Subject: below --
2017-09-26 6:48 [PATCH v2 0/4] perf script: Add script per-event-dump support yuzhoujian
2017-09-26 6:48 ` [PATCH v2 1/4] Add a new element for the struct perf_tool, and add the --per-event-dump option for perf script yuzhoujian
2017-09-24 3:37 [PATCH v2 0/4] perf script: Add script per-event-dump support yuzhoujian
2017-09-24 3:37 ` [PATCH v2 1/4] Add a new element for the struct perf_tool, and add the --per-event-dump option for perf script yuzhoujian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d48e0922-2d17-b975-a116-5d51bddc026a@gmail.com \
--to=dsahern@gmail.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=arnaldo.melo@gmail.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=milian.wolff@kdab.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=ufo19890607@gmail.com \
--cc=yuzhoujian@didichuxing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome