From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A02948167A for ; Fri, 7 Aug 2026 13:05:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786107944; cv=none; b=Cbjazx/+DTMGXXk29TWtDndRty8DZL9zMmXj09DEVDbptAMeWJHx6D5oVai/lF/6ZJL0A0XJp/eFClghHeK/cqDAEzLKNJDEIQDnZhC7Tiv/LXn2monbL9QQJu+dtRN7AQJbksQ724quZesS7z9e3O7HUP37gzyJG5wQzTpgg4w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786107944; c=relaxed/simple; bh=HYxymFoJm6RTuaDqJ7cRBG+V1mDHMjPSgSeI7t5ZWK4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=C0VwOkcNxJdU8UevGaUT31Ul5xx03vN44BgCyOxstjDNFEVDb18Vory7ZDa1Eqf/bQ0PN3tO+/vMXcOjIgXACr99Oay8pswP+AI6xFDBTB6lxSF1sv1DDvx3a4a9UrZoaNoN2p6+0hxk7yJueRWhqvS5ej5kce2OcqxnBcaJzsM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Gv9eNFme; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=gzNc3zst; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Gv9eNFme"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="gzNc3zst" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 677CgMDJ1294625 for ; Fri, 7 Aug 2026 13:05:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= zPSj/US9YmoirR4APoqZkFkgfkruTVQ3Bn0PlYTwpLo=; b=Gv9eNFme9NRtsz64 WtQXMjIWbpJKt2IURqnywaVa1kqIKm8HVzxpy9TIH3+XxGH2rb9gYjT4onAqPnTh BkYxZrKZXJG7aLH7w8qhyyYki3/4kGRnjiVfgdZo2AwEKdazFKGKT9PIbc96zMGL uYet+/wowckoYnQluPWFzeCnXCduzT//yRMTczEBeaejfSg9PkzXxOq23c0Haxcr u1Dz9FJTFtX/I7eoJn25l8CFNKgfU59I7PyLjRys92HxhB9sqD1ecAZCkozaIxOG OnKGAuXsVwAdz4UILFnGaV0nntXBVQ15MEkl+E/AJXagzfN855hwmrYGih3+RnSX adpABQ== Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fvy6gv272-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 07 Aug 2026 13:05:29 +0000 (GMT) Received: by mail-vk1-f198.google.com with SMTP id 71dfb90a1353d-5c2ae99c28cso467983e0c.3 for ; Fri, 07 Aug 2026 06:05:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786107929; x=1786712729; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=zPSj/US9YmoirR4APoqZkFkgfkruTVQ3Bn0PlYTwpLo=; b=gzNc3zstz+vE6hgheZny7F/f55fcqggkyW/aIjhmtCEIStj5h+nQgwSvzK7+eLoCUv ZQd1k8gI0vplzlss/5mqhzfx6gC6mR+y9thawd548kAEbOZHOK668p1gjbixPe7yjlKL mpsyDjrakOeFF6cs5riw6sVztMi13Omy9MlkJdObKY39Y/gsIgbAB0/cMo9pwjBBnvDD A1sMhBhcULEsCkCPHOgKXbQiqpu8HPQnYKpg4a3Y8XSb4p59OvrOXqxdvMhjZhA9zcWu KJMyiLkWJjQdsh8MCFrh06nlhFAlGGe0/vakb5lV7V3AXbCCitM75MgkKSKToyfguzrv +aiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786107929; x=1786712729; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=zPSj/US9YmoirR4APoqZkFkgfkruTVQ3Bn0PlYTwpLo=; b=m8iB97T/y1Ek9xqFuUI32GUeDPosDYYRRCbpmHFidP8N86YJDk+b6LDdIo7yRsGLnB BmPDLUMGpIMXqsRTqUjVMJYtXmuOUf4HGZP+b8yBtxEU8TMeo2Ff7Tc4USdKbdKN/dIw CdM29PbsLhsY8LzTZUjz1Csxe+FK9rMDx2DTI9UvcleVgMwQka22wTh+IiFfRuugDk9z bCp8fSZQfktLlNkTr1bmDb4tk8KMJIFjWmNI5fehu569E1yGWhH0QEPybQozOpw+4uiF Bc0bfu0VixMCm5eAXqa5awtm7hyZm6ntlWXSOMMi2BJVg6/uMCIU8oA3B+rAIebYAlDk xsrw== X-Forwarded-Encrypted: i=1; AHgh+RqmaY9BDSqlF7jm3zNtPcie3GdU4iCWIkCal71ORIxm1ByUMUaurzif1erFdGQaJnuuJANu0NcVTANTdUs=@vger.kernel.org X-Gm-Message-State: AOJu0YwrD5bOYSRIRGWZHhVKNzKH1/6QfgswX28N2jYk87aCNE6hbn7E pvoUN72nceoA7t8KJPJjOtCtRIAIKLHN9Mary6vyEOKLKRJstmOX8i18m7HfS8Y9/iVbVnkv77Y jxluVvWe3IV5z5xMWMB4LVdyvQBxwXDDmxsokElVbvBDByxfKHW/uCGNEqPzufcGmHXTFhdbkoI E8dw== X-Gm-Gg: AR+sD13CrqapskNlKxa1CsPKODKefTfp4LvD5CJOoUc08+r051NjR2ZIQBCMhvHWt76 9Qohlqf0vQyrH7lmQUbgEp4pfAohL5T/WxaCUDypspl6S8qrXG/YNzWGhRIdpEi3/JfETcn7/As mYQR6+xhYmOryPJZvXN6XAOIU9L4+eCWKAtsa75zZH6/MLYfiOz2Da4k9VtyJS24W52O2r7nrXH PztUEc/N58/040PTwlCrE9ptCF8kOP2Tj0R7yMZnFGoMf9/4hlYx6eIFU96i6xd6YlfUwrtz1UA xgWaz1LgLfR52s1eo2G/32g3NTrGmh3HOi78hRETrr97sgUNRzXPKlZx67YJ4drUTiw0GYw+KU9 GCnMBRKyl4LgYJB0UiqEEnZzjLtf+axONxLG09WIbuq87Zg== X-Received: by 2002:a05:6122:6609:b0:5a0:370:f12c with SMTP id 71dfb90a1353d-5c409440bf1mr405014e0c.11.1786107929351; Fri, 07 Aug 2026 06:05:29 -0700 (PDT) X-Received: by 2002:a05:6122:6609:b0:5a0:370:f12c with SMTP id 71dfb90a1353d-5c409440bf1mr404933e0c.11.1786107928770; Fri, 07 Aug 2026 06:05:28 -0700 (PDT) Received: from [192.168.2.1] (146725694.box.freepro.com. [130.180.211.218]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48002145971sm5546657f8f.8.2026.08.07.06.05.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Aug 2026 06:05:27 -0700 (PDT) Message-ID: Date: Fri, 7 Aug 2026 15:05:23 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] thermal/drivers/qoriq: Disable clock on resume failure To: Can Peng , rafael@kernel.org, daniel.lezcano@kernel.org Cc: rui.zhang@intel.com, lukasz.luba@arm.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260722075625.452684-1-pengcan@kylinos.cn> Content-Language: en-US From: Daniel Lezcano In-Reply-To: <20260722075625.452684-1-pengcan@kylinos.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=EYH4hvmC c=1 sm=1 tr=0 ts=6a75d81a cx=c_pps a=1Os3MKEOqt8YzSjcPV0cFA==:117 a=uw/3876vWhRnNVL35W6mqQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=VwQbUJbxAAAA:8 a=DKkMA6O2ID4Q9JsdpvQA:9 a=QEXdDO2ut3YA:10 a=hhpmQAJR8DioWGSBphRh:22 X-Proofpoint-ORIG-GUID: frhEWbqEoVj0NNQljZ8hTzu257Zxclu- X-Proofpoint-GUID: frhEWbqEoVj0NNQljZ8hTzu257Zxclu- X-Proofpoint-Spam-Info: AW1haW4tMjYwODA3MDEwMiBTYWx0ZWRfX4G63+xvBDRmd TfUEPeEc/Oa/6k2LkYdf4uEeOK6a8qZJ/rOCPpYmdMz3B/W9lU2R+xxHyHt9ba5YOfilklJDj2/ p0G5Xo9sFYXwsG36qjP94Ca9ojdNPZk= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODA3MDEwMiBTYWx0ZWRfXzIiKbLHaoVaO U3qdhTpSjYbRm1qJqogZ8+7HOO0xtXfLgMZJW33kotwP6LexWZxsqkGqfWeFK+h/RWfz4C0r0e2 pSWtQSInbFbV4ZO++jvmZnLThafK4jpfVx6Ce7m2ND6UoMexRYt8V0QfBphMqhROBMoTAGjtkbh 7g8IaDEmwLfepNzQny4qVciH+REX/RyeXGdwRfpb1YdKojN65sCzd9TJNgTnXIcVfMIv0yn9Dkh tuodtfNwiD7Kezy7F6rAdDGvT8nvR9ioOBWZM8FYm8NleoZe5v2k2PuBRDCmxFWf6wERSdk6eAs C7FSwnqHcynAFawf5I1dJ5oObMVdMc+Fe5q45tSWXGtTymgjgvoP+p9R5OVijrmaoCylJsVnJIx TOS0RTC7DO9uh6FMnmRFEY7x+07fWOZ2frIpdgYbokvE6LJ+HTZdC8z/w69SF3/FMnxC2Da5/pp wjh6rcOb90aHUNdbsew== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-07_02,2026-08-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 phishscore=0 suspectscore=0 priorityscore=1501 spamscore=0 clxscore=1015 malwarescore=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608070102 On 7/22/26 09:56, Can Peng wrote: > qoriq_tmu_resume() enables the TMU clock before clearing the > power-down bit and enabling monitoring. > > If either register update fails, the function returns with the clock > still enabled. This leaves the clock enable count unbalanced after a > failed resume. > > Disable the clock on those failure paths before returning the error. > > Fixes: 51904045d4aa ("thermal: qoriq: Add clock operations") > Cc: stable@vger.kernel.org > Signed-off-by: Can Peng > --- Applied, thanks