From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7BCD38F630 for ; Mon, 8 Jun 2026 07:44:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780904642; cv=none; b=Puqo+HEYt7nUa4IqQfF6p0CsGHa5vuYtlAaHS4nfSw/JApAqwO/Q2dHWlgfNKu3fmY2iudP1Pr1WRlz1kmbbGZ0Q9YnJdAEXX6FEO6Hhy4siiejc9u+9c62iAF2hAb1fWSG2BfPb0X+2MA/0MS7KhgXHNh7WNSBm8f+PLP5Xtvk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780904642; c=relaxed/simple; bh=PFUHre06+HVUrAuZiI/mIYZTvStr/7Tol6OMle7Doh4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NOJMO4xRQXW6TGNgoauLihSqbS13B6otTRchqK/AM8DdnwX/aFkXfh81qhFkBwd4pljrLEAS8x+a3GG7upOUrVtgjZFu03EEpy/MfEckffyaCGDpk3cmG+hjpIKEiozQvTOnDr7r2krOLeDimsdR+VipuiMljiYekS2BCzSXVL4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bxyPT2Qv; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Vr3xxG0C; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bxyPT2Qv"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Vr3xxG0C" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6586Ou3l2832966 for ; Mon, 8 Jun 2026 07:44:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Ll9jicp1T8nD2iVAfwGQTwpackBft8jmAmcVwn6yJEI=; b=bxyPT2Qvf1aF34RR 7mgHLg0xLIrXsp3fDymEKgTA+DE/vVP+Sf7AP+9vN84HHYI5p0A1YZe7g8FT9PD8 RGWPFecrMcevs7Hi6Re3huKV4QX+KV9LXihysgGu67JEeq7nzgRC+3CtgtPq8QcI pi1YOy5YfxZ5mCXSFLm634EG0O+/VUadBkO+3Jcpleu8F2OVdbeaQW8y0z5StCo1 nbv3V/S4Lv/Qcfky3aZwQjBnlkL1k3LdjYUMKRl7Xr4s7tXMdMy5y2M7yrkKX4L/ 0STpFPRmeHwJxNKNvjHvrvTTPv/aOZ+4d0XVFdFS294I2FWwBQBa+/CrQBdDFwnx VAPS5w== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4embmremrb-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 08 Jun 2026 07:43:59 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-9156dc90fdaso116572385a.0 for ; Mon, 08 Jun 2026 00:43:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780904639; x=1781509439; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Ll9jicp1T8nD2iVAfwGQTwpackBft8jmAmcVwn6yJEI=; b=Vr3xxG0CfSfUPjuM57t2NW8xaAAUtaFrbxG6UksXJ15LJ99TxSDttZn3/ke9xOhU6l M9P8NSjHhrfHxOUV066dJ8w1fvoLlQBUxiWNX3RIqirSe9k3KovmJ45FDFeYZ1mAhkw2 jGRTeAznon/+PEPd15xZT0GtdIoC2iHa4S4xXjWtYU0vEH/Kiuvv7AQevk+13m8RGBSV cjr3QL1fQ1l+xATXMYfZOPJJvbKcFU5r2zriEzLffIOXBBe76C947UuBONXkmen9vHQL vpgdmAdBO14PmyH/IoPsrZZmYIf/VdcBkRiHeXrJcY64WcXP5yAKCv2vPFK8kpxTGXyP U4ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780904639; x=1781509439; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Ll9jicp1T8nD2iVAfwGQTwpackBft8jmAmcVwn6yJEI=; b=MgCGhamqJDntlaHU9MW36XMpfmlb8QmFWR+dehnuwA1LgmWF8uWPCHvVGsb7m2aYla mX7w/8ey7anXhknN0qM1c9yMMrFnh4hdLPNDE5GF3ISLpMD4BjiBxFM2mGRLcgU8yyJQ gpYypDARK8eOHtcA59WUJPrNP0lNIk1Tka/2YjKge1V73VzV98HX6Yz0IsjWpjm05cAk JT4A+tYvSi2Hh4L9Gmq+1RbyRcMCpNwUFnExhAL7CERECa5ZI4/xcy07kGImgj8B+Sqm 6JytrHKls7oJD+E37yjzt2pKx+arx+WLUFmR6luISx6Tt/cW19ve9OSormxgenXEYopC QIUg== X-Forwarded-Encrypted: i=1; AFNElJ8o4JXyIzfkrO3BrJc1+fK2lE7iB5F+SUIvu6ZT9e5KD/kEVa7SRCT/0ivrjLyirfHy66PM3DbCUqBlLzI=@vger.kernel.org X-Gm-Message-State: AOJu0YxDVsREm0Wy0/m9nDohIsIUGUh5+3+s0QbqluuQagVsNmOEPfkW CC6ilRFKUYoLZibx0lLrSYtTap/D0yds6plHEiNlhNC7DlYM4JYNMRta74cusAf/adDydT3ISpr XgpsB07KJcuV4ITVKlrQAe4uRQ0/NgTLhctkRkfvuVGwYpJ7AGnAo+Q9j8SwRjjKKLXA= X-Gm-Gg: Acq92OGTPDaBvLJd1CppwrfxITmQnOsUTCw9bRq/Li6q4UMrjG6zTqzy+WswpeDb2Dc BVZxFhrt/P2EeTTD1c/yMzWYCwuJRKNuIJKlkuHxoYYtFQYhbbzpONhCsZmsFHa5LBqggYNFuaZ ay92LknjzUO8MNBCt4l4OjSU0Dxpcgio8+vRohPlzHCUOE/nyqRVmyt+YBFYX5PIQ92n4DrzKhF p7RQjsDGvVSOJ493+kslVgZ3/CVkag3oLkHfgY/o21CtL3hYb3spXQRnEXxnbUcHCDouF8YZ1zr lg+kp6WpSak0DxTadMrm+ZzG3TNjfoM/rgVZglJxuWVNaMP9+/2mTpQuLxr041qhpiwyqXwZK98 IpcZ8kt2XYZAkID1K99b3pwt3WcMLnwSnFaWgMS1hjS5M9zOdBzSRjg92 X-Received: by 2002:a05:620a:4145:b0:8f1:9e59:2208 with SMTP id af79cd13be357-915a9d5af7fmr1387110985a.4.1780904639233; Mon, 08 Jun 2026 00:43:59 -0700 (PDT) X-Received: by 2002:a05:620a:4145:b0:8f1:9e59:2208 with SMTP id af79cd13be357-915a9d5af7fmr1387108385a.4.1780904638766; Mon, 08 Jun 2026 00:43:58 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-68e64c2f1bbsm6686090a12.2.2026.06.08.00.43.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Jun 2026 00:43:58 -0700 (PDT) Message-ID: Date: Mon, 8 Jun 2026 09:43:55 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 07/15] drm/msm/dp: move the pixel clock control to its own API To: Yongxing Mou , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Abhinav Kumar , Dmitry Baryshkov References: <20260602-dp_mstclean-v6-0-2c17ff40a9b2@oss.qualcomm.com> <20260602-dp_mstclean-v6-7-2c17ff40a9b2@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260602-dp_mstclean-v6-7-2c17ff40a9b2@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA4MDA3MCBTYWx0ZWRfX01Ti3Nd10q51 WQmgn45xvzr5L87nna2gpwSAVU0mTQbcK2zm0Zgh64lFJWGhLb2JMo1YgKZ+TZZjVSgAhWjuV5K 5Lmu3kABly4N9RY+n3Bhblb13pp123VDzADGi6kvMfwvTH1wfJxbg94Ita+le02cdK7pFMUcAmi X9xr8CUjYXKUQjNIu+TMW9+u+OupBR/82Vivs5N0/2ZJ8QZquTINl8Pe0FcWxvwE7ZBE4ksE0V6 oT5Ve11MxPfkMaKHSA7qTfqGjGEg71tptZGplht13g1OHJ/o21zOx7PR0YoGfGWQMAvrrDJNyak XKBCy2lxwM/R1DuIUhNf2+0hwhEo58DAdi1BXn76BVLP+WsQmOVC0CpiE+i++lkxqa4eiWUFsOt v9CYsOhSIk1ijk/LTz1heyagppep4ahzz5Z/18W6Ut3lMv9LNc1raITBCF8sZjwiNEo+pTppooj 7LWUhjjyeIF98XDpGtA== X-Authority-Analysis: v=2.4 cv=B5eJFutM c=1 sm=1 tr=0 ts=6a2672bf cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=YadZbbKFZxuD_lQ-BoMA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-GUID: nMXRVaLakJZoZ576Sf6law1xf7aa9moU X-Proofpoint-ORIG-GUID: nMXRVaLakJZoZ576Sf6law1xf7aa9moU X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-08_02,2026-06-05_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 spamscore=0 malwarescore=0 phishscore=0 bulkscore=0 clxscore=1015 adultscore=0 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606080070 On 6/2/26 11:11 AM, Yongxing Mou wrote: > Enable/Disable of DP pixel clock happens in multiple code paths > leading to code duplication. Move it into individual helpers so that > the helpers can be called wherever necessary. > > Signed-off-by: Abhinav Kumar > Signed-off-by: Yongxing Mou > Reviewed-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/dp/dp_ctrl.c | 81 +++++++++++++++++++++------------------- > 1 file changed, 42 insertions(+), 39 deletions(-) > > diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c b/drivers/gpu/drm/msm/dp/dp_ctrl.c > index 1c2eccec6ec6..ac0a2c387f03 100644 > --- a/drivers/gpu/drm/msm/dp/dp_ctrl.c > +++ b/drivers/gpu/drm/msm/dp/dp_ctrl.c > @@ -2171,6 +2171,42 @@ static bool msm_dp_ctrl_send_phy_test_pattern(struct msm_dp_ctrl_private *ctrl) > return success; > } > > +static int msm_dp_ctrl_on_pixel_clk(struct msm_dp_ctrl_private *ctrl, unsigned long pixel_rate) > +{ > + int ret; > + > + ret = clk_set_rate(ctrl->pixel_clk, pixel_rate * 1000); > + if (ret) { > + DRM_ERROR("Failed to set pixel clock rate. ret=%d\n", ret); > + return ret; > + } > + > + if (ctrl->stream_clks_on) { > + drm_dbg_dp(ctrl->drm_dev, "pixel clks already enabled\n"); if (WARN_ON_ONCE(ctrl->stream_clks_on)) return 0; ? Konrad