From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1245C433FE for ; Wed, 27 Oct 2021 08:32:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8875E60E54 for ; Wed, 27 Oct 2021 08:32:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239231AbhJ0Iee (ORCPT ); Wed, 27 Oct 2021 04:34:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45394 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240787AbhJ0IeW (ORCPT ); Wed, 27 Oct 2021 04:34:22 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2691AC061228; Wed, 27 Oct 2021 01:30:56 -0700 (PDT) Received: from [192.168.1.111] (91-158-153-130.elisa-laajakaista.fi [91.158.153.130]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 6BD9A596; Wed, 27 Oct 2021 10:30:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1635323454; bh=V2brccML3+QxKykFo706VWpR5RyEZhjwMfXQLBLZpwc=; h=Subject:From:To:Cc:References:Date:In-Reply-To:From; b=I8PsZUe4ZzGQSagSPxAVtt2OXiMVu7VGOn7XWv0c7HKXYDedfuVlfaBOpcO/IrkRj pw+2GMlb4gjX2u61Aj0ZrnRxSqCyXI+JakgmJvmFdzgv4FNbtXD/kOMkNI2tYnav1M laWYH5bh/qJtut9Iringv3k5gPSdalYLqT/xxog0= Subject: Re: [PATCH v6 1/9] drm/omap: add sanity plane state check From: Tomi Valkeinen To: Neil Armstrong Cc: linux-omap@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, khilman@baylibre.com, Benoit Parrot References: <20211018142842.2511200-1-narmstrong@baylibre.com> <20211018142842.2511200-2-narmstrong@baylibre.com> Message-ID: Date: Wed, 27 Oct 2021 11:30:51 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/10/2021 11:29, Tomi Valkeinen wrote: > On 18/10/2021 17:28, Neil Armstrong wrote: >> Call drm_atomic_helper_check_plane_state() from the plane >> atomic_check() callback in order to add plane state sanity >> checking. >> >> It will permit filtering out totally bad scaling factors, even >> if the real check are done later in the atomic commit. > > I think there's more to it: the function sets plane_state->visible, > which is used in later patches. Maybe that could be mentioned in a comment. But otherwise: Reviewed-by: Tomi Valkeinen Tomi