From: Roger Quadros <rogerq@kernel.org>
To: Siddharth Vadapalli <s-vadapalli@ti.com>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
linux@armlinux.org.uk, pabeni@redhat.com, geert@linux-m68k.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, srk@ti.com
Subject: Re: [PATCH net-next] net: ethernet: ti: am65-cpsw: Handle -EPROBE_DEFER for Serdes PHY
Date: Thu, 19 Jan 2023 12:30:21 +0200 [thread overview]
Message-ID: <d498d873-13a2-c516-17cd-af21e1d9de3b@kernel.org> (raw)
In-Reply-To: <20230118112136.213061-1-s-vadapalli@ti.com>
On 18/01/2023 13:21, Siddharth Vadapalli wrote:
> In the am65_cpsw_init_serdes_phy() function, the error handling for the
> call to the devm_of_phy_get() function misses the case where the return
> value of devm_of_phy_get() is ERR_PTR(-EPROBE_DEFER). Proceeding without
> handling this case will result in a crash when the "phy" pointer with
> this value is dereferenced by phy_init() in am65_cpsw_enable_phy().
>
> Fix this by adding appropriate error handling code.
>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Fixes: dab2b265dd23 ("net: ethernet: ti: am65-cpsw: Add support for SERDES configuration")
> Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
Reviewed-by: Roger Quadros <rogerq@kernel.org>
next prev parent reply other threads:[~2023-01-19 10:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 11:21 Siddharth Vadapalli
2023-01-19 10:30 ` Roger Quadros [this message]
2023-01-20 3:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d498d873-13a2-c516-17cd-af21e1d9de3b@kernel.org \
--to=rogerq@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=geert@linux-m68k.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=s-vadapalli@ti.com \
--cc=srk@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome