From: Dave Kleikamp <dave.kleikamp@oracle.com>
To: Rand Deeb <rand.sec96@gmail.com>,
jfs-discussion@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Cc: deeb.rand@confident.ru, lvc-project@linuxtesting.org,
voskresenski.stanislav@confident.ru
Subject: Re: [PATCH] fs/jfs: Prevent integer overflow in AG size calculation
Date: Thu, 20 Feb 2025 09:39:46 -0600 [thread overview]
Message-ID: <d4a19c65-683a-4ae0-89a6-8c4c1590f51e@oracle.com> (raw)
In-Reply-To: <20250220095231.1686611-1-rand.sec96@gmail.com>
On 2/20/25 3:52AM, Rand Deeb wrote:
> The JFS filesystem calculates allocation group (AG) size using 1 <<
> l2agsize in dbExtendFS(). When l2agsize exceeds 31 (possible with >2TB
> aggregates on 32-bit systems), this 32-bit shift operation causes undefined
> behavior and improper AG sizing.
>
> On 32-bit architectures:
> - Left-shifting 1 by 32+ bits results in 0 due to integer overflow
> - This creates invalid AG sizes (0 or garbage values) in
> sbi->bmap->db_agsize
> - Subsequent block allocations would reference invalid AG structures
> - Could lead to:
> - Filesystem corruption during extend operations
> - Kernel crashes due to invalid memory accesses
> - Security vulnerabilities via malformed on-disk structures
>
> Fix by casting to s64 before shifting:
> bmp->db_agsize = (s64)1 << l2agsize;
>
> This ensures 64-bit arithmetic even on 32-bit architectures. The cast
> matches the data type of db_agsize (s64) and follows similar patterns in
> JFS block calculation code.
Adding this to jfs-next.
Thanks,
Shaggy
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Rand Deeb <rand.sec96@gmail.com>
> ---
> fs/jfs/jfs_dmap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/jfs/jfs_dmap.c b/fs/jfs/jfs_dmap.c
> index f9009e4f9ffd..edb22cf9521a 100644
> --- a/fs/jfs/jfs_dmap.c
> +++ b/fs/jfs/jfs_dmap.c
> @@ -3403,7 +3403,7 @@ int dbExtendFS(struct inode *ipbmap, s64 blkno, s64 nblocks)
> oldl2agsize = bmp->db_agl2size;
>
> bmp->db_agl2size = l2agsize;
> - bmp->db_agsize = 1 << l2agsize;
> + bmp->db_agsize = (s64)1 << l2agsize;
>
> /* compute new number of AG */
> agno = bmp->db_numag;
prev parent reply other threads:[~2025-02-20 15:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-20 9:52 Rand Deeb
2025-02-20 15:39 ` Dave Kleikamp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4a19c65-683a-4ae0-89a6-8c4c1590f51e@oracle.com \
--to=dave.kleikamp@oracle.com \
--cc=deeb.rand@confident.ru \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=rand.sec96@gmail.com \
--cc=voskresenski.stanislav@confident.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®