From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D97A4330B00 for ; Wed, 4 Feb 2026 05:10:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770181850; cv=none; b=B7jOw74AboM8iapmfwoFB9vPDR79cpyYBgn/NeWYHY9tfSVjK166XO3Evnqv2+HCoenRcEec/RyNjrs7lsUN0jdf5KQU6VwENq+keVxCZF3CEK+QJbQNH+B53+aLvuFq6iYROa/pOeCD56Ag+pWzZOX4d4Jhxwh3WchR2lebOGU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770181850; c=relaxed/simple; bh=Cl8nmQiPPZ3zMD2xLWnUAdj/4XyXZt4JU5y4x0hFQpE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nbEPvUH1xAF0MMq9XxJWRvNoPcbCwjj13wYBk24G/qsiu+2PW8A/4+omsbnnpzyuP8+W7quNHIWxClJBeURT6Ea8I2G+ulnpk4yapsnN4KkCuxCufpCdWsDXsHNqwCaLR8wxwnvgxQeQvGv8zoC99bBryMzPxTErnL1uaHTWLTk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PTZtq4MM; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XGhj9VRL; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PTZtq4MM"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XGhj9VRL" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6144Hj0o2667102 for ; Wed, 4 Feb 2026 05:10:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= b2yk1SXP0cSKoeq0NtffjWATsVhRHufpkROfd+0puu4=; b=PTZtq4MMpmAemyhd /KsLx2pZ9SnScDMJRJEY8rLfgsO6mhkzGvBZ0jo0L+op7ABudMvxKUHIkedclzlK Agb0W3vl8gG+gjU+dVN6TdZm3rNfFKQQPsyZHgAKuB2AbVk8m6phBD4+4g3vmpwB gxw28YvVGv86H9TgYCyT7cET5IfUtFptxkfL7TMJVs7eIZHJk7y/PA5U0EyIsadn DWfiivpnlCdxAIwu5vpqeGSmPBs9oh+d7fdRQK7wLOozWmOKBylTpZqldFd0IdUj /iOp8QhEjQ8VOCvh9WuEMBQRP7s/iuzT6lIb35OzQLqElbiTY0VQHbAMLuBrVFdz DlB0NQ== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c3nf61xuy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 04 Feb 2026 05:10:48 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-29f2381ea85so146989695ad.0 for ; Tue, 03 Feb 2026 21:10:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770181848; x=1770786648; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=b2yk1SXP0cSKoeq0NtffjWATsVhRHufpkROfd+0puu4=; b=XGhj9VRLhA2NL7K976NIgA5cttTZNFWCBaeAbz954OH52LHDhkAvuIfC5qLg7heoLc RsEIul/EcRcyskxmSgzJ5407JrmfFIoiUOt8Llt6pQTOhTm4Jztpu4R5Hcet4rjzMtZ6 4TPGz7etF+QBw3lYuKz0GVOAYkBaIT2t8+BmrmbOPYveFzZOtYiol0CFTqp2YV7p5FM1 aEcuSPNrNgYvStm6/itMiMGfL8sq7kwzrj0uiAKPWVFpT6ibSIkV+1wiym0hdZx/pWCR tqcCkBGWzNepDY0EG8X0CUDE62cy2vvEx+uI4ixIVyuWKj+244mTi9CR2f6JpRc4/TAD 0Q4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770181848; x=1770786648; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=b2yk1SXP0cSKoeq0NtffjWATsVhRHufpkROfd+0puu4=; b=aVLJjxVrPwjSgunrJGDSIe9G+MzFHHfCbq9HiCL3yIDDy9eEm93QPzv6w98Pj//y7/ Kr4keAubNU7KPQNq/fxEmtXLIdPn15WQGzDJypO7C3N4Syoi8YySHdxEcgXEmN2bQIyw +DD9brGVv5LMEbu3KAApl5XdxLifFNnNVoN74bMiAwX3Ea2UVgijLy40kULOqW0K7s3Y j415D7YuB/V8baILsxDXI9+F2+knPrnwX7ieiAi1jP3YBcuR4Zx050XbI7BxVSO04kJo cN69EOJIS5eWBwy7P0r9m6UnrjC90Rb3mG978+TYHOjgNaonqTBwGmaQ3a3bo0zqTToj 6rdg== X-Forwarded-Encrypted: i=1; AJvYcCX2Pqznp+nAKkwjCgXQPpJ1kMpKq0wdGlsGMF2Z6DeJRxydTBAPIGn7Gwn1FsZvx4X5rhD8a/sLLVT0Uf4=@vger.kernel.org X-Gm-Message-State: AOJu0Yw69uK0cIl/jWJc4in/88F70LsOEY7hhAmIRScan+/ZLSdw5Y8l VLHTEwNrL1r+hP0W4vUps/rPuFzCCZSKhZVoY+ZdK7TWVMUi9/leiUQilPFiu5MRTTTRJ9JoooS SXfWR/C7t+fNcvJSLZGC+pdxC9gbkhiHzH/01NBZEXP1fqhFASHH00UMRAq/MMAyxnrgEcEslxj c= X-Gm-Gg: AZuq6aILgyT0kd4PXU3dhfhznSQYIRTMFpjHoQEPJ2eOE3+t6GCV1j7D4U8xyjZt5gf NNRz+G1dbtYF+d++ieaWqltIBemLKEW0oCcYCCitsOFghdNiI+pc1va6UpezD4D0vbVU4pAZf7M Ft82rn1euzyJ+l5wegeiQgyeghEP1XYx2IUOsb5h+tNpkeZZtawpR63thAvARzHkIVqafD4W20D f1LEjzBC1qrTkGZige9dve1n7NBVwLtMUmxgvSQa+csyHjkHbbA90YjsrxkK4HlbYFzhpyEUt9z dyhWeacv91WGN9i2zBvUtVd9xg4KS2JNTFwaFf1DnyphiTfeMKZmWkFuJDKt+o+fRo/qLUiq0MV MLDGs47wfOBqPnNybH3FHX6t/JI1G6DbZQGuvF05oHg== X-Received: by 2002:a17:903:2447:b0:2a0:b06d:1585 with SMTP id d9443c01a7336-2a933ea08d3mr17630755ad.34.1770181847554; Tue, 03 Feb 2026 21:10:47 -0800 (PST) X-Received: by 2002:a17:903:2447:b0:2a0:b06d:1585 with SMTP id d9443c01a7336-2a933ea08d3mr17630495ad.34.1770181846953; Tue, 03 Feb 2026 21:10:46 -0800 (PST) Received: from [10.218.32.171] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a933888e8csm12620115ad.29.2026.02.03.21.10.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Feb 2026 21:10:46 -0800 (PST) Message-ID: Date: Wed, 4 Feb 2026 10:40:39 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 06/13] soc: qcom: geni-se: Introduce helper API for attaching power domains To: Konrad Dybcio , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mukesh Kumar Savaliya , Viken Dadhaniya , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@oss.qualcomm.com, dmitry.baryshkov@oss.qualcomm.com Cc: prasad.sodagudi@oss.qualcomm.com, quic_vtanuku@quicinc.com, aniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com, jyothi.seerapu@oss.qualcomm.com References: <20260202180922.1692428-1-praveen.talari@oss.qualcomm.com> <20260202180922.1692428-7-praveen.talari@oss.qualcomm.com> <2d2bc77b-715d-4484-86c4-4389ebb63856@oss.qualcomm.com> Content-Language: en-US From: Praveen Talari In-Reply-To: <2d2bc77b-715d-4484-86c4-4389ebb63856@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 9lEDJD7iAd3NTflXck78gvKM1UaXiB8f X-Proofpoint-ORIG-GUID: 9lEDJD7iAd3NTflXck78gvKM1UaXiB8f X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjA0MDAzNSBTYWx0ZWRfX5UpUFxHJDe7z KtogmS1axoE7iroMe7LVse0ztLfb+dxzoipxF7tMC0Xw+nPVO4nXZrJ7lRADKLWAdt3C7Di9ksU eEXGgA+xlgn1NIttshcHv1z5F9z05t2sNFgOWWtYOI3snRfZNrk93RZ+HfLElqT1JxiW8x4AQTq xst/USeZTUr7Cus6wXcKJ3Z9333wyE4oHmWi0wLilGnMQukZ3MpYyjtj1tiXLoOR8C2LHfV45T9 pna8azJeKGxd0/Qo3ZbLFk1tKvfPBk8ZsOtf3ZCjhB3ouN4p/o5EkOoKISWluHGLbqSNVan9RpR UkQK8T9uSxNSjoxHfsjERY17RbA8dxDk3wsIjMn7bBZeWdXjPOA1HyvILu8fxxuII7HGLBPji2D ThQgyHIll3uu1glhV8Mh0trE93hVBqo9/qzwewcElLJKpRMz2VYtc8gztjXzaFfcy9/c0qj5pbY uZRMsbhR3XIVjXN2ajA== X-Authority-Analysis: v=2.4 cv=doTWylg4 c=1 sm=1 tr=0 ts=6982d4d8 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=RFm3ULBN9CpRR-2xPD0A:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-03_07,2026-02-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 impostorscore=0 suspectscore=0 spamscore=0 priorityscore=1501 bulkscore=0 phishscore=0 lowpriorityscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602040035 On 2/3/2026 5:53 PM, Konrad Dybcio wrote: > On 2/2/26 7:09 PM, Praveen Talari wrote: >> The GENI Serial Engine drivers (I2C, SPI, and SERIAL) currently handle >> the attachment of power domains. This often leads to duplicated code >> logic across different driver probe functions. >> >> Introduce a new helper API, geni_se_domain_attach(), to centralize >> the logic for attaching "power" and "perf" domains to the GENI SE >> device. >> >> Signed-off-by: Praveen Talari >> --- > > [...] > >> +int geni_se_domain_attach(struct geni_se *se) >> +{ >> + struct dev_pm_domain_attach_data pd_data = { >> + .pd_flags = PD_FLAG_DEV_LINK_ON, >> + .pd_names = (const char*[]) { "power", "perf" }, >> + .num_pd_names = 2, >> + }; >> + int ret; >> + >> + ret = dev_pm_domain_attach_list(se->dev, >> + &pd_data, &se->pd_list); > > Let's use devm_pm_domain_attach_list() (notice the 'm'), as the list > is never detached from at the moment Sure, will add in next version. Thanks, Praveen Talari > > otherwise lgtm > > Konrad