From: Arnaud POULIQUEN <arnaud.pouliquen@foss.st.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Jens Wiklander <jens.wiklander@linaro.org>
Cc: <linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-remoteproc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<op-tee@lists.trustedfirmware.org>
Subject: Re: [RFC PATCH 3/4] dt-bindings: remoteproc: add compatibility for TEE support
Date: Tue, 30 May 2023 17:00:07 +0200 [thread overview]
Message-ID: <d4a98500-5cb0-b3fd-7f40-8b56a2258619@foss.st.com> (raw)
In-Reply-To: <1b4eba7e-2771-b0c8-ec23-2ed882374e5d@kernel.org>
Hello Krzysztof,
On 5/30/23 13:50, Krzysztof Kozlowski wrote:
> On 23/05/2023 11:13, Arnaud Pouliquen wrote:
>> Rework compatibility description according to the support of
>> the authenticated firmware relying on OP-TEE authentication.
>>
>> The expected behavior is:
>> - with legacy compatible "st,stm32mp1-m4" the Linux kernel loads a
>> non-signed (ELF) firmware image,
>> - with compatible "st,stm32mp1-m4-tee" the Linux kernel load a signed
>> firmware image. In this case it calls TEE services to manage the firmware
>> loading and the remoteproc life-cycle.
>>
>> Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
>> ---
>> .../bindings/remoteproc/st,stm32-rproc.yaml | 33 +++++++++++++++++--
>> 1 file changed, 30 insertions(+), 3 deletions(-)
>
> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC. It might happen, that command when run on an older
> kernel, gives you outdated entries. Therefore please be sure you base
> your patches on recent Linux kernel.
>
> You missed at least DT list (maybe more), so this won't be tested.
> Please resend and include all necessary entries.
>
> Because of above and RFC, I assume there is no need for review. Just to
> be clear - that's a no.
I did not add DT list and maintainers intentionally to avoid that you
review it.
As in a first step the associated OP-TEE pull request has to be reviewed.
And my plan was just to share the Linux implementation part until the
OP-TEE review cycle is finished.
Now regarding your mail (and very interesting feedback from Christoph Hellwig),
it was clearly not the good strategy.
So my apologize and next time whatever the objective of the series I will add
all peoples and lists in the loop.
Thanks,
Arnaud
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2023-05-30 15:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 9:13 [RFC PATCH 0/4] introduction of a remoteproc tee to load signed firmware images Arnaud Pouliquen
2023-05-23 9:13 ` [RFC PATCH 1/4] tee: Re-enable vmalloc page support for shared memory Arnaud Pouliquen
2023-05-24 6:46 ` Christoph Hellwig
2023-05-24 14:01 ` Arnaud POULIQUEN
2023-05-26 12:37 ` Christoph Hellwig
2023-05-29 7:17 ` Arnaud POULIQUEN
2023-05-23 9:13 ` [RFC PATCH 2/4] remoteproc: Add TEE support Arnaud Pouliquen
2023-05-24 6:50 ` Christoph Hellwig
2023-05-23 9:13 ` [RFC PATCH 3/4] dt-bindings: remoteproc: add compatibility for " Arnaud Pouliquen
2023-05-30 11:50 ` Krzysztof Kozlowski
2023-05-30 15:00 ` Arnaud POULIQUEN [this message]
2023-05-30 15:12 ` Krzysztof Kozlowski
2023-05-23 9:13 ` [RFC PATCH 4/4] remoteproc: stm32: Add support of an OP-TEE TA to load the firmware Arnaud Pouliquen
2023-05-30 16:20 ` [RFC PATCH 0/4] introduction of a remoteproc tee to load signed firmware images Mathieu Poirier
2023-05-30 17:12 ` Arnaud POULIQUEN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4a98500-5cb0-b3fd-7f40-8b56a2258619@foss.st.com \
--to=arnaud.pouliquen@foss.st.com \
--cc=andersson@kernel.org \
--cc=jens.wiklander@linaro.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mathieu.poirier@linaro.org \
--cc=op-tee@lists.trustedfirmware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®