From: Dietmar Eggemann <dietmar.eggemann@arm.com>
To: Chuyi Zhou <zhouchuyi@bytedance.com>,
mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org, rostedt@goodmis.org,
bsegall@google.com
Cc: chengming.zhou@linux.dev, linux-kernel@vger.kernel.org,
Vishal Chourasia <vishalc@linux.ibm.com>,
K Prateek Nayak <kprateek.nayak@amd.com>
Subject: Re: [PATCH v3] sched/fair: Remove cfs_rq::nr_spread_over and cfs_rq::exec_clock
Date: Tue, 23 Jul 2024 22:47:22 +0200 [thread overview]
Message-ID: <d4ac0022-5ba4-44b9-ac09-4530a18b0974@arm.com> (raw)
In-Reply-To: <20240720031928.406540-1-zhouchuyi@bytedance.com>
On 20/07/2024 05:19, Chuyi Zhou wrote:
> nr_spread_over tracks the number of instances where the difference
> between a scheduling entity's virtual runtime and the minimum virtual
> runtime in the runqueue exceeds three times the scheduler latency,
> indicating significant disparity in task scheduling.
> Commit 5e963f2bd465 ("sched/fair: Commit to EEVDF") removed its usage.
>
> cfs_rq->exec_clock was used to account for time spent executing tasks.
> Commit 5d69eca542ee ("sched: Unify runtime accounting across classes")
> removed its usage.
I was under the impression this commit removed
'schedstat_add(cfs_rq->exec_clock, delta_exec)' from update_curr() by
mistake?
That's why I sent out this patch back in May:
https://lkml.kernel.org/r/20240503104605.1871571-1-dietmar.eggemann@arm.com
to add it back.
next prev parent reply other threads:[~2024-07-23 20:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-20 3:19 Chuyi Zhou
2024-07-23 20:47 ` Dietmar Eggemann [this message]
2024-07-24 8:01 ` Peter Zijlstra
2024-07-24 9:18 ` Dietmar Eggemann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4ac0022-5ba4-44b9-ac09-4530a18b0974@arm.com \
--to=dietmar.eggemann@arm.com \
--cc=bsegall@google.com \
--cc=chengming.zhou@linux.dev \
--cc=juri.lelli@redhat.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vishalc@linux.ibm.com \
--cc=zhouchuyi@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®